Bug #117194 for Tie-Hash-Check: "scalar(%hash)" return signature changed

Wed Aug 24 14:23:05 2016 SREZIC [...] cpan.org - Ticket created

Subject:

"scalar(%hash)" return signature changed

Since perl 5.25.3 t/Tie-Hash-Check/10-scalar.t fails: # Failed test 'Get scalar value of hash.' # at t/Tie-Hash-Check/10-scalar.t line 16. # '2' # doesn't match '(?^:\d/8)' # Looks like you failed 1 test of 2. t/Tie-Hash-Check/10-scalar.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Probably the relevant change from perl 5.25.3's perldelta document: "scalar(%hash)" return signature changed The value returned for "scalar(%hash)" will no longer show information about the buckets allocated in the hash. It will simply return the count of used keys. It is thus equivalent to "0+keys(%hash)". A form of backwards compatibility is provided via "Hash::Util::bucket_ratio()" which provides the same behavior as "scalar(%hash)" provided prior to Perl 5.25.

Wed Aug 24 14:25:40 2016 SREZIC [...] cpan.org - Reference to perl ticket #128482 added

Thu Aug 25 07:30:42 2016 SKIM [...] cpan.org - Correspondence added 15 min

Dne St 24.srp.2016 14:23:05, SREZIC napsal(a): Show quoted text

> Since perl 5.25.3 t/Tie-Hash-Check/10-scalar.t fails:

Thanks for report. I created 0.04 release with fix. M.

Thu Aug 25 07:30:42 2016 The RT System itself - Status changed from 'new' to 'open'

Thu Aug 25 07:30:48 2016 SKIM [...] cpan.org - Taken

Thu Aug 25 13:17:57 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-08-25 07:30:42, SKIM wrote: Show quoted text

> Dne St 24.srp.2016 14:23:05, SREZIC napsal(a):

> > Since perl 5.25.3 t/Tie-Hash-Check/10-scalar.t fails:

> > Thanks for report. > I created 0.04 release with fix. > > M.

Unfortunately it also fails with 0.04: # Failed test 'Get scalar value of hash.' # at t/Tie-Hash-Check/10-scalar.t line 23. # '2' # doesn't match '(?^:\d/8)' # Looks like you failed 1 test of 2. t/Tie-Hash-Check/10-scalar.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests

Thu Aug 25 13:26:18 2016 SKIM [...] cpan.org - Correspondence added

Dne Čt 25.srp.2016 13:17:57, SREZIC napsal(a): Show quoted text

> On 2016-08-25 07:30:42, SKIM wrote: > Unfortunately it also fails with 0.04:

Hm.. Installing 5.24.4 :-/ M.

Thu Aug 25 13:29:37 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-08-25 13:26:18, SKIM wrote: Show quoted text

> Dne Čt 25.srp.2016 13:17:57, SREZIC napsal(a):

> > On 2016-08-25 07:30:42, SKIM wrote: > > Unfortunately it also fails with 0.04:

> > Hm.. Installing 5.24.4 :-/

5.25.4, hopefully...

Thu Aug 25 13:32:11 2016 SKIM [...] cpan.org - Correspondence added

Dne Čt 25.srp.2016 13:29:37, SREZIC napsal(a): Show quoted text

> On 2016-08-25 13:26:18, SKIM wrote:

> > Hm.. Installing 5.24.4 :-/

> 5.25.4, hopefully...

yes :-) M.

Thu Aug 25 14:30:51 2016 SKIM [...] cpan.org - Correspondence added

Dne Čt 25.srp.2016 13:17:57, SREZIC napsal(a): Show quoted text

> Unfortunately it also fails with 0.04: > > # Failed test 'Get scalar value of hash.' > # at t/Tie-Hash-Check/10-scalar.t line 23. > # '2' > # doesn't match '(?^:\d/8)' > # Looks like you failed 1 test of 2. > t/Tie-Hash-Check/10-scalar.t .... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/2 subtests

Fixed. Sorry for last :-) M.

Thu Aug 25 16:58:36 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-08-25 14:30:51, SKIM wrote: Show quoted text

> Dne Čt 25.srp.2016 13:17:57, SREZIC napsal(a):

> > Unfortunately it also fails with 0.04: > > > > # Failed test 'Get scalar value of hash.' > > # at t/Tie-Hash-Check/10-scalar.t line 23. > > # '2' > > # doesn't match '(?^:\d/8)' > > # Looks like you failed 1 test of 2. > > t/Tie-Hash-Check/10-scalar.t .... > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/2 subtests

> > Fixed. Sorry for last :-)

Sorry, I have still to nitpick: the breaking change happened between perl 5.25.2 and 5.25.3. So the condition should be something like if ($PERL_VERSION lt v5.25.3) { See also http://fast-matrix.cpantesters.org/?dist=Tie-Hash-Check%200.05

Thu Aug 25 17:26:08 2016 SKIM [...] cpan.org - Correspondence added

Dne Čt 25.srp.2016 16:58:36, SREZIC napsal(a): Show quoted text

> Sorry, I have still to nitpick: the breaking change happened between > perl 5.25.2 and 5.25.3. So the condition should be something like > > if ($PERL_VERSION lt v5.25.3) { > > See also http://fast-matrix.cpantesters.org/?dist=Tie-Hash- > Check%200.05

ok, fixed. M.

Fri Aug 26 04:09:11 2016 SKIM [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Aug 26 04:09:11 2016 SKIM [...] cpan.org - Fixed in 0.06 added