Bug #117088 for Performance-Probability: perlcritic test may fail

Sun Aug 21 04:04:23 2016 SREZIC [...] cpan.org - Ticket created

Subject:

perlcritic test may fail

Some of my smoker machines show the following failure: # Failed test 'Test::Perl::Critic for "blib/lib/Performance/Probability.pm"' # at /opt/perl-5.24.1-RC3/lib/site_perl/5.24.1/Test/Perl/Critic.pm line 104. # # Private Member Data shouldn't be accessed directly at line 58, column 23. Accessing an objects data directly breaks encapsulation and should be avoided. Example: $object->{ some_key }. (Severity: 5) # Private Member Data shouldn't be accessed directly at line 58, column 39. Accessing an objects data directly breaks encapsulation and should be avoided. Example: $object->{ some_key }. (Severity: 5) ... (snip) ... # Private Member Data shouldn't be accessed directly at line 214, column 32. Accessing an objects data directly breaks encapsulation and should be avoided. Example: $object->{ some_key }. (Severity: 5) # Found use of die. Use an exception instead at line 215, column 13. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Subroutine "machine_epsilon" is neither declared nor explicitly imported at line 232, column 19. This might be a major bug. (Severity: 4) # Subroutine "cdf" not exported by "Math::Gauss::XS" at line 237, column 19. Violates encapsulation. (Severity: 4) t/perlcritic.t ............... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests

Sun Aug 21 19:15:48 2016 ether [...] cpan.org - Correspondence added

On 2016-08-21 01:04:23, SREZIC wrote: Show quoted text

> Some of my smoker machines show the following failure: > > # Failed test 'Test::Perl::Critic for > "blib/lib/Performance/Probability.pm"' > # at /opt/perl-5.24.1-RC3/lib/site_perl/5.24.1/Test/Perl/Critic.pm > line 104. > # > # Private Member Data shouldn't be accessed directly at line 58, > column 23. Accessing an objects data directly breaks encapsulation > and should be avoided. Example: $object->{ some_key }. (Severity: 5) > # Private Member Data shouldn't be accessed directly at line 58, > column 39. Accessing an objects data directly breaks encapsulation > and should be avoided. Example: $object->{ some_key }. (Severity: 5) > ... (snip) ... > # Private Member Data shouldn't be accessed directly at line 214, > column 32. Accessing an objects data directly breaks encapsulation > and should be avoided. Example: $object->{ some_key }. (Severity: 5) > # Found use of die. Use an exception instead at line 215, column 13. > Exception objects should be used instead of the standard Perl error > mechanism. (Severity: 4) > # Subroutine "machine_epsilon" is neither declared nor explicitly > imported at line 232, column 19. This might be a major bug. > (Severity: 4) > # Subroutine "cdf" not exported by "Math::Gauss::XS" at line 237, > column 19. Violates encapsulation. (Severity: 4) > t/perlcritic.t ............... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests

While this test failure is indeed an issue that should be corrected, please don't allow pod, critic or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which cannot be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Sun Aug 21 19:15:48 2016 The RT System itself - Status changed from 'new' to 'open'