Bug #117056 for Var-Pairs: libvar-pairs-perl: depends on Data::Alias which is broken with Perl 5.24

Fri Aug 19 02:55:09 2016 CARNIL [...] cpan.org - Ticket created

From:	CARNIL [...] cpan.org
Subject:	libvar-pairs-perl: depends on Data::Alias which is broken with Perl 5.24

Hi Damian We have the following bug reported to the Debian package of Var-Pairs (https://bugs.debian.org/834798): To summarize it is, that Var::Pairs depends on Data::Alias. But Data::Alias itself is broken with Perl 5.24. The bugreport in Data:Alias is as https://rt.cpan.org/Public/Bug/Display.html?id=112289 ------8<-----------8<-----------8<-----------8<-----------8<----- Package: libvar-pairs-perl Version: 0.002004-2 Severity: important User: debian-perl@lists.debian.org Usertags: perl-5.24-transition This package depends and/or build-depends on libdata-alias-perl, which breaks with Perl 5.24 (currently in experimental.) See #825011. It looks like we will have to drop libdata-alias-perl from stretch to get Perl 5.24 in, so please look at dropping the dependency one way or another. In some cases the 'refaliasing' feature in Perl >= 5.22 may be a replacement; quoting Data::Alias documentation: Perl 5.22 added some support for aliasing to the Perl core. It has a different syntax, and a different set of operations, from that supplied by this module; see "Assigning to References" in perlref. The core's aliasing facilities are implemented more robustly than this module and are better supported. If you can rely on having a sufficiently recent Perl version, you should prefer to use the core facility rather than use this module. If you are already using this module and are now using a sufficiently recent Perl, you should attempt to migrate to the core facility. -- Niko Tyni ntyni@debian.org ------8<-----------8<-----------8<-----------8<-----------8<----- Thanks for considering, Salvatore Bonaccorso, Debian Perl Group

Fri Aug 19 22:07:06 2016 damian [...] conway.org - Correspondence added

Subject:	Re: [rt.cpan.org #117056] libvar-pairs-perl: depends on Data::Alias which is broken with Perl 5.24
Date:	Sat, 20 Aug 2016 12:06:14 +1000
To:	bug-Var-Pairs [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

Thanks for the heads-up, Salvatore! I have refactored the module to avoid Data::Alias under 5.24 and later. Please give it a try and feel free to report any further issues. Much appreciated! Damian

Fri Aug 19 22:07:06 2016 The RT System itself - Status changed from 'new' to 'open'

Fri Aug 19 22:07:22 2016 DCONWAY [...] cpan.org - Correspondence added

Resolved in v0.3.0

Fri Aug 19 22:07:27 2016 DCONWAY [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Aug 20 02:04:54 2016 CARNIL [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #117056] libvar-pairs-perl: depends on Data::Alias which is broken with Perl 5.24
Date:	Sat, 20 Aug 2016 08:04:37 +0200
To:	"damian [...] conway.org via RT" <bug-Var-Pairs [...] rt.cpan.org>
From:	carnil [...] cpan.org

Hi Damian! On Fri, Aug 19, 2016 at 10:07:11PM -0400, damian@conway.org via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=117056 > > > Thanks for the heads-up, Salvatore! > > I have refactored the module to avoid Data::Alias under 5.24 and later. > Please give it a try and feel free to report any further issues. > > Much appreciated!

Thanks a lot for the really quick reply! Could it be that the some refactored files are missing from the released tarball? +use if $] < 5.024, 'Var::Pairs::Pair_DataAlias'; +use if $] >= 5.024, 'Var::Pairs::Pair_BuiltIn'; [...] # Failed test 'use Var::Pairs;' # at t/00.load.t line 4. # Tried to use 'Var::Pairs'. # Error: Can't locate Var/Pairs/Pair_DataAlias.pm in @INC (you may need to install the Var::Pairs::Pair_DataAlias module) (@INC contains: /build/libvar-pairs-perl-0.003000/blib/lib /build/libvar-pairs-perl-0.003000/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.22.2 /usr/local/share/perl/5.22.2 /usr/lib/x86_64-linux-gnu/perl5/5.22 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.22 /usr/share/perl/5.22 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base .) at /usr/share/perl/5.22/if.pm line 13. # BEGIN failed--compilation aborted at /build/libvar-pairs-perl-0.003000/blib/lib/Var/Pairs.pm line 280. # Compilation failed in require at t/00.load.t line 4. # BEGIN failed--compilation aborted at t/00.load.t line 4. # Testing Var::Pairs # Looks like you failed 1 test of 1. t/00.load.t ................... 1..1 not ok 1 - use Var::Pairs; Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests [...] The Data::Alias is still mentioned in the generated META.* and the Makefile.PL to build, so might some regeneration as well. It is as well mentioned in the POD, so this might be removed for consistency. Thanks a lot! Regards, Salvatore

Sat Aug 20 02:54:04 2016 damian [...] conway.org - Correspondence added

Subject:	Re: [rt.cpan.org #117056] libvar-pairs-perl: depends on Data::Alias which is broken with Perl 5.24
Date:	Sat, 20 Aug 2016 16:53:10 +1000
To:	bug-Var-Pairs [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

Show quoted text

> Thanks a lot for the really quick reply! Could it be that the some > refactored files are missing from the released tarball?

Indeed. I've uploaded an update with those two files. Show quoted text

> The Data::Alias is still mentioned in the generated META.* and the

Makefile.PL Show quoted text

> to build, so might some regeneration as well.

I've tweaked Makefile.PL to reflect that the dependency is only for 5.022 and earlier. Show quoted text

> It is as well mentioned in the POD, so this might be removed for > consistency.

I've noted the version dependency. Please try this new release and let me know if there are any further problem. Damian

Sat Aug 20 04:18:59 2016 CARNIL [...] cpan.org - Correspondence added

CC:	Niko Tyni <ntyni [...] debian.org>
Subject:	Re: [rt.cpan.org #117056] libvar-pairs-perl: depends on Data::Alias which is broken with Perl 5.24
Date:	Sat, 20 Aug 2016 10:18:43 +0200
To:	"damian [...] conway.org via RT" <bug-Var-Pairs [...] rt.cpan.org>
From:	Salvatore Bonaccorso <carnil [...] cpan.org>

Hi Damian, On Sat, Aug 20, 2016 at 02:54:09AM -0400, damian@conway.org via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=117056 > >

> > Thanks a lot for the really quick reply! Could it be that the some > > refactored files are missing from the released tarball?

> > Indeed. I've uploaded an update with those two files.

Thanks! Show quoted text

> > The Data::Alias is still mentioned in the generated META.* and the

> Makefile.PL

> > to build, so might some regeneration as well.

> > I've tweaked Makefile.PL to reflect that the dependency is only for 5.022 > and earlier. > >

> > It is as well mentioned in the POD, so this might be removed for > > consistency.

> > I've noted the version dependency. > > Please try this new release and let me know if there are any further > problem.

Should'nt 5.22 actually be enough, since the feature appear there? In Debian I have applied the following, but not yet released (just to first make sure with you that's correct): ----cut---------cut---------cut---------cut---------cut---------cut----- Description: Relax upstream Perl version requirement Origin: vendor Forwarded: no Author: Salvatore Bonaccorso <carnil@debian.org> Last-Update: 2016-08-20 --- a/Makefile.PL +++ b/Makefile.PL @@ -12,7 +12,7 @@ WriteMakefile( PREREQ_PM => { 'Test::More' => 0, 'Devel::Callsite' => 0.06, -($] < 5.024 ? ('Data::Alias' => 1.16) : ()), +($] < 5.022 ? ('Data::Alias' => 1.16) : ()), 'PadWalker' => 1.93, 'experimental' => 0, }, --- a/lib/Var/Pairs.pm +++ b/lib/Var/Pairs.pm @@ -277,8 +277,8 @@ sub _get_each_kv { return wantarray ? @each_kv : $each_kv[0]; } -use if $] < 5.024, 'Var::Pairs::Pair_DataAlias'; -use if $] >= 5.024, 'Var::Pairs::Pair_BuiltIn'; +use if $] < 5.022, 'Var::Pairs::Pair_DataAlias'; +use if $] >= 5.022, 'Var::Pairs::Pair_BuiltIn'; 1; # Magic true value required at end of module __END__ @@ -774,7 +774,7 @@ The module requires Perl 5.014 and the f =item Devel::Callsite -=item Data::Alias (under Perl 5.22 and earlier) +=item Data::Alias (under Perl earlier than 5.22) =item PadWalker --- a/lib/Var/Pairs/Pair_BuiltIn.pm +++ b/lib/Var/Pairs/Pair_BuiltIn.pm @@ -6,7 +6,7 @@ use warnings; use experimental 'refaliasing'; # Class implementing each key/value pair... -# (aliasing via 5.24 built-in aliasing) +# (aliasing via 5.22 built-in aliasing) package Var::Pairs::Pair { use Scalar::Util qw< looks_like_number >; ----cut---------cut---------cut---------cut---------cut---------cut----- The testsuite passes with v5.22.2 in Debian. Regards, Salvatore

Sat Aug 20 05:23:51 2016 damian [...] conway.org - Correspondence added

Subject:	Re: [rt.cpan.org #117056] libvar-pairs-perl: depends on Data::Alias which is broken with Perl 5.24
Date:	Sat, 20 Aug 2016 19:22:33 +1000
To:	bug-Var-Pairs [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

Show quoted text

> Should'nt 5.22 actually be enough, since the feature appear there?

Yes. I didn't make that the cut-off simply on the principle of not fixing what wasn't broken. :-) However, rather than having an inconsistent version floating around in a major distro, I've just uploaded a new version that sets the cut-off at 5.22. Damian

Sat Aug 20 07:18:00 2016 salvatore.bonaccorso [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #117056] libvar-pairs-perl: depends on Data::Alias which is broken with Perl 5.24
Date:	Sat, 20 Aug 2016 13:17:45 +0200
To:	"damian [...] conway.org via RT" <bug-Var-Pairs [...] rt.cpan.org>
From:	salvatore.bonaccorso [...] gmail.com

Hi Damian, On Sat, Aug 20, 2016 at 05:24:01AM -0400, damian@conway.org via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=117056 > >

> > Should'nt 5.22 actually be enough, since the feature appear there?

> > Yes. I didn't make that the cut-off simply on the principle of not fixing > what > wasn't broken. :-) > > However, rather than having an inconsistent version floating around in > a major distro, I've just uploaded a new version that sets the cut-off at > 5.22.

Great, thanks a lot (and it helps us in transitioning to Perl 5.24). Have a good remaining day, Salvatore