Skip Menu |

This queue is for tickets about the Module-CPANTS-Generator CPAN distribution.

Report information
The Basics
Id: 11704
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Generator

People
Owner: domm [...] cpan.org
Requestors: barbie [...] missbarbell.co.uk
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.25
Fixed in: (no value)



Subject: POD test file checks
While checking for the existence of Test::Pod and Test::Pod::Coverage is an excellent idea, enforcing the file names is not. In all my distributions the two files are 't/90podtest.t' and 't/91podcover.t'. As a consequence my distributions have all been marked down undeservedly. A better choice would be to search for test files marked qr/.*pod.*\.t/ and check if they have either of the two modules. There isn't currently any specification as to how to name test files, and I don't feel it's CPANTS place to do so. If I get time, I submit a patch to rectify this.
Date: Tue, 1 Mar 2005 21:03:23 +0100
From: Thomas Klausner <domm [...] zsi.at>
To: via RT <bug-Module-CPANTS-Generator [...] rt.cpan.org>
CC: barbie [...] missbarbell.co.uk
Subject: Re: [cpan #11704] POD test file checks
RT-Send-Cc:
Hi! On Tue, Mar 01, 2005 at 11:50:41AM -0500, via RT wrote: Show quoted text
> While checking for the existence of Test::Pod and Test::Pod::Coverage is > an excellent idea, enforcing the file names is not. In all my distributions > the two files are 't/90podtest.t' and 't/91podcover.t'. As a consequence my > distributions have all been marked down undeservedly. > > A better choice would be to search for test files marked qr/.*pod.*\.t/ > and check if they have either of the two modules.
Sebastien Aperghis-Tramoni also discovered this bug last week (but reported it via IRC/private mail). I resolved it by doing as you suggested: parsing the test-files for /use\s([\w:]+/ and checking if there is Test::Pod and Test::Pod::Coverage. I didn't release a new version of Module::CPANTS::Generator, though. But I will soon. BTW, the current results (as of 2005-02-28 23:11:58) allready use the new method, and you seem to get away better: http://cpants.dev.zsi.at/highscores.html Thanks for the feedback! -- #!/usr/bin/perl http://domm.zsi.at for(ref bless{},just'another'perl'hacker){s-:+-$"-g&&print$_.$/}