Bug #11663 for SVN-Notify: Add/copy output impossible to read

Fri Feb 25 12:31:19 2005 Guest - Ticket created

Subject:

Add/copy output impossible to read

(Using SVN::Notify 2.43 with the HTML::ColorDiff handler on perl 5.8.3 / Fedora Core 2.) When I add or copy a file with TortoiseSVN, there's no <pre> block around the diff output. So none of the spacing is displayed by the browser, including line endings. It's basically impossible to read. Also, on copies, it seems to display a diff between an empty file and the new one. It'd be more useful to me to display a diff between the prior revision of the source file and the current revision of the destination file. I can't tell what changed when we move a file and alter it in the same revision. Thanks for the handy program, by the way. We've been using it for a couple weeks, since we switched to Subversion from CVS. We were spoiled by CVSspam's shiny HTML output, and (aside from this minor problem), SVN::Notify has been a great replacement.

Fri Feb 25 12:50:58 2005 david [...] kineticode.com - Correspondence added

From:	David Wheeler <david [...] kineticode.com>
Subject:	Re: [cpan #11663] Add/copy output impossible to read
Date:	Fri, 25 Feb 2005 09:41:15 -0800
To:	bug-SVN-Notify [...] rt.cpan.org
RT-Send-Cc:

On Feb 25, 2005, at 9:31 AM, Guest via RT wrote: Show quoted text

> When I add or copy a file with TortoiseSVN, there's no <pre> block > around the diff output. So none of the spacing is displayed by the > browser, including line endings. It's basically impossible to read.

That's very odd. I'm not familiar with TortoiseSVN, but I assume that it's a Subversion client, yes? I have no idea why there would be no pre tags, as SVN::Notify::HTML has this line to output the log message: print $out "<h3>Log Message</h3>\n<pre>$msg</pre>\n\n"; The only thing I can think of is perhaps, for some reason, the SVN::Notify::output_log_message is called, instead. It has: print $out "Log Message:\n-----------\n$msg\n"; Are you getting output like that? Even if you are, I'm at a loss to explain why that method would execute instead of the one in SVN::Notify::HTML. Show quoted text

> Also, on copies, it seems to display a diff between an empty file and > the new one. It'd be more useful to me to display a diff between the > prior revision of the source file and the current revision of the > destination file. I can't tell what changed when we move a file and > alter it in the same revision.

SVN::Notify simply relies on the output from svnlook for diffs. If you could get the Subversion project to change it's behavior (maybe take some options), then you'd be in business! Show quoted text

> Thanks for the handy program, by the way. We've been using it for a > couple weeks, since we switched to Subversion from CVS. We were > spoiled by CVSspam's shiny HTML output, and (aside from this minor > problem), SVN::Notify has been a great replacement.

Glad you like it. Thanks! David

Fri Feb 25 13:10:41 2005 Guest - Correspondence added

[david@kineticode.com - Fri Feb 25 12:50:58 2005]: Show quoted text

> On Feb 25, 2005, at 9:31 AM, Guest via RT wrote: > That's very odd. I'm not familiar with TortoiseSVN, but I assume that > it's a Subversion client, yes?

Yup. It's a Windows one implemented as an Explorer extension. Should be no different from SVN::Notify's perspective, but mentioned it to be thorough. Show quoted text

> I have no idea why there would be no pre > tags, as SVN::Notify::HTML has this line to output the log message:

I just looked at it a bit more. I was wrong when I said "Added/Copied"; it's only "Copied" files. (So I think moved ones, too, as they're implemented as a copy + delete.) It's not matching the regexp that says /^(Modified|Added|Deleted): (.*)$/, so none of that code is being executed. I tried adding a second one as /^(Copied): (.*) $from rev \d+, .*$$/ and corresponding CSS entry / type mapping, which seemed to improve matters. But now it weirds out if there's a copy with no changes. svnlook apparently skips the diff output entirely, even the "=====" line. It's not quite as obvious to me how to fix that. Show quoted text

> SVN::Notify simply relies on the output from svnlook for diffs. If you > could get the Subversion project to change it's behavior (maybe take > some options), then you'd be in business!

Oh, I see that now. Maybe I'll file an feature request.

Fri Feb 25 13:29:57 2005 david [...] justatheory.com - Correspondence added

From:	David Wheeler <david [...] justatheory.com>
Subject:	Re: [cpan #11663] Add/copy output impossible to read
Date:	Fri, 25 Feb 2005 10:20:22 -0800
To:	bug-SVN-Notify [...] rt.cpan.org
RT-Send-Cc:

On Feb 25, 2005, at 10:10 AM, Guest via RT wrote: Show quoted text

> I just looked at it a bit more. I was wrong when I said > "Added/Copied"; it's only "Copied" files. > (So I think moved ones, too, as they're implemented as a copy + > delete.) > > It's not matching the regexp that says /^(Modified|Added|Deleted): > (.*)$/, so none of that > code is being executed. > > I tried adding a second one as /^(Copied): (.*) $from rev \d+, .*$$/ > and corresponding CSS > entry / type mapping, which seemed to improve matters. > > But now it weirds out if there's a copy with no changes. svnlook > apparently skips the diff > output entirely, even the "=====" line. It's not quite as obvious to > me how to fix that.

Nice. If you figure it out, send me a patch. Eventually, I'd like to switch to using the Perl SVN swig libraries instead of svnlook. But that'll take some effort and I have *no* time these days. :-( Show quoted text

> Oh, I see that now. Maybe I'll file an feature request.

Cool, thanks! David

Fri Feb 25 14:24:42 2005 Guest - Correspondence added

[david@justatheory.com - Fri Feb 25 13:29:57 2005]: Show quoted text

> Nice. If you figure it out, send me a patch.

Will do. I've got to "do my job" now, but I might get a chance to look again later. Show quoted text

> Eventually, I'd like to switch to using the Perl SVN swig libraries > instead of svnlook. But that'll take some effort and I have *no* time > these days. :-(

That'd be cool. But this way works, anyway. Show quoted text

> > Oh, I see that now. Maybe I'll file an feature request.

> > Cool, thanks!

http://subversion.tigris.org/issues/show_bug.cgi?id=2233

Fri Aug 26 14:17:17 2005 dwheeler [...] cpan.org - Fixed in 2.46 added

Fri Aug 26 14:17:17 2005 dwheeler [...] cpan.org - Status changed from 'new' to 'resolved'

Bug #11663 for SVN-Notify: Add/copy output impossible to read

Preferred bug tracker