Skip Menu |

This queue is for tickets about the GraphViz2 CPAN distribution.

Report information
The Basics
Id: 116628
Status: resolved
Priority: 0/
Queue: GraphViz2

People
Owner: Nobody in particular
Requestors: daran.davis [...] intel.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: "Davis, Daran" <daran.davis [...] intel.com>
Subject: make test has 4 tests that fail
Date: Mon, 1 Aug 2016 14:46:49 +0000
To: "bug-GraphViz2 [...] rt.cpan.org" <bug-GraphViz2 [...] rt.cpan.org>
From: "Davis, Daran" <daran.davis [...] intel.com>
Hi, This is related to RT ticket: 81467 Here are my particulars: * GraphViz2-2.39 * Perl v5.14.1 * Linux Suse11 * dot - Graphviz version 2.20.3 I used perl -MCPAN -e shell to install GraphViz2 and its dependencies. The following line performs the make test and shows the failures: Running make test PERL_DL_NONLAZY=1 "/nfs/site/itools/em64t_SLES11/pkgs/perl/5.14.1/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/test.t .. 24/? # Failed test 'scripts/rank.sub.graph.1.pl runs without error' # at t/test.t line 38. # Failed test 'scripts/rank.sub.graph.2.pl runs without error' # at t/test.t line 38. t/test.t .. 31/? # Failed test 'scripts/rank.sub.graph.3.pl runs without error' # at t/test.t line 38. # Failed test 'scripts/rank.sub.graph.4.pl runs without error' # at t/test.t line 38. t/test.t .. 37/? # Looks like you failed 4 tests of 43. t/test.t .. Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/43 subtests Test Summary Report ------------------- t/test.t (Wstat: 1024 Tests: 43 Failed: 4) Failed tests: 29-32 Non-zero exit status: 4 Files=1, Tests=43, 7 wallclock secs ( 0.03 usr 0.01 sys + 3.82 cusr 1.77 csys = 5.63 CPU) Result: FAIL Failed 1/1 test programs. 4/43 subtests failed. make: *** [test_dynamic] Error 4 RSAVAGE/GraphViz2-2.39.tgz /usr/bin/make test -- NOT OK //hint// to see the cpan-testers results for installing this module, try: reports RSAVAGE/GraphViz2-2.39.tgz The following ok function in t/test.t will report a failure because $stderr has a non-zero value: ok(length($stderr) == 0, "$script{$key} runs without error"); The $stderr value is "Warning: using box for unknown shape square" The tests (scripts) that failed are called from t/test.t and the following scripts which are run by t/test.t report the warning when run: scripts/rank.sub.graph.1.pl scripts/rank.sub.graph.2.pl scripts/rank.sub.graph.3.pl scripts/rank.sub.graph.4.pl For example, scripts/rank.sub.graph.1.pl has the following line: line42:$graph -> add_node(name => 'Murrumbeena', shape => 'square', color => 'orange'); According to the following doc a shape of square is not supported which is the reason for the warning. http://www.graphviz.org/doc/info/shapes.html I believe the fix is to chage shape => 'square' to shape => 'box' in the 4 scripts listed above. Thanks for your time Daran

Message body is not shown because it is too large.

Hi Daran I released V 2.40 with your suggested fix, and then found 6 other scripts/*.pl files used 'box', so I released V 2.41 to fix them too, using 'doublecircle' instead of 'box'. V 2.41 is on CPAN. Thanx for the report, and thanx for linking it to the report from D. Thomas. See Changes for details.
CC: "Davis, Daran" <daran.davis [...] intel.com>
Subject: RE: [rt.cpan.org #116628] make test has 4 tests that fail
Date: Tue, 2 Aug 2016 00:56:01 +0000
To: "bug-GraphViz2 [...] rt.cpan.org" <bug-GraphViz2 [...] rt.cpan.org>
From: "Davis, Daran" <daran.davis [...] intel.com>
Hi, Thanks for your quick reply! Unfortunately, the lines I was suggesting to get fixed are still there in rank.sub.graph.{1-4}.pl : grep -i 'square' .../.cpan/build/GraphViz2-2.41-CX_uj5/scripts/* .../.cpan/build/GraphViz2-2.41-CX_uj5/scripts/rank.sub.graph.1.pl:$graph -> add_node(name => 'Murrumbeena', shape => 'square', color => 'orange'); .../.cpan/build/GraphViz2-2.41-CX_uj5/scripts/rank.sub.graph.2.pl:$graph -> add_node(name => 'Murrumbeena', shape => 'square', color => 'orange'); .../.cpan/build/GraphViz2-2.41-CX_uj5/scripts/rank.sub.graph.3.pl:$graph -> add_node(name => 'Murrumbeena', shape => 'square', color => 'orange'); .../.cpan/build/GraphViz2-2.41-CX_uj5/scripts/rank.sub.graph.4.pl:$graph -> add_node(name => 'Murrumbeena', shape => 'square', color => 'orange'); The shape type of square is not supported by dot. Can you please change: shape => 'square' to shape => 'box' Thanks Daran Show quoted text
-----Original Message----- From: RSAVAGE via RT [mailto:bug-GraphViz2@rt.cpan.org] Sent: Monday, August 01, 2016 4:16 PM To: Davis, Daran <daran.davis@intel.com> Subject: [rt.cpan.org #116628] make test has 4 tests that fail <URL: https://rt.cpan.org/Ticket/Display.html?id=116628 > Hi Daran I released V 2.40 with your suggested fix, and then found 6 other scripts/*.pl files used 'box', so I released V 2.41 to fix them too, using 'doublecircle' instead of 'box'. V 2.41 is on CPAN. Thanx for the report, and thanx for linking it to the report from D. Thomas. See Changes for details.
Hi Daran V 2.42 is on CPAN. I've replaced all uses of shape 'square'. See Changes for details.
See previous msg.
Subject: RE: [rt.cpan.org #116628] make test has 4 tests that fail
Date: Tue, 2 Aug 2016 04:32:05 +0000
To: "bug-GraphViz2 [...] rt.cpan.org" <bug-GraphViz2 [...] rt.cpan.org>
From: "Davis, Daran" <daran.davis [...] intel.com>
Thanks a lot for your help! GraphViz2 v2.42 now installs correctly with all tests passing. Daran Show quoted text
-----Original Message----- From: RSAVAGE via RT [mailto:bug-GraphViz2@rt.cpan.org] Sent: Monday, August 01, 2016 7:41 PM To: Davis, Daran <daran.davis@intel.com> Subject: [rt.cpan.org #116628] make test has 4 tests that fail <URL: https://rt.cpan.org/Ticket/Display.html?id=116628 > Hi Daran V 2.42 is on CPAN. I've replaced all uses of shape 'square'. See Changes for details.
Subject: Re: [rt.cpan.org #116628] make test has 4 tests that fail
Date: Tue, 2 Aug 2016 14:39:37 +1000
To: bug-GraphViz2 [...] rt.cpan.org
From: Ron Savage <ron [...] savage.net.au>
Hi Daran On 02/08/16 14:32, Davis, Daran via RT wrote: Show quoted text
> Queue: GraphViz2 > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=116628 > > > Thanks a lot for your help! GraphViz2 v2.42 now installs correctly with all tests passing.
Phew! And just for the record, what version of dot are you running? Show quoted text
> Daran > > -----Original Message----- > From: RSAVAGE via RT [mailto:bug-GraphViz2@rt.cpan.org] > Sent: Monday, August 01, 2016 7:41 PM > To: Davis, Daran <daran.davis@intel.com> > Subject: [rt.cpan.org #116628] make test has 4 tests that fail > > <URL: https://rt.cpan.org/Ticket/Display.html?id=116628 > > > Hi Daran > > V 2.42 is on CPAN. I've replaced all uses of shape 'square'. See Changes for details. >
-- Ron Savage - savage.net.au
Subject: RE: [rt.cpan.org #116628] make test has 4 tests that fail
Date: Tue, 2 Aug 2016 05:11:44 +0000
To: "bug-GraphViz2 [...] rt.cpan.org" <bug-GraphViz2 [...] rt.cpan.org>
From: "Davis, Daran" <daran.davis [...] intel.com>
dot - Graphviz version 2.20.3 Show quoted text
-----Original Message----- From: ron@savage.net.au via RT [mailto:bug-GraphViz2@rt.cpan.org] Sent: Monday, August 01, 2016 9:40 PM To: Davis, Daran <daran.davis@intel.com> Subject: Re: [rt.cpan.org #116628] make test has 4 tests that fail <URL: https://rt.cpan.org/Ticket/Display.html?id=116628 > Hi Daran On 02/08/16 14:32, Davis, Daran via RT wrote:
> Queue: GraphViz2 > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=116628 > > > Thanks a lot for your help! GraphViz2 v2.42 now installs correctly with all tests passing.
Phew! And just for the record, what version of dot are you running?
> Daran > > -----Original Message----- > From: RSAVAGE via RT [mailto:bug-GraphViz2@rt.cpan.org] > Sent: Monday, August 01, 2016 7:41 PM > To: Davis, Daran <daran.davis@intel.com> > Subject: [rt.cpan.org #116628] make test has 4 tests that fail > > <URL: https://rt.cpan.org/Ticket/Display.html?id=116628 > > > Hi Daran > > V 2.42 is on CPAN. I've replaced all uses of shape 'square'. See Changes for details. >
-- Ron Savage - savage.net.au
Subject: Re: [rt.cpan.org #116628] make test has 4 tests that fail
Date: Tue, 2 Aug 2016 15:16:42 +1000
To: bug-GraphViz2 [...] rt.cpan.org
From: Ron Savage <ron [...] savage.net.au>
Hi Daran On 02/08/16 15:12, Davis, Daran via RT wrote: Show quoted text
> Queue: GraphViz2 > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=116628 > > > dot - Graphviz version 2.20.3
$many x $thanx; -- Ron Savage - savage.net.au