| Date: | Wed, 12 Jan 2005 15:32:03 -0800 (PST) |
| From: | Ryan Tate <ryantate [...] ryantate.com> |
| To: | schwern [...] pobox.com |
| Subject: | apparent test bug in Class::Virtual 0.05 |
Hello Michael,
I today tried to install Class::Virtual 0.05 via CPAN.pm and two of the
tests failed. Upon further investigation I believe this is due to a minor
bug in the regex you used to check the error string after a failed eval in
the section when you're testing whether the virtual class is "leaking."
Below is a transcript. You can probably see right away what is happening
-- your test expects the error string to start with:
/Can't locate object method "bing" via package "Foo::This" at/
when in fact the error message thrown goes like:
/Can't locate object method "bing" via package "Foo::This" (perhaps you
forgot to load "Foo::This"?) at t/Abstract.t line 72/
The parenthetical comment in the perl error is throwing off your test.
FWIW I am on perl5.6.1 for Solaris. Here is my test transcript.
----------
Running make test
PERL_DL_NONLAZY=1 /opt/local/bin/perl5.6.1 -Iblib/arch -Iblib/lib
-I/opt/local/packages/perl-5.6.1/lib/5.6.1/sun4-solaris-64int
-I/opt/local/packages/perl-5.6.1/lib/5.6.1 -e 'use Test::Harness
qw(&runtests $verbose); $verbose=0; runtests @ARGV;' t/*.t
t/Abstract....ok 2/18
# Failed test (t/Abstract.t at line 74)
# 'Can't locate object method "bing" via package
"Foo::This" (perhaps you forgot to load "Foo::This"?) at t/Abstract.t line
72.
# '
# doesn't match '(?-xism:^Can't locate object method "bing" via
package "Foo::This" at)'
# Looks like you failed 1 test of 18.
t/Abstract....dubious
Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 14
Failed 1/18 tests, 94.44% okay
t/Virtual.....NOK 14
# Failed test (t/Virtual.t at line 74)
# 'Can't locate object method "bing" via package
"Test::This" (perhaps you forgot to load "Test::This"?) at t/Virtual.t
line 72.
# '
# doesn't match '(?-xism:^Can't locate object method "bing" via
package "Test::This" at)'
t/Virtual.....ok 15/15# Looks like you failed 1 test of 15.
t/Virtual.....dubious
Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 14
Failed 1/15 tests, 93.33% okay
t/assert......ok
Failed Test Stat Wstat Total Fail Failed List of Failed
----------------------------------------------------------------------------------------------
t/Abstract.t 1 256 18 1 5.56% 14
t/Virtual.t 1 256 15 1 6.67% 14
Failed 2/3 test scripts, 33.33% okay. 2/34 subtests failed, 94.12% okay.
*** Error code 11
make: Fatal error: Command failed for target `test_dynamic'
/usr/ccs/bin/make test -- NOT OK
----------
Cheers
Ryan