Skip Menu |

This queue is for tickets about the Time-Ago CPAN distribution.

Report information
The Basics
Id: 116291
Status: resolved
Priority: 0/
Queue: Time-Ago

People
Owner: maurice [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.07
Fixed in: (no value)



Subject: Compat with perl 5.8.x?
The tests fail because the "defined-or" operator is used, which is not available in perl 5.8.x: Warning: Use of "shift" without parentheses is ambiguous at t/00_time_ago.t line 20. Number found where operator expected at t/00_time_ago.t line 20, near "// 0" (Missing operator before 0?) syntax error at t/00_time_ago.t line 20, near "// 0" Execution of t/00_time_ago.t aborted due to compilation errors. t/00_time_ago.t ......... Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run Maybe this can be rewritten using an old-fashioned "defined" check?
On Mon Jul 18 14:34:29 2016, SREZIC wrote: Show quoted text
> The tests fail because the "defined-or" operator is used, which is not > available in perl 5.8.x: > > Warning: Use of "shift" without parentheses is ambiguous at > t/00_time_ago.t line 20. > Number found where operator expected at t/00_time_ago.t line 20, near > "// 0" > (Missing operator before 0?) > syntax error at t/00_time_ago.t line 20, near "// 0" > Execution of t/00_time_ago.t aborted due to compilation errors. > t/00_time_ago.t ......... > Dubious, test returned 255 (wstat 65280, 0xff00) > No subtests run > > > Maybe this can be rewritten using an old-fashioned "defined" check?
Absolutely! Thanks for catching that. Change has been committed to github on the feature/0.08 branch: https://github.com/mla/time-ago/tree/feature/0.08 Will roll a new release once I have time to investigate the translations not working on some environments.