Bug #115982 for Dist-Zilla-Plugin-Test-Compile: Emit the compilation stderr output as diag() if "is ($?, 0)" failed.

Fri Jul 08 11:50:43 2016 SHLOMIF [...] cpan.org - Ticket created

Subject:

Emit the compilation stderr output as diag() if "is ($?, 0)" failed.

Hi! Currently if «is($?, 0, "$lib loaded ok");» fails no extra output is given so it's hard to know what went wrong. See http://www.cpantesters.org/cpan/report/b64f5120-42db-11e6-a0aa-924a63f69d7e for instance. Please emit @_warnings as diag in that case. Regards, -- Shlomi Fish

Fri Jul 08 13:41:33 2016 ether [...] cpan.org - Taken

Fri Jul 08 13:47:31 2016 ether [...] cpan.org - Correspondence added

On 2016-07-08 08:50:43, SHLOMIF wrote: Show quoted text

> Hi! > > Currently if «is($?, 0, "$lib loaded ok");» fails no extra output is > given so it's hard to know what went wrong. See > http://www.cpantesters.org/cpan/report/b64f5120-42db-11e6-a0aa- > 924a63f69d7e for instance. Please emit @_warnings as diag in that > case.

@_warnings are *always* emitted if there are any -- see https://metacpan.org/source/ETHER/Dist-Zilla-Plugin-Test-Compile-2.054/lib/Dist/Zilla/Plugin/Test/Compile.pm#L659-663 so I'm not sure if there's anything else I can do?

Fri Jul 08 13:47:31 2016 The RT System itself - Status changed from 'new' to 'open'

Fri Jul 08 13:47:32 2016 ether [...] cpan.org - Status changed from 'open' to 'stalled'

Fri Jul 08 14:43:24 2016 arfreitas [...] cpan.org - Correspondence added

Hi Karen, On Fri Jul 08 13:47:31 2016, ETHER wrote: Show quoted text

> On 2016-07-08 08:50:43, SHLOMIF wrote:

> > Hi! > > > > Currently if «is($?, 0, "$lib loaded ok");» fails no extra output is > > given so it's hard to know what went wrong. See > > http://www.cpantesters.org/cpan/report/b64f5120-42db-11e6-a0aa- > > 924a63f69d7e for instance. Please emit @_warnings as diag in that > > case.

> > @_warnings are *always* emitted if there are any -- see > https://metacpan.org/source/ETHER/Dist-Zilla-Plugin-Test-Compile- > 2.054/lib/Dist/Zilla/Plugin/Test/Compile.pm#L659-663 > so I'm not sure if there's anything else I can do?

Maybe if you include "or diag(explain(@_warnings))" we could have a better idea what kind of warnings were generated during the test. I tried to reproduce the failing test from one distribution of Shlomif but it just worked as expected. The additional information should help with troubleshooting.

Fri Jul 08 14:43:25 2016 The RT System itself - Status changed from 'stalled' to 'open'

Fri Jul 08 19:57:41 2016 ether [...] cpan.org - Correspondence added

On 2016-07-08 11:43:24, ARFREITAS wrote: Show quoted text

> Hi Karen, > > On Fri Jul 08 13:47:31 2016, ETHER wrote:

> > On 2016-07-08 08:50:43, SHLOMIF wrote:

> > > Hi! > > > > > > Currently if «is($?, 0, "$lib loaded ok");» fails no extra output > > > is > > > given so it's hard to know what went wrong. See > > > http://www.cpantesters.org/cpan/report/b64f5120-42db-11e6-a0aa- > > > 924a63f69d7e for instance. Please emit @_warnings as diag in that > > > case.

> > > > @_warnings are *always* emitted if there are any -- see > > https://metacpan.org/source/ETHER/Dist-Zilla-Plugin-Test-Compile-2.054/lib/Dist/Zilla/Plugin/Test/Compile.pm#L659-663 > > so I'm not sure if there's anything else I can do?

> > Maybe if you include "or diag(explain(@_warnings))" we could have a > better idea what kind of warnings were generated during the test. I > tried to reproduce the failing test from one distribution of Shlomif > but it just worked as expected. The additional information should help > with troubleshooting.

As I said, *the warnings already are printed*. You can see this for yourself by deliberately introducing a 'die' into a module file being tested, and observe the error.

Sun Oct 23 21:39:04 2016 ether [...] cpan.org - Correspondence added

I need more information about the failure vector before I can continue, as I believe all diagnostic information is already printed.

Sun Oct 23 21:39:04 2016 ether [...] cpan.org - Status changed from 'open' to 'stalled'