Bug #115953 for Text-CSV_XS: Space stripped from middle of field value with allow_whitespace and allow_loose

Thu Jul 07 15:44:26 2016 tsibley [...] cpan.org - Ticket created

Subject:

Space stripped from middle of field value with allow_whitespace and allow_loose_quotes

Consider the following two examples where Text::CSV_PP does what I expected from the docs but Text::CSV_XS strips an internal space in the field value: $ PERL_TEXT_CSV=Text::CSV_PP perl -MText::CSV -E 'say $_->[0] for Text::CSV->new({ allow_loose_quotes => 1, allow_whitespace => 1, escape_char => "\\" })->getline(\*STDIN)' <<<'"foo "bar" baz"' foo "bar" baz $ PERL_TEXT_CSV=Text::CSV_XS perl -MText::CSV -E 'say $_->[0] for Text::CSV->new({ allow_loose_quotes => 1, allow_whitespace => 1, escape_char => "\\" })->getline(\*STDIN)' <<<'"foo "bar" baz"' foo "bar"baz

Thu Jul 07 16:01:02 2016 HMBRAND [...] cpan.org - Correspondence added

This looks like a genuine bug in allow_whitespace $ perl -MCSV -wE'say csv(in=>\q("foo "bar" baz"),allow_loose_quotes=>1,escape=>"\\")->[0][0]' foo "bar" baz $ perl -MCSV -wE'say csv(in=>\q("foo "bar" baz"),allow_loose_quotes=>1,escape=>"\\",allow_whitespace=>1)->[0][0]' foo "bar"baz I'll have a look

Thu Jul 07 16:01:02 2016 The RT System itself - Status changed from 'new' to 'open'

Thu Jul 07 16:01:13 2016 HMBRAND [...] cpan.org - Correspondence added

This looks like a genuine bug in allow_whitespace $ perl -MCSV -wE'say csv(in=>\q("foo "bar" baz"),allow_loose_quotes=>1,escape=>"\\")->[0][0]' foo "bar" baz $ perl -MCSV -wE'say csv(in=>\q("foo "bar" baz"),allow_loose_quotes=>1,escape=>"\\",allow_whitespace=>1)->[0][0]' foo "bar"baz I'll have a look

Thu Jul 07 16:18:04 2016 HMBRAND [...] cpan.org - Correspondence added

Interesting fact is that I did NOT break that in perl6 $ perl6 -I. -Ilib -MText::CSV -e'dd csv(in=>"test2.csv",:allow_loose_quotes,escape=>"\\",:allow_whitespace)' Array @in = [["foo \"bar\" baz"],] $ perl6 -I. -Ilib -MText::CSV -e'dd csv(in=>"test2.csv",:allow_loose_quotes,escape=>"\\")' Array @in = [["foo \"bar\" baz"],]

Sat Jul 09 05:45:37 2016 HMBRAND [...] cpan.org - Broken in 1.12 added

Sat Jul 09 05:45:37 2016 HMBRAND [...] cpan.org - Broken in 1.23 deleted

Sat Jul 09 05:45:38 2016 HMBRAND [...] cpan.org - Correspondence added

That was brain-breaker. I found a fix, which has now been pushed. Release process has started. Thanks for finding this one.

Sat Jul 09 05:45:38 2016 HMBRAND [...] cpan.org - Status changed from 'open' to 'patched'

Mon Jul 11 02:42:11 2016 HMBRAND [...] cpan.org - Fixed in 1.24 added

Mon Jul 11 02:42:11 2016 HMBRAND [...] cpan.org - Status changed from 'patched' to 'resolved'

Wed Jul 13 14:41:29 2016 tsibley [...] cpan.org - Correspondence added

Thanks for the fix!

Bug #115953 for Text-CSV_XS: Space stripped from middle of field value with allow_whitespace and allow_loose_quotes