Skip Menu |

This queue is for tickets about the asterisk-perl CPAN distribution.

Report information
The Basics
Id: 115789
Status: resolved
Priority: 0/
Queue: asterisk-perl

People
Owner: Nobody in particular
Requestors: hemmerly [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.05



Subject: Found & Squished bug.
Date: Fri, 1 Jul 2016 11:35:16 -0500
To: bug-asterisk-perl [...] rt.cpan.org
From: Chris Hemmerly <hemmerly [...] gmail.com>
Hello. I'm using Asterisk::Manager from the asterisk-perl-1.04 package. It's throwing an error: ResponseSuccessMessageOriginate successfully queuedUse of uninitialized value in string eq at /usr/lib/perl5/site_perl/5.8.8/Asterisk/Manager.pm line 376, <GEN0> line 23. Here's my example script: #!/usr/bin/perl use Asterisk::Manager; $|++; # Autoflush my $astman = new Asterisk::Manager; $astman->user('[redacted]'); $astman->secret('[redacted]'); $astman->host('[redacted]'); $astman->connect || die $astman->error . "\n"; $astman->sendcommand( Action=>"Originate", Channel=>"SCCP/1005", Exten=>"6101", Context=>"default", Priority=>1 ); #$astman->eventloop; $astman->disconnect; To solve this, I changed line 376 from: if ($resp{Response} eq 'Goodbye') { to if (defined ($resp{Response}) && $resp{Response} eq 'Goodbye') { -Chris
Subject: Re: [rt.cpan.org #115789] Found & Squished bug.
Date: Fri, 1 Jul 2016 20:38:29 -0400
To: bug-asterisk-perl [...] rt.cpan.org
From: Charlie Gonzalez <itcharlie [...] gmail.com>
Hello Chris, Thanks for reporting this bug and posting a fix. I can take your change and merge it on the master git repo: https://github.com/asterisk-perl/asterisk-perl or you can fork it and create a pull request so that the change log gives you credit for your fix. Please let me know if you want and/or need help with creating a pull request. Additionally please report any issues via asterisk-perl Github issues list: https://github.com/asterisk-perl/asterisk-perl since it will be more easier for me to login and update the bug list (I am still trying to figure out why my RT login doesn't work ) If I don't hear from you in the next 2-3 days then I just move forward with applying the fix myself. Best, Charlie Charlie Gonzalez (E) itcharlie@gmail.com Github Profile <https://github.com/itcharlie> On Fri, Jul 1, 2016 at 12:36 PM, Chris Hemmerly via RT < bug-asterisk-perl@rt.cpan.org> wrote: Show quoted text
> Fri Jul 01 12:36:05 2016: Request 115789 was acted upon. > Transaction: Ticket created by hemmerly@gmail.com > Queue: asterisk-perl > Subject: Found & Squished bug. > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: hemmerly@gmail.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=115789 > > > > Hello. > I'm using Asterisk::Manager from the asterisk-perl-1.04 package. It's > throwing an error: > > ResponseSuccessMessageOriginate successfully queuedUse of uninitialized > value in string eq at /usr/lib/perl5/site_perl/5.8.8/Asterisk/Manager.pm > line 376, <GEN0> line 23. > > Here's my example script: > > #!/usr/bin/perl > > use Asterisk::Manager; > > $|++; # Autoflush > > my $astman = new Asterisk::Manager; > > $astman->user('[redacted]'); > $astman->secret('[redacted]'); > $astman->host('[redacted]'); > > $astman->connect || die $astman->error . "\n"; > > $astman->sendcommand( > Action=>"Originate", > Channel=>"SCCP/1005", > Exten=>"6101", > Context=>"default", > Priority=>1 > ); > > #$astman->eventloop; > > $astman->disconnect; > > > To solve this, I changed line 376 from: > if ($resp{Response} eq 'Goodbye') { > to > if (defined ($resp{Response}) && $resp{Response} eq 'Goodbye') { > > > -Chris > >
Subject: Re: [rt.cpan.org #115789] Found & Squished bug.
Date: Fri, 1 Jul 2016 19:44:08 -0500
To: bug-asterisk-perl [...] rt.cpan.org
From: Chris Hemmerly <hemmerly [...] gmail.com>
Charlie, I don't need credit for the fix so feel free to push on your end. Thanks for the great module! -Chris Show quoted text
> On Jul 1, 2016, at 7:38 PM, Charlie Gonzalez via RT <bug-asterisk-perl@rt.cpan.org> wrote: > > <URL: https://rt.cpan.org/Ticket/Display.html?id=115789 > > > Hello Chris, > > Thanks for reporting this bug and posting a fix. I can take your change and > merge it on the master git repo: > https://github.com/asterisk-perl/asterisk-perl or you can fork it and > create a pull request so that the change log gives you credit for your fix. > > Please let me know if you want and/or need help with creating a pull > request. Additionally please report any issues via asterisk-perl Github > issues list: https://github.com/asterisk-perl/asterisk-perl since it will > be more easier for me to login and update the bug list (I am still trying > to figure out why my RT login doesn't work ) > > If I don't hear from you in the next 2-3 days then I just move forward with > applying the fix myself. > > Best, > > Charlie > > > Charlie Gonzalez > (E) itcharlie@gmail.com > Github Profile <https://github.com/itcharlie> > > > On Fri, Jul 1, 2016 at 12:36 PM, Chris Hemmerly via RT < > bug-asterisk-perl@rt.cpan.org> wrote: >
>> Fri Jul 01 12:36:05 2016: Request 115789 was acted upon. >> Transaction: Ticket created by hemmerly@gmail.com >> Queue: asterisk-perl >> Subject: Found & Squished bug. >> Broken in: (no value) >> Severity: (no value) >> Owner: Nobody >> Requestors: hemmerly@gmail.com >> Status: new >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=115789 > >> >> >> Hello. >> I'm using Asterisk::Manager from the asterisk-perl-1.04 package. It's >> throwing an error: >> >> ResponseSuccessMessageOriginate successfully queuedUse of uninitialized >> value in string eq at /usr/lib/perl5/site_perl/5.8.8/Asterisk/Manager.pm >> line 376, <GEN0> line 23. >> >> Here's my example script: >> >> #!/usr/bin/perl >> >> use Asterisk::Manager; >> >> $|++; # Autoflush >> >> my $astman = new Asterisk::Manager; >> >> $astman->user('[redacted]'); >> $astman->secret('[redacted]'); >> $astman->host('[redacted]'); >> >> $astman->connect || die $astman->error . "\n"; >> >> $astman->sendcommand( >> Action=>"Originate", >> Channel=>"SCCP/1005", >> Exten=>"6101", >> Context=>"default", >> Priority=>1 >> ); >> >> #$astman->eventloop; >> >> $astman->disconnect; >> >> >> To solve this, I changed line 376 from: >> if ($resp{Response} eq 'Goodbye') { >> to >> if (defined ($resp{Response}) && $resp{Response} eq 'Goodbye') { >> >> >> -Chris
>
This patch was merged into version 1.05. Marking resolved.