Bug #115600 for CLI-Dispatch: [Proposal] Avoid to destroy some data of a CLI::Dispatch::Command's child class

Sat Jun 25 09:31:59 2016 YOHEIMUTA [...] cpan.org - Ticket created

CC:	yoheimuta [...] gmail.com
Subject:	[Proposal] Avoid to destroy some data of a CLI::Dispatch::Command's child class

We created a child class based CLI::Dispatch::Command according to README instructions. And this child class implemented a new subroutine and set instance variables in it. But the variables are invalid in run method because CLI::Dispatch::Command's set_options method runs `%{ $self } = @_;`. We want to keep the child instance variables. I write a proposal commit. See https://github.com/yoheimuta/CLI-Dispatch-tmp/commit/c0117d203e0e1b58722a620ce2138568485be436, sorry for uploading to github without your permission... We appreciate this useful module. Thanks.

Sat Jun 25 09:40:40 2016 ishigaki [...] cpan.org - Correspondence added

Your patch seems reasonable. Could you re-send me the patch as a pull request to https://github.com/charsbar/cli-dispatch, please? Thank you for the report. On Sat Jun 25 22:31:59 2016, YOHEIMUTA wrote: Show quoted text

> We created a child class based CLI::Dispatch::Command according to > README instructions. And this child class implemented a new subroutine > and set instance variables in it. But the variables are invalid in run > method because CLI::Dispatch::Command's set_options method runs `%{ > $self } = @_;`. > > We want to keep the child instance variables. > > I write a proposal commit. > See https://github.com/yoheimuta/CLI-Dispatch- > tmp/commit/c0117d203e0e1b58722a620ce2138568485be436, sorry for > uploading to github without your permission... > > We appreciate this useful module. > Thanks.

Sat Jun 25 09:40:40 2016 The RT System itself - Status changed from 'new' to 'open'

Sat Jun 25 09:50:05 2016 YOHEIMUTA [...] cpan.org - Correspondence added

On 2016-6月-25 土 09:40:40, ISHIGAKI wrote: Show quoted text

> Your patch seems reasonable. Could you re-send me the patch as a pull > request to https://github.com/charsbar/cli-dispatch, please? Thank you > for the report. > > On Sat Jun 25 22:31:59 2016, YOHEIMUTA wrote:

> > We created a child class based CLI::Dispatch::Command according to > > README instructions. And this child class implemented a new > > subroutine > > and set instance variables in it. But the variables are invalid in > > run > > method because CLI::Dispatch::Command's set_options method runs `%{ > > $self } = @_;`. > > > > We want to keep the child instance variables. > > > > I write a proposal commit. > > See https://github.com/yoheimuta/CLI-Dispatch- > > tmp/commit/c0117d203e0e1b58722a620ce2138568485be436, sorry for > > uploading to github without your permission... > > > > We appreciate this useful module. > > Thanks.

I sent a pr. https://github.com/charsbar/cli-dispatch/pull/1 Thank you for a quick reply.

Sat Jun 25 10:28:08 2016 ishigaki [...] cpan.org - Correspondence added

On Sat Jun 25 22:50:05 2016, YOHEIMUTA wrote: Show quoted text

> On 2016-6月-25 土 09:40:40, ISHIGAKI wrote:

> > Your patch seems reasonable. Could you re-send me the patch as a pull > > request to https://github.com/charsbar/cli-dispatch, please? Thank you > > for the report. > > > > On Sat Jun 25 22:31:59 2016, YOHEIMUTA wrote:

> > > We created a child class based CLI::Dispatch::Command according to > > > README instructions. And this child class implemented a new > > > subroutine > > > and set instance variables in it. But the variables are invalid in > > > run > > > method because CLI::Dispatch::Command's set_options method runs `%{ > > > $self } = @_;`. > > > > > > We want to keep the child instance variables. > > > > > > I write a proposal commit. > > > See https://github.com/yoheimuta/CLI-Dispatch- > > > tmp/commit/c0117d203e0e1b58722a620ce2138568485be436, sorry for > > > uploading to github without your permission... > > > > > > We appreciate this useful module. > > > Thanks.

> > > I sent a pr. https://github.com/charsbar/cli-dispatch/pull/1 > Thank you for a quick reply.

Shipped 0.21. Thank you.

Sat Jun 25 10:28:08 2016 ishigaki [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Jun 25 21:14:57 2016 YOHEIMUTA [...] cpan.org - Correspondence added

On 2016-6月-25 土 10:28:08, ISHIGAKI wrote: Show quoted text

> On Sat Jun 25 22:50:05 2016, YOHEIMUTA wrote:

> > On 2016-6月-25 土 09:40:40, ISHIGAKI wrote:

> > > Your patch seems reasonable. Could you re-send me the patch as a pull > > > request to https://github.com/charsbar/cli-dispatch, please? Thank you > > > for the report. > > > > > > On Sat Jun 25 22:31:59 2016, YOHEIMUTA wrote:

> > > > We created a child class based CLI::Dispatch::Command according to > > > > README instructions. And this child class implemented a new > > > > subroutine > > > > and set instance variables in it. But the variables are invalid in > > > > run > > > > method because CLI::Dispatch::Command's set_options method runs `%{ > > > > $self } = @_;`. > > > > > > > > We want to keep the child instance variables. > > > > > > > > I write a proposal commit. > > > > See https://github.com/yoheimuta/CLI-Dispatch- > > > > tmp/commit/c0117d203e0e1b58722a620ce2138568485be436, sorry for > > > > uploading to github without your permission... > > > > > > > > We appreciate this useful module. > > > > Thanks.

> > > > > > I sent a pr. https://github.com/charsbar/cli-dispatch/pull/1 > > Thank you for a quick reply.

> > Shipped 0.21. Thank you.

Thanks !