Skip Menu |

This queue is for tickets about the Gearman-Server CPAN distribution.

Report information
The Basics
Id: 115458
Status: resolved
Priority: 0/
Queue: Gearman-Server

People
Owner: Nobody in particular
Requestors: PLICEASE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Distributions contain no tests.
Without tests it is hard to have confidence that the gearman daemon will actually work when it is installed. If the Perl language changes in such a way to break the gearman daemon, it is unlikely that it will be caught by cpantesters since there are no tests.
I am attaching a patch which will check that the modules and script at least compile with the installing Perl. I also have this on my github here: https://github.com/plicease/Gearman-Server/tree/rt115458-tests
Subject: test.patch
commit e6d122cca27fa93d7a74f45eaceaeba1a37973a9 Author: Graham Ollis <plicease@cpan.org> Date: Sun Jun 19 10:05:03 2016 -0400 add basic test to make sure that modules and script at least compiles diff --git a/Makefile.PL b/Makefile.PL index d8ce29d..c671457 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -6,6 +6,9 @@ WriteMakefile( VERSION_FROM => 'lib/Gearman/Server.pm', ABSTRACT_FROM => 'lib/Gearman/Server.pm', EXE_FILES => ['gearmand'], + TEST_REQUIRES => { + 'Test::Script' => 0, + }, PREREQ_PM => { 'Gearman::Util' => 0, 'Danga::Socket' => 1.52, diff --git a/t/compile.t b/t/compile.t new file mode 100644 index 0000000..5aa6907 --- /dev/null +++ b/t/compile.t @@ -0,0 +1,12 @@ +use strict; +use warnings; +use Test::More; +use Test::Script; + +require_ok('Gearman::Server::Client'); +require_ok('Gearman::Server::Job'); +require_ok('Gearman::Server::Listener'); +require_ok('Gearman::Server'); +script_compiles_ok('gearmand'); + +done_testing;
it'll be done in upcoming v1.13.001
done in v1.130.0