Bug #115372 for Math-Currency: Unescaped left brace in regex is deprecated (0.48)

Thu Jun 16 13:59:19 2016 SREZIC [...] cpan.org - Ticket created

Subject:

Unescaped left brace in regex is deprecated (0.48)

t/006_defaults.t fails: # Failed test 'Default currency changed' # at t/006_defaults.t line 14. Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/(\d{ <-- HERE })(?=\d)(?!\d*\.)/ at /tmpfs/.cpan-build-cpansand/2016061615/Math-Currency-0.48-9fcN5u/blib/lib/Math/Currency.pm line 205. # Looks like you failed 1 test of 6. t/006_defaults.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/6 subtests

Thu Jun 16 14:00:33 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-06-16 13:59:19, SREZIC wrote: Show quoted text

> t/006_defaults.t fails: > > # Failed test 'Default currency changed' > # at t/006_defaults.t line 14. > Unescaped left brace in regex is deprecated, passed through in regex; > marked by <-- HERE in m/(\d{ <-- HERE })(?=\d)(?!\d*\.)/ at > /tmpfs/.cpan-build-cpansand/2016061615/Math-Currency-0.48- > 9fcN5u/blib/lib/Math/Currency.pm line 205. > # Looks like you failed 1 test of 6. > t/006_defaults.t .... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/6 subtests

Maybe also interesting: it fails only on my linux smokers, and passes on the freebsd ones.

Thu Jun 16 14:27:52 2016 MSCHOUT [...] cpan.org - Correspondence added

On Thu Jun 16 14:00:33 2016, SREZIC wrote: Show quoted text

> > # Failed test 'Default currency changed' > > # at t/006_defaults.t line 14. > > Unescaped left brace in regex is deprecated, passed through in regex; > > marked by <-- HERE in m/(\d{ <-- HERE })(?=\d)(?!\d*\.)/ at > > /tmpfs/.cpan-build-cpansand/2016061615/Math-Currency-0.48- > > 9fcN5u/blib/lib/Math/Currency.pm line 205. > > # Looks like you failed 1 test of 6. > > t/006_defaults.t .... > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/6 subtests

Passes for me on Centos 7, perl from perlbrew 5.20.1. Can you provide more info about your enviornment? What distro, version etc? -- Regards, Michael Schout

Thu Jun 16 14:27:52 2016 The RT System itself - Status changed from 'new' to 'open'

Thu Jun 16 16:54:55 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-06-16 14:27:52, MSCHOUT wrote: Show quoted text

> On Thu Jun 16 14:00:33 2016, SREZIC wrote: >

> > > # Failed test 'Default currency changed' > > > # at t/006_defaults.t line 14. > > > Unescaped left brace in regex is deprecated, passed through in regex; > > > marked by <-- HERE in m/(\d{ <-- HERE })(?=\d)(?!\d*\.)/ at > > > /tmpfs/.cpan-build-cpansand/2016061615/Math-Currency-0.48- > > > 9fcN5u/blib/lib/Math/Currency.pm line 205. > > > # Looks like you failed 1 test of 6. > > > t/006_defaults.t .... > > > Dubious, test returned 1 (wstat 256, 0x100) > > > Failed 1/6 subtests

> > Passes for me on Centos 7, perl from perlbrew 5.20.1. > > Can you provide more info about your enviornment? What distro, version etc?

My smokers run on debian wheezy + jessie. It fails also on Andreas Koenig's smoker (see http://fast-matrix.cpantesters.org/?dist=Math-Currency;os=linux;reports=1 ) --- AFAIK he is using debian sid. Also failing on Nigel Horne's smoker --- don't know what he's using.

Thu Jun 16 17:14:14 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-06-16 16:54:55, SREZIC wrote: Show quoted text

> On 2016-06-16 14:27:52, MSCHOUT wrote:

> > On Thu Jun 16 14:00:33 2016, SREZIC wrote: > >

> > > > # Failed test 'Default currency changed' > > > > # at t/006_defaults.t line 14. > > > > Unescaped left brace in regex is deprecated, passed through in > > > > regex; > > > > marked by <-- HERE in m/(\d{ <-- HERE })(?=\d)(?!\d*\.)/ at > > > > /tmpfs/.cpan-build-cpansand/2016061615/Math-Currency-0.48- > > > > 9fcN5u/blib/lib/Math/Currency.pm line 205. > > > > # Looks like you failed 1 test of 6. > > > > t/006_defaults.t .... > > > > Dubious, test returned 1 (wstat 256, 0x100) > > > > Failed 1/6 subtests

> > > > Passes for me on Centos 7, perl from perlbrew 5.20.1. > > > > Can you provide more info about your enviornment? What distro, > > version etc?

> > My smokers run on debian wheezy + jessie. It fails also on Andreas > Koenig's smoker (see http://fast-matrix.cpantesters.org/?dist=Math- > Currency;os=linux;reports=1 ) --- AFAIK he is using debian sid. Also > failing on Nigel Horne's smoker --- don't know what he's using.

Could it be that the lack of an en_GB locale is causing the problem here? On my debian system: $ locale -a C C.UTF-8 POSIX de_DE de_DE.iso88591 de_DE.utf8 deutsch en_US.utf8 fr_FR.utf8 german ru_RU.utf8

Fri Jun 17 20:08:44 2016 mschout [...] gkg.net - Correspondence added

Subject:	Re: [rt.cpan.org #115372] Unescaped left brace in regex is deprecated (0.48)
Date:	Fri, 17 Jun 2016 19:08:26 -0500
To:	bug-Math-Currency [...] rt.cpan.org
From:	Michael Schout <mschout [...] gkg.net>

On 6/16/16 4:14 PM, Slaven_Rezic via RT wrote: Show quoted text

> Could it be that the lack of an en_GB locale is causing the problem > here? On my debian system:

Yeah, I think that would probably be it. I'll add a "skip all" plan if that locale is not available and get something released tonight. Thanks. Regards, Michael Schout

Mon Jun 20 19:57:30 2016 mschout [...] gkg.net - Correspondence added

Subject:	Re: [rt.cpan.org #115372] Unescaped left brace in regex is deprecated (0.48)
Date:	Mon, 20 Jun 2016 18:57:18 -0500
To:	bug-Math-Currency [...] rt.cpan.org
From:	Michael Schout <mschout [...] gkg.net>

On 6/16/16 4:14 PM, Slaven_Rezic via RT wrote: Show quoted text

> Could it be that the lack of an en_GB locale is causing the problem > here? On my debian system:

Just wanted to follow up that this was indeed the problem. I have patched the tests in my repo, but I'm fixing some other localization bugs before releasing a new version. Regards, Michael Schout

Tue Jun 21 19:02:16 2016 MSCHOUT [...] cpan.org - Correspondence added

Fixed in v0.49, which has just been uploaded to CPAN. -- Regards, Michael Schout

Tue Jun 21 19:02:27 2016 MSCHOUT [...] cpan.org - Status changed from 'open' to 'patched'

Wed Jun 22 09:11:02 2016 MSCHOUT [...] cpan.org - Status changed from 'patched' to 'resolved'

Wed Jun 22 09:11:03 2016 MSCHOUT [...] cpan.org - Fixed in 0.49 added