Bug #115352 for Sendmail-PMilter: SETSENDER uses outdated API and constant value

Wed Jun 15 13:27:53 2016 jhealy [...] suffieldacademy.org - Ticket created

Subject:	SETSENDER uses outdated API and constant value
Date:	Wed, 15 Jun 2016 13:27:39 -0400
To:	bug-Sendmail-PMilter [...] rt.cpan.org
From:	"Jason Healy" <jhealy [...] suffieldacademy.org>

The setsender() and SMFIR_SETSENDER values are incorrect in Context.pm, relative to currently-shipping Postfix and Sendmail. Current definition is: use constant SMFIR_SETSENDER => 's'; However, per the current Sendmail and Postfix sources, the action/reply is now known as SMFIR_CHGFROM ('change-from', not 'set-sender'). Additionally, the corresponding constant is 'e', not 's' ('s' is used for 'skip'): http://fossies.org/linux/sendmail/include/libmilter/mfdef.h https://github.com/vdukhovni/postfix/blob/master/postfix/src/milter/milter8.c Likely should rename the function and constant to use the new nomenclature. However, as a quick fix, one can simply redefine the constant and the function works as intended: use constant SMFIR_SETSENDER => 'e'; Jason

Wed Jun 15 14:53:53 2016 avarab [...] gmail.com - Correspondence added

CC:	jhealy [...] suffieldacademy.org
Subject:	Re: [rt.cpan.org #115352] SETSENDER uses outdated API and constant value
Date:	Wed, 15 Jun 2016 20:53:34 +0200
To:	bug-Sendmail-PMilter [...] rt.cpan.org
From:	Ævar Arnfjörð Bjarmason <avarab [...] gmail.com>

Hi there. I've long since stopped using this module myself and have no ability/want to test your changes. Since you do though and want to get your patch in I'd be happy to give you maintainership of it. Just reply with your PAUSE ID and I'll make it so. On Jun 15, 2016 19:28, "Jason Healy via RT" < bug-Sendmail-PMilter@rt.cpan.org> wrote: Show quoted text

> Wed Jun 15 13:27:53 2016: Request 115352 was acted upon. > Transaction: Ticket created by jhealy@suffieldacademy.org > Queue: Sendmail-PMilter > Subject: SETSENDER uses outdated API and constant value > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: jhealy@suffieldacademy.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=115352 > > > > The setsender() and SMFIR_SETSENDER values are incorrect in Context.pm, > relative to currently-shipping Postfix and Sendmail. > > Current definition is: > > use constant SMFIR_SETSENDER => 's'; > > However, per the current Sendmail and Postfix sources, the action/reply is > now known as SMFIR_CHGFROM ('change-from', not 'set-sender'). > Additionally, the corresponding constant is 'e', not 's' ('s' is used for > 'skip'): > > http://fossies.org/linux/sendmail/include/libmilter/mfdef.h > > > https://github.com/vdukhovni/postfix/blob/master/postfix/src/milter/milter8.c > > Likely should rename the function and constant to use the new > nomenclature. However, as a quick fix, one can simply redefine the > constant and the function works as intended: > > use constant SMFIR_SETSENDER => 'e'; > > Jason > > >

Wed Jun 15 14:53:54 2016 The RT System itself - Status changed from 'new' to 'open'

Sun Apr 08 08:15:04 2018 pause [...] jubileegroup.co.uk - Taken

Sun Jun 30 12:53:20 2019 pause [...] jubileegroup.co.uk - Correspondence added

Fixed in version 1.21, not yet released.

Sun Jun 30 12:53:20 2019 pause [...] jubileegroup.co.uk - Status changed from 'open' to 'resolved'

Sat Jul 13 05:22:33 2019 pause [...] jubileegroup.co.uk - Fixed in 1.20_01 added