Bug #115184 for URI-XSEscape: Does not build with MSVC due to assumption that all compilers are gcc

Thu Jun 09 06:05:46 2016 nanis [...] cpan.org - Ticket created

Subject:	Does not build with MSVC due to assumption that all compilers are gcc
Date:	Thu, 9 Jun 2016 06:05:30 -0400
To:	bug-URI-XSEscape [...] rt.cpan.org
From:	"A. Sinan Unur" <nanis [...] cpan.org>

Makefile.PL adds gcc specific options to CCFLAGS. `gmem.c` includes non-portable header `unistd.h`. As a result, the module does not build on Windows using MSVC. I don't quite understand what `gmem.c` does, so, I am not able to provide a pull request at the moment, but please consider using portable constructs. If the module is only intended to be built with gcc, please update Makefile.PL to die in other cases. Thank you. -- Sinan

Wed Sep 21 10:50:08 2016 GONZUS [...] cpan.org - Correspondence added

On Thu Jun 09 06:05:46 2016, nanis@cpan.org wrote: Show quoted text

> Makefile.PL adds gcc specific options to CCFLAGS. > > `gmem.c` includes non-portable header `unistd.h`. > > As a result, the module does not build on Windows using MSVC. > > I don't quite understand what `gmem.c` does, so, I am not able to > provide a pull request at the moment, but please consider using > portable constructs. > > If the module is only intended to be built with gcc, please update > Makefile.PL to die in other cases. > > Thank you. > > -- Sinan

Hi Sinan, Sorry for not noticing / forgetting this report. I have just uploaded a new release to pause, it doesn't use unistd.h anymore. Just FYI, gmem is nothing more than a set of macros that, depending on a precompiler macro, will keep track of allocated / freed memory, and print a report at the end. Thanks again, Gonzo

Wed Sep 21 10:50:09 2016 The RT System itself - Status changed from 'new' to 'open'

Wed Sep 21 10:51:01 2016 GONZUS [...] cpan.org - Correspondence added 15 min

On Wed Sep 21 10:50:08 2016, GONZUS wrote: Show quoted text

> On Thu Jun 09 06:05:46 2016, nanis@cpan.org wrote:

> > Makefile.PL adds gcc specific options to CCFLAGS. > > > > `gmem.c` includes non-portable header `unistd.h`. > > > > As a result, the module does not build on Windows using MSVC. > > > > I don't quite understand what `gmem.c` does, so, I am not able to > > provide a pull request at the moment, but please consider using > > portable constructs. > > > > If the module is only intended to be built with gcc, please update > > Makefile.PL to die in other cases. > > > > Thank you. > > > > -- Sinan

> > Hi Sinan, > > Sorry for not noticing / forgetting this report. I have just uploaded > a new release to pause, it doesn't use unistd.h anymore. > > Just FYI, gmem is nothing more than a set of macros that, depending on > a precompiler macro, will keep track of allocated / freed memory, and > print a report at the end. > > Thanks again, > Gonzo

Closing ticket.

Wed Sep 21 10:51:07 2016 GONZUS [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Sep 21 10:51:07 2016 GONZUS [...] cpan.org - Taken