Skip Menu |

This queue is for tickets about the Archive-Tar CPAN distribution.

Report information
The Basics
Id: 115160
Status: resolved
Priority: 0/
Queue: Archive-Tar
People
Owner: BINGOS [...] cpan.org
Requestors: davem [...] iabyn.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Wed Jun 08 04:02:32 2016 davem [...] iabyn.com - Ticket created
Subject: TODOs in 09_roundtrip.t passing in blead
Date: Wed, 8 Jun 2016 09:02:19 +0100
To: bug-Archive-Tar [...] rt.cpan.org
From: Dave Mitchell <davem [...] iabyn.com>
Since Archive-Tar 2.08 was pulled into blead, these TODO tests seem to have been continuously passing: ../cpan/Archive-Tar/t/09_roundtrip.t (Wstat: 0 Tests: 7 Failed: 0) TODO passed: 1, 4, 6 If possible, it would be nice if these could unmarked TODO, to make blead testing less noisy. -- The Enterprise is captured by a vastly superior alien intelligence which does not put them on trial. -- Things That Never Happen in "Star Trek" #10
  Sun Sep 25 22:38:13 2016 jkeenan [...] cpan.org - Correspondence added
RT-Send-CC: book [...] cpan.org
On Wed Jun 08 04:02:32 2016, davem@iabyn.com wrote: Show quoted text
> Since Archive-Tar 2.08 was pulled into blead, these TODO tests > seem to have been continuously passing: > > ../cpan/Archive-Tar/t/09_roundtrip.t > (Wstat: 0 Tests: 7 Failed: 0) > TODO passed: 1, 4, 6 > > If possible, it would be nice if these could unmarked TODO, to make > blead > testing less noisy.
I have filed https://github.com/jib/archive-tar-new/pull/14 which un-TODO-s all the tests by addressing the problem causing 4 of the 7 tests to fail. The tests were failing because their expectations of Archive::Tar's behavior were incorrect. Due to certain factors in the implementation of helper method Archive::Tar::File::_prefix_and_file() which date from at least 2006, Archive::Tar::write() will write out archive entries which are directories without a trailing slash. So we have to "fix" the tests to match the long-standing behavior of the code. I expect that there may be some back-and-forth on the specific changes to the unit tests in t/09_roundtrip.t, but once that is settled and the pull request is merged into master, then we can import the new CPAN version into blead and be done with the TODO tests. Thank you very much. Jim Keenan
  Sun Sep 25 22:38:14 2016 The RT System itself - Status changed from 'new' to 'open'
  Thu Sep 29 10:48:15 2016 jkeenan [...] cpan.org - Correspondence added
On Sun Sep 25 22:38:13 2016, JKEENAN wrote: Show quoted text
> On Wed Jun 08 04:02:32 2016, davem@iabyn.com wrote:
> > Since Archive-Tar 2.08 was pulled into blead, these TODO tests > > seem to have been continuously passing: > > > > ../cpan/Archive-Tar/t/09_roundtrip.t > > (Wstat: 0 Tests: 7 Failed: 0) > > TODO passed: 1, 4, 6 > > > > If possible, it would be nice if these could unmarked TODO, to make > > blead > > testing less noisy.
> > I have filed https://github.com/jib/archive-tar-new/pull/14 which un- > TODO-s all the tests by addressing the problem causing 4 of the 7 > tests to fail. > > The tests were failing because their expectations of Archive::Tar's > behavior were incorrect. Due to certain factors in the implementation > of helper method Archive::Tar::File::_prefix_and_file() which date > from at least 2006, Archive::Tar::write() will write out archive > entries which are directories without a trailing slash. So we have to > "fix" the tests to match the long-standing behavior of the code. > > I expect that there may be some back-and-forth on the specific changes > to the unit tests in t/09_roundtrip.t, but once that is settled and > the pull request is merged into master, then we can import the new > CPAN version into blead and be done with the TODO tests. > > Thank you very much. > Jim Keenan
Archive-Tar maintainers: Have you had a chance to review the above? Thank you very much. Jim Keenan
  Thu Sep 29 10:55:55 2016 jkeenan [...] cpan.org - Correspondence added
On Sun Sep 25 22:38:13 2016, JKEENAN wrote: Show quoted text
> On Wed Jun 08 04:02:32 2016, davem@iabyn.com wrote:
> > Since Archive-Tar 2.08 was pulled into blead, these TODO tests > > seem to have been continuously passing: > > > > ../cpan/Archive-Tar/t/09_roundtrip.t > > (Wstat: 0 Tests: 7 Failed: 0) > > TODO passed: 1, 4, 6 > > > > If possible, it would be nice if these could unmarked TODO, to make > > blead > > testing less noisy.
> > I have filed https://github.com/jib/archive-tar-new/pull/14 which un- > TODO-s all the tests by addressing the problem causing 4 of the 7 > tests to fail. > > The tests were failing because their expectations of Archive::Tar's > behavior were incorrect. Due to certain factors in the implementation > of helper method Archive::Tar::File::_prefix_and_file() which date > from at least 2006, Archive::Tar::write() will write out archive > entries which are directories without a trailing slash. So we have to > "fix" the tests to match the long-standing behavior of the code. > > I expect that there may be some back-and-forth on the specific changes > to the unit tests in t/09_roundtrip.t, but once that is settled and > the pull request is merged into master, then we can import the new > CPAN version into blead and be done with the TODO tests. > > Thank you very much. > Jim Keenan
See also: https://rt.cpan.org/Ticket/Display.html?id=101922
  Fri May 12 10:42:24 2017 BINGOS [...] cpan.org - Correspondence added
On Thu Sep 29 10:55:55 2016, JKEENAN wrote: Show quoted text
> On Sun Sep 25 22:38:13 2016, JKEENAN wrote:
> > On Wed Jun 08 04:02:32 2016, davem@iabyn.com wrote:
> > > Since Archive-Tar 2.08 was pulled into blead, these TODO tests > > > seem to have been continuously passing: > > > > > > ../cpan/Archive-Tar/t/09_roundtrip.t > > > (Wstat: 0 Tests: 7 Failed: 0) > > > TODO passed: 1, 4, 6 > > > > > > If possible, it would be nice if these could unmarked TODO, to make > > > blead > > > testing less noisy.
> > > > I have filed https://github.com/jib/archive-tar-new/pull/14 which un- > > TODO-s all the tests by addressing the problem causing 4 of the 7 > > tests to fail. > > > > The tests were failing because their expectations of Archive::Tar's > > behavior were incorrect. Due to certain factors in the implementation > > of helper method Archive::Tar::File::_prefix_and_file() which date > > from at least 2006, Archive::Tar::write() will write out archive > > entries which are directories without a trailing slash. So we have to > > "fix" the tests to match the long-standing behavior of the code. > > > > I expect that there may be some back-and-forth on the specific changes > > to the unit tests in t/09_roundtrip.t, but once that is settled and > > the pull request is merged into master, then we can import the new > > CPAN version into blead and be done with the TODO tests. > > > > Thank you very much. > > Jim Keenan
> > > See also: https://rt.cpan.org/Ticket/Display.html?id=101922
I believe that this has been resolved. Closing.
  Fri May 12 10:42:29 2017 BINGOS [...] cpan.org - Status changed from 'open' to 'resolved'
  Fri May 12 10:42:30 2017 BINGOS [...] cpan.org - Taken