Skip Menu |

This queue is for tickets about the Inline-Awk CPAN distribution.

Report information
The Basics
Id: 115140
Status: resolved
Priority: 0/
Queue: Inline-Awk

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.03
Fixed in: (no value)



Subject: Unescaped left brace in regex is illegal in regex
Awk.pm does not compile anymore with perl 5.25.1: ... Unescaped left brace in regex is illegal in regex; marked by <-- HERE in m/^sub \w+ { <-- HERE $/ at Awk.pm line 154. Compilation failed in require at test.pl line 5. BEGIN failed--compilation aborted at test.pl line 5. not ok 1 *** Error code 255 ...
On Tue Jun 07 03:04:03 2016, SREZIC wrote: Show quoted text
> Awk.pm does not compile anymore with perl 5.25.1: > > ... > Unescaped left brace in regex is illegal in regex; marked by <-- HERE > in m/^sub \w+ { <-- HERE $/ at Awk.pm line 154. > Compilation failed in require at test.pl line 5. > BEGIN failed--compilation aborted at test.pl line 5. > not ok 1 > *** Error code 255 > ...
Hi Slaven, Thanks for the report and the continued work on making CPAN better. I don't know if it is worth fixing this issue since the module hasn't been updated since 2001 and, as far as I know, isn't used by anyone. I may do it just to stop the cpantesters failure messages but at this point I'm not sure if it is worth the effort. John
On 2016-06-07 06:16:35, JMCNAMARA wrote: Show quoted text
> On Tue Jun 07 03:04:03 2016, SREZIC wrote:
> > Awk.pm does not compile anymore with perl 5.25.1: > > > > ... > > Unescaped left brace in regex is illegal in regex; marked by <-- HERE > > in m/^sub \w+ { <-- HERE $/ at Awk.pm line 154. > > Compilation failed in require at test.pl line 5. > > BEGIN failed--compilation aborted at test.pl line 5. > > not ok 1 > > *** Error code 255 > > ...
> > > Hi Slaven, > > Thanks for the report and the continued work on making CPAN better. > > I don't know if it is worth fixing this issue since the module hasn't > been updated since 2001 and, as far as I know, isn't used by anyone. > > I may do it just to stop the cpantesters failure messages but at this > point I'm not sure if it is worth the effort. > > John
The fix is trivial and I attached it as 0001-escape-left-brace-RT-115140.patch Also I made a second patch to increase to 0.04 (and I removed the VERSION section from Pod to minimize maintainer effort). Regards, Slaven
Subject: 0001-escape-left-brace-RT-115140.patch
From 042d3fa4bd6bdf4b77c7895973e8caedce3cf3ff Mon Sep 17 00:00:00 2001 From: Slaven Rezic <slaven@rezic.de> Date: Wed, 8 Jun 2016 08:17:48 +0200 Subject: [PATCH 1/2] escape left brace (RT #115140) --- Awk.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Awk.pm b/Awk.pm index 00416d4..bcb1091 100644 --- a/Awk.pm +++ b/Awk.pm @@ -151,7 +151,7 @@ sub build { # Separate the main code from the subs. while (@code) { - last if $code[0] =~ /^sub \w+ {$/; + last if $code[0] =~ /^sub \w+ \{$/; push @main, shift @code; } -- 2.1.4
Subject: 0002-increase-version-to-0.04.patch
From 992d55a4707613e53b6133570e2d40c275dcd601 Mon Sep 17 00:00:00 2001 From: Slaven Rezic <slaven@rezic.de> Date: Wed, 8 Jun 2016 08:20:01 +0200 Subject: [PATCH 2/2] increase version to 0.04 --- Awk.pm | 10 +--------- Changes | 3 +++ 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/Awk.pm b/Awk.pm index bcb1091..b7c77fb 100644 --- a/Awk.pm +++ b/Awk.pm @@ -18,7 +18,7 @@ require Inline; use vars qw($VERSION @ISA); @ISA = qw(Inline); -$VERSION = '0.03'; +$VERSION = '0.04'; ############################################################################### @@ -254,14 +254,6 @@ Inline::Awk - Add awk code to your Perl programs. -=head1 VERSION - - -This document refers to version 0.03 of Inline::Awk, released November 15, 2001. - - - - =head1 SYNOPSIS diff --git a/Changes b/Changes index c47be62..efa978b 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,8 @@ Revision history for Perl extension Inline::Awk. +0.04 + Fix RT #115140 + 0.03 Tue Nov 15 2001 First CPAN release. -- 2.1.4
Fixed in version 0.04 uploaded to CPAN. Thanks.