Bug #115118 for Prima: Prima::Config::bin hard-codes DESTDIR

Mon Jun 06 04:36:37 2016 ppisar [...] redhat.com - Ticket created

Subject:

Prima::Config::bin hard-codes DESTDIR

When installing Prima-1.47 with "make pure_install DESTDIR=/tmp/prima-dest", the DESTDIR value gets stored into $bin variable in Prima::Config: /tmp/prima-dest/usr/lib64/perl5/vendor_perl/Prima/Config.pm:5:my $bin = q(/tmp/prima-dest/usr/bin); As explained in older and fixed CPAN RT#88983, this is undesired behavior. It looks like an unlucky combination of "bin=\$(DEST$6)" in Makefile.PL:install() and "my \$bin = qq($opt{bin});" in Makefile.PL:command_postinstall().

Mon Jun 06 05:36:18 2016 KARASIK [...] cpan.org - Correspondence added

Hi Petr, Sorry for breaking your builds. The reason was Prima-dependent modules couldn't build now. Could you please provide the full command you're building Prima with? I'm asking because I've tried "perl Makefile.PL INSTALLDIRS=/tmp/foo" (assuming /tmp/foo being a final location, as in your case) but that didn't work too well. My problem is now that I _have_ to know the final location of the binaries. The question is where do I take that from? Sincerely, Dmitry

Mon Jun 06 05:36:18 2016 The RT System itself - Status changed from 'new' to 'open'

Mon Jun 06 05:43:45 2016 KARASIK [...] cpan.org - Correspondence added

Oh sorry you have the line already. Could you please try this and see if that works for you? --- a/Makefile.PL +++ b/Makefile.PL @@ -2288,7 +2288,7 @@ sub install "$2\$(DEST$3)$4". "$5\$(DEST$6)$7$8". "\n\t\$(NOECHO) \$(ABSPERL) $0 --postinstall ". - "dest=\$(DEST$3) bin=\$(DEST$6) slib=$cygwin_fake_Slib\n\n" + "dest=\$(DEST$3) bin=\$($6) slib=$cygwin_fake_Slib\n\n" ]xgse; $END .= <<BAD_MAKEFILE if $n != 3;

Mon Jun 06 05:57:41 2016 ppisar [...] redhat.com - Correspondence added

From:

ppisar [...] redhat.com

Dne Po 06.čen.2016 05:43:45, KARASIK napsal(a): Show quoted text

> Oh sorry you have the line already. Could you please try this and see > if that works for you? > > > > --- a/Makefile.PL > +++ b/Makefile.PL > @@ -2288,7 +2288,7 @@ sub install > "$2\$(DEST$3)$4". > "$5\$(DEST$6)$7$8". > "\n\t\$(NOECHO) \$(ABSPERL) $0 --postinstall ". > - "dest=\$(DEST$3) bin=\$(DEST$6) > slib=$cygwin_fake_Slib\n\n" > + "dest=\$(DEST$3) bin=\$($6) > slib=$cygwin_fake_Slib\n\n" > ]xgse; > > $END .= <<BAD_MAKEFILE if $n != 3;

In the mean time, I came to to same fix. This one works for me. Thank you.

Mon Jun 06 06:25:01 2016 KARASIK [...] cpan.org - Correspondence added

Great, thank you! If you need it, I can make a dev release for you.

Mon Jun 06 06:25:07 2016 KARASIK [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Jun 06 06:46:25 2016 ppisar [...] redhat.com - Correspondence added

Subject:	Re: [rt.cpan.org #115118] Prima::Config::bin hard-codes DESTDIR
Date:	Mon, 6 Jun 2016 12:46:04 +0200
To:	KARASIK via RT <bug-Prima [...] rt.cpan.org>
From:	Petr Pisar <ppisar [...] redhat.com>

On Mon, Jun 06, 2016 at 06:25:02AM -0400, KARASIK via RT wrote: Show quoted text

> Great, thank you! If you need it, I can make a dev release for you.

That's not necessary. I applied the patch. -- Petr