Bug #115109 for HTML-Toc: libhtml-toc-perl: Unescaped left brace in regex is deprecated

Sun Jun 05 17:04:03 2016 gregoa [...] cpan.org - Ticket created

From:	gregoa [...] cpan.org
Subject:	libhtml-toc-perl: Unescaped left brace in regex is deprecated

We have the following bug reported to the Debian package of HTML-Toc (https://bugs.debian.org/826481): It doesn't seem to be a bug in the packaging, so you may want to take a look. Thanks! ------8<-----------8<-----------8<-----------8<-----------8<----- Package: libhtml-toc-perl Version: 1.12-1 Severity: normal User: debian-perl@lists.debian.org Usertags: perl-5.24-transition Building this package triggers deprecation warnings with Perl 5.24 (currently in experimental), and probably with Perl 5.22 (current sid) too. Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/{{ <-- HERE toc}}/ at /<<PKGBUILDDIR>>/blib/lib/HTML/TocInsertor.pm line 333. Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/{{ <-- HERE toc \[?\d*-?\d*\]?}}/ at /<<PKGBUILDDIR>>/blib/lib/HTML/TocInsertor.pm line 333. The offending file is also installed in a binary package, so this presumably has runtime effects too. A full build log is available at http://perl.debian.net/rebuild-logs/perl-5.24-throwaway/libhtml-toc-perl_1.12-1/ -- Niko Tyni ntyni@debian.org ------8<-----------8<-----------8<-----------8<-----------8<----- Thanks for considering, gregor herrmann, Debian Perl Group

Wed Jun 08 16:44:36 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-06-05 17:04:03, GREGOA wrote: Show quoted text

> We have the following bug reported to the Debian package of HTML-Toc > (https://bugs.debian.org/826481): > > It doesn't seem to be a bug in the packaging, so you may want to take > a look. Thanks! > > ------8<-----------8<-----------8<-----------8<-----------8<----- > > Package: libhtml-toc-perl > Version: 1.12-1 > Severity: normal > User: debian-perl@lists.debian.org > Usertags: perl-5.24-transition > > Building this package triggers deprecation warnings with Perl 5.24 > (currently in experimental), and probably with Perl 5.22 (current sid) > too. > > Unescaped left brace in regex is deprecated, passed through in regex; > marked by <-- HERE in m/{{ <-- HERE toc}}/ at > /<<PKGBUILDDIR>>/blib/lib/HTML/TocInsertor.pm line 333. > Unescaped left brace in regex is deprecated, passed through in regex; > marked by <-- HERE in m/{{ <-- HERE toc \[?\d*-?\d*\]?}}/ at > /<<PKGBUILDDIR>>/blib/lib/HTML/TocInsertor.pm line 333. > > The offending file is also installed in a binary package, so this > presumably has runtime effects too. > > A full build log is available at > http://perl.debian.net/rebuild-logs/perl-5.24-throwaway/libhtml-toc- > perl_1.12-1/

This is a hard error with perl 5.25.1. A possible patch to fix the issue may be found at: http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/HTML-Toc-1.12-RT115109.patch However, this is just fixing the failing test. Any HTML::Toc-using application which uses something like "{{toc}}" has to be patched, too.

Wed Jun 08 16:44:37 2016 The RT System itself - Status changed from 'new' to 'open'

Sun Jan 08 11:42:53 2017 jkeenan [...] cpan.org - Correspondence added

On Wed Jun 08 16:44:36 2016, SREZIC wrote: Show quoted text

> On 2016-06-05 17:04:03, GREGOA wrote:

> > We have the following bug reported to the Debian package of HTML-Toc > > (https://bugs.debian.org/826481): > > > > It doesn't seem to be a bug in the packaging, so you may want to take > > a look. Thanks! > > > > ------8<-----------8<-----------8<-----------8<-----------8<----- > > > > Package: libhtml-toc-perl > > Version: 1.12-1 > > Severity: normal > > User: debian-perl@lists.debian.org > > Usertags: perl-5.24-transition > > > > Building this package triggers deprecation warnings with Perl 5.24 > > (currently in experimental), and probably with Perl 5.22 (current > > sid) > > too. > > > > Unescaped left brace in regex is deprecated, passed through in regex; > > marked by <-- HERE in m/{{ <-- HERE toc}}/ at > > /<<PKGBUILDDIR>>/blib/lib/HTML/TocInsertor.pm line 333. > > Unescaped left brace in regex is deprecated, passed through in regex; > > marked by <-- HERE in m/{{ <-- HERE toc \[?\d*-?\d*\]?}}/ at > > /<<PKGBUILDDIR>>/blib/lib/HTML/TocInsertor.pm line 333. > > > > The offending file is also installed in a binary package, so this > > presumably has runtime effects too. > > > > A full build log is available at > > http://perl.debian.net/rebuild-logs/perl-5.24-throwaway/libhtml- > > toc- > > perl_1.12-1/

> > This is a hard error with perl 5.25.1. > > A possible patch to fix the issue may be found at: > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/HTML-Toc- > 1.12-RT115109.patch > > However, this is just fixing the failing test. Any HTML::Toc-using > application which uses something like "{{toc}}" has to be patched, > too.

This problem is still present in perl-5.25.8. Here's an excerpt from a 'cpanm' build log that I ran today. ##### 31191602-PERL_DL_NONLAZY=1 "/home/jkeenan/testing/blead/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t 31191603-Possible precedence issue with control flow operator at /home/jkeenan/.cpanm/work/1483878569.4432/HTML-Toc-1.12/blib/lib/HTML/TocInsertor.pm line 366. 31191604:Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/{{ <-- HERE toc}}/ at /home/jkeenan/.cpanm/work/1483878569.4432/HTML-Toc-1.12/blib/lib/HTML/TocInsertor.pm line 333. 31191605-# Looks like your test exited with 255 before it could output anything. 31191606-t/anchors.t ......... 31191607-Dubious, test returned 255 (wstat 65280, 0xff00) 31191608-Failed 7/7 subtests ##### Thank you very much. Jim Keenan

Thu Jun 22 08:29:50 2017 dam [...] cpan.org - Correspondence added

In Debian we are currently applying the following patch to HTML-Toc. We thought you might be interested in it too. Description: fix unescaped braces in regular expressions they are fatal with perl 5.26. Also, fix a mistyped comment, fooling perl to warn about possible operator precedence issue Author: Damyan Ivanov <dmn@debian.org> Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=826481 Bug: https://rt.cpan.org/Public/Bug/Display.html?id=115109 For me thes is working around a design issue. The tokens should either be plain strings (and used as m/\Q$token\E/) or compiled regular expressions (placing the responsibility of their correctness to the module user. The patch is tracked in our Git repository at https://anonscm.debian.org/cgit/pkg-perl/packages/libhtml-toc-perl.git/plain/debian/patches/perl-5.26.patch Thanks for considering, Damyan Ivanov, Debian Perl Group

Message body is not shown because sender requested not to inline it.