Bug #115098 for XML-DOM-XPath: libxml-dom-xpath-perl: Use of the encoding pragma is deprecated

Sun Jun 05 13:34:44 2016 gregoa [...] cpan.org - Ticket created

From:	gregoa [...] cpan.org
Subject:	libxml-dom-xpath-perl: Use of the encoding pragma is deprecated

We have the following bug reported to the Debian package of XML-DOM-XPath (https://bugs.debian.org/826451): It doesn't seem to be a bug in the packaging, so you may want to take a look. Thanks! ------8<-----------8<-----------8<-----------8<-----------8<----- Package: libxml-dom-xpath-perl Version: 0.14-2 Severity: minor User: debian-perl@lists.debian.org Usertags: perl-5.24-transition Building this package triggers deprecation warnings with Perl 5.24 (currently in experimental): Use of the encoding pragma is deprecated at t/test_non_ascii.t line 10. A full build log is available at http://perl.debian.net/rebuild-logs/perl-5.24-throwaway/libxml-dom-xpath-perl_0.14-2/ -- Niko Tyni ntyni@debian.org ------8<-----------8<-----------8<-----------8<-----------8<----- Thanks for considering, gregor herrmann, Debian Perl Group

Fri Jul 15 01:08:59 2016 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

On Sun Jun 05 13:34:44 2016, GREGOA wrote: Show quoted text

> We have the following bug reported to the Debian package of > XML-DOM-XPath (https://bugs.debian.org/826451): > > It doesn't seem to be a bug in the packaging, so you may want to take > a look. Thanks! > > ------8<-----------8<-----------8<-----------8<-----------8<----- > > Package: libxml-dom-xpath-perl > Version: 0.14-2 > Severity: minor > User: debian-perl@lists.debian.org > Usertags: perl-5.24-transition > > Building this package triggers deprecation warnings with Perl 5.24 > (currently in experimental): > > Use of the encoding pragma is deprecated at t/test_non_ascii.t line > 10.

encoding.pm is no longer supported in perl 5.25.3. This simple patch fixes it. The test in question did not even need encoding.pm.

Subject:

open_YGezpTHf.txt

diff -rup XML-DOM-XPath-0.14-_1HaPx-orig/t/test_non_ascii.t XML-DOM-XPath-0.14-_1HaPx/t/test_non_ascii.t --- XML-DOM-XPath-0.14-_1HaPx-orig/t/test_non_ascii.t 2016-07-14 22:05:39.000000000 -0700 +++ XML-DOM-XPath-0.14-_1HaPx/t/test_non_ascii.t 2016-07-14 22:05:56.000000000 -0700 @@ -7,7 +7,7 @@ use strict; use Test::More tests => 10; use XML::DOM::XPath; -use encoding 'utf8'; +use utf8; my $display_warning=0;

Fri Jul 15 01:08:59 2016 The RT System itself - Status changed from 'new' to 'open'

Mon Dec 10 12:00:22 2018 HMBRAND [...] cpan.org - Severity Important added

Sat Feb 16 12:51:33 2019 CXW [...] cpan.org - Correspondence added

Confirmed repro on Cygwin's system perl, Perl v5.26.3, installing into a local::lib. Log portion extracted from cpanm run: Installing /home/cxw/perl5/lib/perl5/x86_64-cygwin-threads-multi/.meta/XML-XPath Engine-0.14/install.json Installing /home/cxw/perl5/lib/perl5/x86_64-cygwin-threads-multi/.meta/XML-XPath Engine-0.14/MYMETA.json Building and testing XML-DOM-XPath-0.14 cp XPath.pm blib/lib/XML/DOM/XPath.pm Manifying 1 pod document PERL_DL_NONLAZY=1 "/usr/bin/perl.exe" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/1.t ................................. ok t/pod.t ............................... ok t/pod_coverage.t ...................... ok t/test_bugs.t ......................... ok The encoding pragma is no longer supported at t/test_non_ascii.t line 10. BEGIN failed--compilation aborted at t/test_non_ascii.t line 10. # Looks like your test exited with 2 before it could output anything. t/test_non_ascii.t .................... Dubious, test returned 2 (wstat 512, 0x200) Failed 10/10 subtests The rest of the tests passed. Applying SPROUT's fix worked for me. Thanks! On Fri Jul 15 01:08:59 2016, SPROUT wrote: Show quoted text

> On Sun Jun 05 13:34:44 2016, GREGOA wrote:

> > We have the following bug reported to the Debian package of > > XML-DOM-XPath (https://bugs.debian.org/826451): > > > > It doesn't seem to be a bug in the packaging, so you may want to take > > a look. Thanks! > > > > ------8<-----------8<-----------8<-----------8<-----------8<----- > > > > Package: libxml-dom-xpath-perl > > Version: 0.14-2 > > Severity: minor > > User: debian-perl@lists.debian.org > > Usertags: perl-5.24-transition > > > > Building this package triggers deprecation warnings with Perl 5.24 > > (currently in experimental): > > > > Use of the encoding pragma is deprecated at t/test_non_ascii.t line > > 10.

> > encoding.pm is no longer supported in perl 5.25.3. This simple patch > fixes it. The test in question did not even need encoding.pm.

Sat Feb 23 11:29:46 2019 SREZIC [...] cpan.org - Correspondence added

On 2016-07-15 01:08:59, SPROUT wrote: Show quoted text

> On Sun Jun 05 13:34:44 2016, GREGOA wrote:

> > We have the following bug reported to the Debian package of > > XML-DOM-XPath (https://bugs.debian.org/826451): > > > > It doesn't seem to be a bug in the packaging, so you may want to take > > a look. Thanks! > > > > ------8<-----------8<-----------8<-----------8<-----------8<----- > > > > Package: libxml-dom-xpath-perl > > Version: 0.14-2 > > Severity: minor > > User: debian-perl@lists.debian.org > > Usertags: perl-5.24-transition > > > > Building this package triggers deprecation warnings with Perl 5.24 > > (currently in experimental): > > > > Use of the encoding pragma is deprecated at t/test_non_ascii.t line > > 10.

> > encoding.pm is no longer supported in perl 5.25.3. This simple patch > fixes it. The test in question did not even need encoding.pm.

This patch is now used in the CPAN distroprefs file https://github.com/eserte/srezic-cpan-distroprefs/blob/master/XML-DOM-XPath.yml --- CPAN.pm users may use this for automatic patching.

Fri Nov 06 04:19:14 2020 nieder [...] users.sourceforge.net - Correspondence added

On Fri Jul 15 01:08:59 2016, SPROUT wrote: Show quoted text

> On Sun Jun 05 13:34:44 2016, GREGOA wrote:

> > We have the following bug reported to the Debian package of > > XML-DOM-XPath (https://bugs.debian.org/826451): > > > > It doesn't seem to be a bug in the packaging, so you may want to take > > a look. Thanks! > > > > ------8<-----------8<-----------8<-----------8<-----------8<----- > > > > Package: libxml-dom-xpath-perl > > Version: 0.14-2 > > Severity: minor > > User: debian-perl@lists.debian.org > > Usertags: perl-5.24-transition > > > > Building this package triggers deprecation warnings with Perl 5.24 > > (currently in experimental): > > > > Use of the encoding pragma is deprecated at t/test_non_ascii.t line > > 10.

> > encoding.pm is no longer supported in perl 5.25.3. This simple patch > fixes it. The test in question did not even need encoding.pm.

Show quoted text

>>-use encoding 'utf8'; >>+use utf8;

This undoes the change from #29423, which was released into 0.14. Does applying this revert negatively affect older perls? (though that bug was filed/fixed in the perl5.8 era so hard to test)