Skip Menu |

This queue is for tickets about the Petal CPAN distribution.

Report information
The Basics
Id: 11501
Status: resolved
Priority: 0/
Queue: Petal

People
Owner: Nobody in particular
Requestors: william [...] knowmad.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.15
Fixed in: (no value)



Subject: test 71-73 fail is URI not installed
Hi Bruno, While installing Petal onto a new server, I hit errors during testing due to a call to use URI which is not yet installed on my server. Looking at the tests that failed (71, 72, 73), only 71 really uses URI. For that test, I've written some code that will cause the test to be skipped. I've attached a patch which addresses these three issues. I'm new to creating multiple patches in a single file so let me know if this is fubared. Thanks, William
diff -ru /tmp/Petal-2.15/t/071_Encode_Overloaded_Object.t ./t/071_Encode_Overloaded_Object.t --- /tmp/Petal-2.15/t/071_Encode_Overloaded_Object.t 2004-06-04 07:57:48.000000000 -0400 +++ ./t/071_Encode_Overloaded_Object.t 2005-02-14 10:43:12.000000000 -0500 @@ -1,9 +1,18 @@ #!/usr/bin/perl -use Test::More 'no_plan'; +use Test::More; use warnings; use lib 'lib'; use Petal; -use URI; + +eval { + require URI; +}; +if( $@ ) { + plan skip_all => 'URI.pm not installed'; +} +else { + plan tests => 1; +} $Petal::DISK_CACHE = 0; $Petal::MEMORY_CACHE = 0; diff -ru /tmp/Petal-2.15/t/072_Metal_Define_Slot.t ./t/072_Metal_Define_Slot.t --- /tmp/Petal-2.15/t/072_Metal_Define_Slot.t 2004-07-20 11:41:31.000000000 -0400 +++ ./t/072_Metal_Define_Slot.t 2005-02-14 10:32:14.000000000 -0500 @@ -3,7 +3,6 @@ use warnings; use lib 'lib'; use Petal; -use URI; $Petal::DISK_CACHE = 0; $Petal::MEMORY_CACHE = 0; diff -ru /tmp/Petal-2.15/t/073_Metal_Fill_Slot.t ./t/073_Metal_Fill_Slot.t --- /tmp/Petal-2.15/t/073_Metal_Fill_Slot.t 2004-07-20 11:41:31.000000000 -0400 +++ ./t/073_Metal_Fill_Slot.t 2005-02-14 10:48:58.000000000 -0500 @@ -3,7 +3,6 @@ use warnings; use lib 'lib'; use Petal; -use URI; $Petal::DISK_CACHE = 0; $Petal::MEMORY_CACHE = 0;
Done patch applied to CVS HEAD