Using 1.11, things look a lot worse - though I suspect they are, in fact, no
worse:
t/TagLib.t ....................................... 1/1 # Using taglib 1.11
t/TagLib.t ....................................... ok
t/TagLib_APE_Footer.t ............................ ok
t/TagLib_APE_Item.t .............................. 1/14
# Failed test 'Using taglib 1.11'
# at t/TagLib_APE_Item.t line 44.
# got: 27
# expected: 13
# method size() failed
# Looks like you failed 1 test of 14.
t/TagLib_APE_Item.t .............................. Dubious, test returned 1
(wstat 256, 0x100)
Failed 1/14 subtests
t/TagLib_APE_ItemListMap.t ....................... ok
t/TagLib_APE_ItemListMap_Iterator.t .............. ok
t/TagLib_APE_Tag.t ............................... ok
t/TagLib_AudioProperties.t ....................... 1/6
# Failed test at t/TagLib_AudioProperties.t line 13.
# got: 6
# expected: 7
# method length() failed
# Looks like you failed 1 test of 6.
t/TagLib_AudioProperties.t ....................... Dubious, test returned 1
(wstat 256, 0x100)
Failed 1/6 subtests
t/TagLib_ByteVector.t ............................ ok
t/TagLib_ByteVector_Iterator.t ................... ok
t/TagLib_ByteVectorList.t ........................ ok
t/TagLib_File.t .................................. 1/13
# Failed test at t/TagLib_File.t line 26.
# got: 'H'
# expected: 'sample/guitar.mp3'
# method name() failed
# Failed test at t/TagLib_File.t line 31.
# got: 101
# expected: 1024
# method readBlock(blocksize) failed
# Looks like you failed 2 tests of 13.
t/TagLib_File.t .................................. Dubious, test returned 2
(wstat 512, 0x200)
Failed 2/13 subtests
t/TagLib_FileRef.t ............................... 1/15 TagLib: Could not
open file sample/guitar.mp3
TagLib: Could not open file sample/guitar.mp3
# Failed test at t/TagLib_FileRef.t line 17.
# got: '^'
# expected: 'sample/guitar.mp3'
# method create(file) failed
# Looks like you failed 1 test of 15.
t/TagLib_FileRef.t ............................... Dubious, test returned 1
(wstat 256, 0x100)
Failed 1/15 subtests
t/TagLib_FileRef_FileTypeResolver.t .............. ok
t/TagLib_FLAC_File.t ............................. 1/10 TagLib:
FLAC::File::streamInfoData() -- This function is obsolete. Returning an
empty ByteVector.
TagLib: FLAC::File::streamLength() -- This function is obsolete. Returning
zero.
# Failed test at t/TagLib_FLAC_File.t line 36.
# got: 0
# expected: 343788
# method streamLength() failed
# Looks like you failed 1 test of 10.
t/TagLib_FLAC_File.t ............................. Dubious, test returned 1
(wstat 256, 0x100)
Failed 1/10 subtests
t/TagLib_FLAC_Properties.t ....................... 1/7
# Failed test at t/TagLib_FLAC_Properties.t line 15.
# got: 396
# expected: 458
# method bitrate() failed
# Looks like you failed 1 test of 7.
t/TagLib_FLAC_Properties.t ....................... Dubious, test returned 1
(wstat 256, 0x100)
Failed 1/7 subtests
t/TagLib_ID3v1.t ................................. ok
t/TagLib_ID3v1_GenreMap.t ........................ ok
t/TagLib_ID3v1_GenreMap_Iterator.t ............... 1/8
# Failed test at t/TagLib_ID3v1_GenreMap_Iterator.t line 21.
# got: 148
# expected: 34
# method next() failed
# Looks like you failed 1 test of 8.
t/TagLib_ID3v1_GenreMap_Iterator.t ............... Dubious, test returned 1
(wstat 256, 0x100)
Failed 1/8 subtests
t/TagLib_ID3v1_StringHandler.t ................... ok
t/TagLib_ID3v1_Tag.t ............................. ok
t/TagLib_ID3v2_AttachedPictureFrame.t ............ 1/10 TagLib: A picture
frame must contain at least 5 bytes.
t/TagLib_ID3v2_AttachedPictureFrame.t ............ ok
t/TagLib_ID3v2_CommentsFrame.t ................... ok
t/TagLib_ID3v2_ExtendedHeader.t .................. ok
t/TagLib_ID3v2_Footer.t .......................... ok
t/TagLib_ID3v2_Frame.t ........................... ok
t/TagLib_ID3v2_FrameFactory.t .................... ok
t/TagLib_ID3v2_FrameList.t ....................... ok
t/TagLib_ID3v2_FrameList_Iterator.t .............. ok
t/TagLib_ID3v2_FrameListMap.t .................... ok
t/TagLib_ID3v2_FrameListMap_Iterator.t ........... ok
t/TagLib_ID3v2_Header.t .......................... 1/24
# Failed test 'Using taglib 1.11'
# at t/TagLib_ID3v2_Header.t line 113.
# Compared $data->[3]
# got : '4'
# expect : '2'
# method render() failed
# Looks like you failed 1 test of 24.
t/TagLib_ID3v2_Header.t .......................... Dubious, test returned 1
(wstat 256, 0x100)
Failed 1/24 subtests
t/TagLib_ID3v2_RelativeVolumeFrame.t ............. ok
t/TagLib_ID3v2_RelativeVolumeFrame_PeakVolume.t .. ok
t/TagLib_ID3v2_SynchData.t ....................... ok
t/TagLib_ID3v2_Tag.t ............................. ok
t/TagLib_ID3v2_TextIdentificationFrame.t ......... ok
t/TagLib_ID3v2_UniqueFileIdentifierFrame.t ....... ok
t/TagLib_ID3v2_UnknownFrame.t .................... ok
t/TagLib_ID3v2_UserTextIdentificationFrame.t ..... ok
t/TagLib_MPC_File.t .............................. ok
t/TagLib_MPC_Properties.t ........................ ok
t/TagLib_MPEG_File.t ............................. 1/16
# Failed test at t/TagLib_MPEG_File.t line 32.
# got: 0
# expected: 104
# method firstFrameOffset() failed
# Failed test at t/TagLib_MPEG_File.t line 38.
# got: 27794
# expected: -1
# method lastFrameOffset() failed
# Looks like you failed 2 tests of 16.
t/TagLib_MPEG_File.t ............................. Dubious, test returned 2
(wstat 512, 0x200)
Failed 2/16 subtests
t/TagLib_MPEG_Header.t ........................... 1/15 TagLib:
MPEG::Header::Header() - This constructor is no longer used.
# Failed test at t/TagLib_MPEG_Header.t line 34.
# got: 'Version1'
# expected: 'Version2'
# method version() failed
# Failed test at t/TagLib_MPEG_Header.t line 37.
# got: 0
# expected: 3
# method layer() failed
# Failed test at t/TagLib_MPEG_Header.t line 41.
# got: 0
# expected: 576
# method samplesPerFrame() failed
# Failed test at t/TagLib_MPEG_Header.t line 44.
# got: 0
# expected: 16000
# method sampleRate() failed
# Failed test at t/TagLib_MPEG_Header.t line 50.
# got:
# expected: 1
# method isValid() failed
# Failed test at t/TagLib_MPEG_Header.t line 53.
# got:
# expected: 1
# method isPadded() failed
# Failed test at t/TagLib_MPEG_Header.t line 56.
# got:
# expected: 1
# method isOriginal() failed
# Failed test at t/TagLib_MPEG_Header.t line 62.
# got: 0
# expected: 289
# method frameLength() failed
# Failed test at t/TagLib_MPEG_Header.t line 68.
# got: 0
# expected: 64
# method bitrate() failed
# Looks like you failed 9 tests of 15.
t/TagLib_MPEG_Header.t ........................... Dubious, test returned 9
(wstat 2304, 0x900)
Failed 9/15 subtests
t/TagLib_MPEG_Properties.t ....................... 1/12
# Failed test at t/TagLib_MPEG_Properties.t line 13.
# got: 6
# expected: 7
# method length() failed
# Looks like you failed 1 test of 12.
t/TagLib_MPEG_Properties.t ....................... Dubious, test returned 1
(wstat 256, 0x100)
Failed 1/12 subtests
t/TagLib_MPEG_XingHeader.t ....................... ok
t/TagLib_Ogg_FieldListMap.t ...................... ok
t/TagLib_Ogg_FieldListMap_Iterator.t ............. ok
t/TagLib_Ogg_File.t .............................. ok
t/TagLib_Ogg_FLAC_File.t ......................... ok
t/TagLib_Ogg_Page.t .............................. ok
t/TagLib_Ogg_PageHeader.t ........................ ok
t/TagLib_Ogg_Vorbis_File.t ....................... ok
t/TagLib_Ogg_Vorbis_Properties.t ................. ok
t/TagLib_Ogg_XiphComment.t ....................... 1/18
# Failed test at t/TagLib_Ogg_XiphComment.t line 51.
# got: 105
# expected: 109
# method render() failed
# Failed test at t/TagLib_Ogg_XiphComment.t line 53.
# got: 105
# expected: 109
# method render(addFramingBit) failed
# Looks like you failed 2 tests of 18.
t/TagLib_Ogg_XiphComment.t ....................... Dubious, test returned 2
(wstat 512, 0x200)
Failed 2/18 subtests
t/TagLib_String.t ................................ ok
t/TagLib_String_Iterator.t ....................... ok
t/TagLib_StringList.t ............................ ok
t/TagLib_Tag.t ................................... ok
t/TagLib_Vorbis_File.t ........................... ok
t/TagLib_Vorbis_Properties.t ..................... ok
Here's one way of patching TagLib_APE_Item.t and TagLib_ID3v2_Header.t to
remove their bugs:
#############################
--- t/TagLib_APE_Item.t_orig 2016-06-29 18:43:25 +1000
+++ t/TagLib_APE_Item.t 2016-06-29 19:09:14 +1000
@@ -38,7 +38,7 @@
$ver = qx{taglib-config --version};
chomp $ver;
-$is18 = $ver ge '1.8';
+$is18 = v_num($ver) >= v_num('1.8');
$size = $is18 ? 27 : 13;
cmp_ok($i->size(), "==", $size, "Using taglib $ver")
or
@@ -64,3 +64,8 @@
$i->setType("Text");
ok(not $i->isEmpty()) or
diag("method isEmpty() failed");
+
+sub v_num {
+ my @v = split /\./, $_[0];
+ return ($v[0] * 10000) + $v[1];
+}
--- t/TagLib_ID3v2_Header.t_orig 2016-06-29 19:20:50 +1000
+++ t/TagLib_ID3v2_Header.t 2016-06-29 19:28:31 +1000
@@ -75,7 +75,7 @@
$ver = qx{taglib-config --version};
chomp $ver;
-$is18 = $ver ge '1.8';
+$is18 = v_num($ver) >= v_num('1.8');
# Render changes things a bit
# The point to this test is to demonstrate that the
@@ -119,3 +119,8 @@
$i = Audio::TagLib::ID3v2::Header->new($data);
cmp_ok($i->majorVersion(), '==', 97)
or
diag("method majorVersion() failed");
+
+sub v_num {
+ my @v = split /\./, $_[0];
+ return ($v[0] * 10000) + $v[1];
+}
#############################
Those bugs should not be specific to Windows.
And it looks like there's a couple of instances of the test scripts using
functions/constructors that are no longer supported in 1.11.
Other than that, I think the failures are related to that same problem with
"samples/guitar.mp3" path.
I'll take a closer look when I get a chance.
Cheers,
Rob
