| Date: | Sat, 12 Feb 2005 20:14:50 +0100 |
| From: | Max Maischein <corion [...] corion.net> |
| To: | bug-File-Fetch [...] rt.cpan.org |
| Subject: | File::Fetch v0.07 handles file:// URLs incorrect (another instance) |
Hi again,
the routine _lwp_fetch also handles file:// URIs incorrectly, by
resetting the host: part to '':
sub _lwp_fetch {
...
$uri->host( $self->scheme eq 'file' ? '' : $self->host );
...
}
Changing that to:
sub _lwp_fetch {
...
#$uri->host( $self->scheme eq 'file' ? '' : $self->host );
$uri->host( $self->host );
...
}
still passes all tests and makes it work on my machine too:
C:\.cpan\5.8.5\build\File-Fetch-0.07>perl -Ilib -MFile::Fetch -e
"File::Fetch->new(uri=>'file://aliens/cpan/minicpan/authors/01mailrc.txt.gz')->fetch()"
C:\.cpan\5.8.5\build\File-Fetch-0.07>dir 01mailrc.txt.gz
Datenträger in Laufwerk C: hat keine Bezeichnung.
Datenträgernummer: 6C76-F753
Verzeichnis von C:\.cpan\5.8.5\build\File-Fetch-0.07
11.02.2005 20:46 95.048 01mailrc.txt.gz
1 Datei(en) 95.048 Bytes
0 Verzeichnis(se), 44.097.675.264 Bytes frei
Of course, fixing the error here (and increasing the version number)
uncovers one more error in CPANPLUS::Internals::Fetch (0.053), which
also has broken file:// handling, but this will go into a separate bug
report.
-max