Skip Menu |

This queue is for tickets about the File-Fetch CPAN distribution.

Report information
The Basics
Id: 11483
Status: resolved
Priority: 0/
Queue: File-Fetch

People
Owner: Nobody in particular
Requestors: corion [...] corion.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Date: Sat, 12 Feb 2005 19:43:34 +0100
From: Max Maischein <corion [...] corion.net>
To: bug-File-Fetch [...] rt.cpan.org
Subject: File::Fetch 0.07 cannot do an FTP fetch on Win32
Hello Jos, on Win32, File::Fetch 0.07 does not properly fetch files via FTP, because File::Spec is used to construct a FTP URL - but FTP paths don't follow the Win32 conventions. You should either be really explicit and reconstruct the FTP url via sub _netftp_fetch { ... #line 360 ### create the remote path ### my $remote = join "/", $self->path, $self->file or, at least, use File::Spec::UNIX : #line 360 ### create the remote path ### my $remote = File::Spec::Unix->catfile( $self->path, $self->file); If you apply the second fix, File::Fetch 0.07 passes all tests on Win32, with File::Spec 0.87. A second possible candidate of a comparable same error might be around line 627 in the sub _file_fetch, but I'm too lazy to find/fix it at the moment. -max
Date: Sat, 12 Feb 2005 19:42:11 +0100
From: Max Maischein <corion [...] corion.net>
To: bug-File-Fetch [...] rt.cpan.org
Subject: File::Fetch 0.07 cannot do an FTP fetch on Win32
Hello Jos, on Win32, File::Fetch 0.07 does not properly fetch files via FTP, because File::Spec is used to construct a FTP URL - but FTP paths don't follow the Win32 conventions. You should either be really explicit and reconstruct the FTP url via #line 360 ### create the remote path ### my $remote = join "/", $self->path, $self->file or, at least, use File::Spec::UNIX : #line 360 ### create the remote path ### my $remote = File::Spec::Unix->catfile( $self->path, $self->file); If you apply the second fix, File::Fetch 0.07 passes all tests on Win32, with File::Spec 0.87. A second possible candidate of a comparablehe same error -max
[corion@corion.net - Sat Feb 12 14:55:12 2005]: Show quoted text
> Hello Jos, > > on Win32, File::Fetch 0.07 does not properly fetch files via FTP, > because File::Spec is used to construct a FTP URL - but FTP paths don't > follow the Win32 conventions. You should either be really explicit and > reconstruct the FTP url via
Thanks, fixed @11967