Skip Menu |

This queue is for tickets about the Log-Log4perl CPAN distribution.

Report information
The Basics
Id: 114822
Status: resolved
Priority: 0/
Queue: Log-Log4perl

People
Owner: Nobody in particular
Requestors: h.huzen [...] belastingdienst.nl
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: $Log$ CVS keyword conflict
Date: Mon, 30 May 2016 11:07:48 +0200
To: bug-Log-Log4perl [...] rt.cpan.org
From: h.huzen [...] belastingdienst.nl
Hi With Log-Log4perl.1.47, in Log/Log4perl/Config line 184 and Log/Log4perl.pm, line 618 the text contains the sequence '$Log.....$', which conflicts with CVS. For text file CVS substitutes this as the $Log$ keyword, which breaks the code. Use of text files in CVS is usefull for compiling perl modules on non-ascii hosts. The comment in Log/Log4perl.pm, line 112 shows that this problem was seen and fixed before in that particular place. It was solved there by splitting the line but that uglifies the code and does not warn future developers making modifications in other places. A better solution might be to rename the $Log variable throughout the whole module. Kind regards Harrie Huzen Specialist Ontwikkelen ........................................................................ Belastingdienst Centrum voor Applicatieontwikkeling en -onderhoud Service Delivery – FAD Ondersteuning Ontwikkel Services (OOS) Competence Center Gen/GuardIEn John F. Kennedylaan 8 | 7314 PS | Apeldoorn | G2 Flex Postbus 9050 | 7300 GM | Apeldoorn ........................................................................ M 06 - 55 42 08 50 h.huzen@belastingdienst.nl Competence Center Gen/GuardIEn ........................................................................ = may the source be with you = ------------------------------------------------------------------------ De Belastingdienst stelt e-mail niet open voor aanvragen, aangiften, bezwaarschriften, verzoeken, klachten, ingebrekestellingen en soortgelijke formele berichten. Dit bericht is uitsluitend bestemd voor de geadresseerde. Het bericht kan vertrouwelijke informatie bevatten waarvoor de fiscale geheimhoudingsplicht geldt. Als u dit bericht per abuis hebt ontvangen, wordt u verzocht het te verwijderen en de afzender te informeren. The Dutch Tax and Customs Administration does not accept filings, requests, appeals, complaints, notices of default or similar formal notices, sent by email. This message is solely intended for the addressee. It may contain information that is confidential and legally privileged. If you are not the intended recipient please delete this message and notify the sender.
Thanks for reporting this. It was easy to fix by adding a line break in two places, so I went ahead and did it. As for your suggestion: $Log::Log4perl::...$ is a fully qualified variable name plus some valid Perl code. The first part is the module's own Log::Log4perl namespace and I sure as hell ain't going to change that to accommodate a completely broken revision control system from the dark ages of computing :). Anyways, here's the fix: https://github.com/mschilli/log4perl/commit/e724aa9ce781ce2d2036e81db6213d71ba9d2284 Let me know if this fixes the problem for you as well!