Skip Menu |

This queue is for tickets about the Modern-Perl CPAN distribution.

Report information
The Basics
Id: 114690
Status: open
Priority: 0/
Queue: Modern-Perl
People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in:
  • 1.20150127
  • 1.20161005
  • 1.20161229
Fixed in: (no value)

History Show all quoted text
  Wed May 25 02:17:31 2016 ANDK [...] cpan.org - Ticket created
Subject: Fails with bleadperl v5.25.1-13-g60e04ba
As per subject. commit 60e04ba1a34f784612d20e526a0ce38e47a53cf1 Author: Father Chrysostomos <sprout@cpan.org> Date: Fri May 20 12:45:10 2016 -0700 Enable lex subs everywhere; suppress warning Adjust tests, too. Sample fail report: http://www.cpantesters.org/cpan/report/b60e617e-205d-11e6-aaa3-b7aedf514e2c HTH&&Thanks,
  Wed May 25 18:47:16 2016 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Wed May 25 02:17:31 2016, ANDK wrote: Show quoted text
> As per subject. > > commit 60e04ba1a34f784612d20e526a0ce38e47a53cf1 > Author: Father Chrysostomos <sprout@cpan.org> > Date: Fri May 20 12:45:10 2016 -0700 > > Enable lex subs everywhere; suppress warning > > Adjust tests, too. > > > Sample fail report: > http://www.cpantesters.org/cpan/report/b60e617e-205d-11e6-aaa3-b7aedf514e2c
lexical_subs were never part of a feature bundle, so I don’t even know why Modern::Perl is testing them. The easiest thing is to delete the offending tests. See the attachment.
Subject: open_PNn0auE3.txt
diff -rup Modern-Perl-1.20150127-pK87bZ-orig/t/year_imports.t Modern-Perl-1.20150127-pK87bZ/t/year_imports.t --- Modern-Perl-1.20150127-pK87bZ-orig/t/year_imports.t 2015-01-26 23:21:54.000000000 -0800 +++ Modern-Perl-1.20150127-pK87bZ/t/year_imports.t 2016-05-25 15:45:05.000000000 -0700 @@ -99,8 +99,6 @@ if ($] >= 5.016) q|use Modern::Perl '2013' disables array_base|; eval 'fc("tschüß") eq fc("TSCHÜSS")'; is $@, '', q|use Modern::Perl '2013' enables fc|; - eval 'my sub foo {}'; - isnt $@, '', q|use Modern::Perl '2013' should not enable lexical subs|; }; is $@, '', 'this block should succeed'; } @@ -125,8 +123,6 @@ if ($] >= 5.018) q|use Modern::Perl '2014' disables array_base|; eval 'fc("tschüß") eq fc("TSCHÜSS")'; is $@, '', q|use Modern::Perl '2014' enables fc|; - eval 'my sub foo {}'; - isnt $@, '', q|use Modern::Perl '2014' does not enable lexical subs|; }; is $@, '', 'this block should succeed'; } @@ -151,8 +147,6 @@ if ($] >= 5.020) q|use Modern::Perl '2015' disables array_base|; eval 'fc("tschü¼Ã")eq fc("TSCHÃS")'; is $@, '', q|use Modern::Perl '2015' enables fc|; - eval 'my sub foo {}'; - isnt $@, '', q|use Modern::Perl '2015' does not enable lexical subs|; }; is $@, '', 'this block should succeed'; }
  Wed May 25 18:47:17 2016 The RT System itself - Status changed from 'new' to 'open'
  Wed Oct 05 13:46:30 2016 SREZIC [...] cpan.org - Correspondence added
On 2016-05-25 02:17:31, ANDK wrote: Show quoted text
> As per subject. > > commit 60e04ba1a34f784612d20e526a0ce38e47a53cf1 > Author: Father Chrysostomos <sprout@cpan.org> > Date: Fri May 20 12:45:10 2016 -0700 > > Enable lex subs everywhere; suppress warning > > Adjust tests, too. > > > Sample fail report: > http://www.cpantesters.org/cpan/report/b60e617e-205d-11e6-aaa3-b7aedf514e2c > > HTH&&Thanks,
Still fails with 1.20161005
  Thu Oct 06 02:28:50 2016 SREZIC [...] cpan.org - Broken in 1.20161005 added
  Thu Dec 29 03:28:47 2016 SREZIC [...] cpan.org - Broken in 1.20161229 added
  Sat Jan 07 22:17:20 2017 jkeenan [...] cpan.org - Correspondence added
On Wed Oct 05 13:46:30 2016, SREZIC wrote: Show quoted text
> On 2016-05-25 02:17:31, ANDK wrote:
> > As per subject. > > > > commit 60e04ba1a34f784612d20e526a0ce38e47a53cf1 > > Author: Father Chrysostomos <sprout@cpan.org> > > Date: Fri May 20 12:45:10 2016 -0700 > > > > Enable lex subs everywhere; suppress warning > > > > Adjust tests, too. > > > > > > Sample fail report: > > http://www.cpantesters.org/cpan/report/b60e617e-205d-11e6-aaa3- > > b7aedf514e2c > > > > HTH&&Thanks,
> > Still fails with 1.20161005
And with Modern-Perl-1.20161229
  Sun Jan 15 16:13:04 2017 chromatic [...] cpan.org - Correspondence added
I'm baffled by this report, as the tests work in multiple versions of Perl and perl5180delta's "Lexical subroutines" section gives the specific example of 'use feature "lexical_subs";', as does the "Lexical Subroutines" section in perlsub for 5.24. This leads me to believe that deleting the tests is the wrong approach, as code and documentation agree here. What then is the right approach?
  Sun Jan 15 17:45:01 2017 andreas.koenig.7os6VVqR [...] franz.ak.mind.de - Correspondence added
CC: ANDK [...] cpan.org
Subject: Re: [rt.cpan.org #114690] Fails with bleadperl v5.25.1-13-g60e04ba
Date: Sun, 15 Jan 2017 23:44:33 +0100
To: "CHROMATIC via RT" <bug-Modern-Perl [...] rt.cpan.org>
From: Andreas Koenig <andreas.koenig.7os6VVqR [...] franz.ak.mind.de>
Show quoted text
>>>>> On Sun, 15 Jan 2017 16:13:05 -0500, "CHROMATIC via RT" <bug-Modern-Perl@rt.cpan.org> said:
Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=114690 > > I'm baffled by this report, as the tests work in multiple versions of > Perl and perl5180delta's "Lexical subroutines" section gives the > specific example of 'use feature "lexical_subs";', as does the > "Lexical Subroutines" section in perlsub for 5.24.
Show quoted text
> This leads me to believe that deleting the tests is the wrong approach, as code and documentation agree here.
Show quoted text
> What then is the right approach?
Have you checked the commit in the subject line? Have you tried to run the tests with any recent bleadperl version? What did you try? What was the result, what the expectation? I'm willing to help but I need to understand your questions first. Or are you specifically asking FC? -- andreas