Bug #11469 for Spoon: Test errors

This also fails on Win32. It appears to be related to the way that the export list is created within Spiffy. I have altered the internals of Spiffy::import, and although it now appears to work for Spoon, they fail the distribution tests for Spiffy-0.22. The changes I made for Spoon to work are: --- C:\wip\diffs\spoon\Spiffy-0.22/lib/Spiffy.pm Tue Jan 11 08:44:40 2005 +++ C:\wip\diffs\spoon\Spiffy-0.22-barbie/lib/Spiffy.pm Tue Apr 5 13:55:24 2005 @@ -96,15 +96,20 @@ not defined &{"$caller_package\::$_"}; } @{"$class\::EXPORT_OK"}; my %exportable = map { ($_, 1) } @export, @export_ok; + for(@export_list) { + my ($a,$v) = ($_ =~ m/^([\!\:])?(.*)/); + if($a eq '!') { + delete $exportable{$v}; + delete ${"$class\::EXPORT_TAGS"}{$v}; + } + $exportable{$v} = 1 if($a eq ':'); + } next unless keys %exportable; my @export_save = @{"$class\::EXPORT"}; my @export_ok_save = @{"$class\::EXPORT_OK"}; @{"$class\::EXPORT"} = @export; @{"$class\::EXPORT_OK"} = @export_ok; - my @list = grep { - (my $v = $_) =~ s/^[\!\:]//; - $exportable{$v} or ${"$class\::EXPORT_TAGS"}{$v}; - } @export_list; + my @list = keys %exportable; Exporter::export($class, $caller_package, @list); @{"$class\::EXPORT"} = @export_save; @{"$class\::EXPORT_OK"} = @export_ok_save; However as this breaks the distribution tests, I probably have misunderstood the intent of the code.