Skip Menu |

This queue is for tickets about the Excel-Template-XLSX CPAN distribution.

Report information
The Basics
Id: 114543
Status: resolved
Priority: 0/
Queue: Excel-Template-XLSX

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: v1.0.5
Fixed in: (no value)



Subject: t/07-two_templates.t fails (with newest Excel::Writer::XLSX?)
Some of my smokers show the following test failure: Not an ARRAY reference at t/07-two_templates.t line 55. # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 255 just after 6. Use of uninitialized value in numeric eq (==) at /home/cpansand/.cpan/build/2016052106/Excel-Writer-XLSX-0.90-zHqA2e/blib/lib/Excel/Writer/XLSX/Workbook.pm line 950 during global destruction. (in cleanup) Can't use an undefined value as an ARRAY reference at /home/cpansand/.cpan/build/2016052106/Excel-Writer-XLSX-0.90-zHqA2e/blib/lib/Excel/Writer/XLSX/Workbook.pm line 1554 during global destruction. t/07-two_templates.t ...... Dubious, test returned 255 (wstat 65280, 0xff00) All 6 subtests passed Statistical analysis suggests that the problem happens only with Excel::Writer::XLSX 0.90 (negative theta is bad): **************************************************************** Regression 'mod:Excel::Writer::XLSX' **************************************************************** Name Theta StdErr T-stat [0='const'] 1.0000 0.0000 23836686367097864.00 [1='eq_0.85'] -0.0000 0.0000 -1.18 [2='eq_0.86'] 0.0000 0.0000 0.00 [3='eq_0.87'] -0.0000 0.0000 -1.15 [4='eq_0.88'] 0.0000 0.0000 0.00 [5='eq_0.89'] -0.0000 0.0000 -2.48 [6='eq_0.90'] -1.0000 0.0000 -22727388702608236.00 R^2= 1.000, N= 57, K= 7 ****************************************************************
RT-Send-CC: jmcnamara [...] cpan.org
@John: FYI. On 2016-05-21 04:31:22, SREZIC wrote: Show quoted text
> Some of my smokers show the following test failure: > > Not an ARRAY reference at t/07-two_templates.t line 55. > # Tests were run but no plan was declared and done_testing() was not > seen. > # Looks like your test exited with 255 just after 6. > Use of uninitialized value in numeric eq (==) at > /home/cpansand/.cpan/build/2016052106/Excel-Writer-XLSX-0.90- > zHqA2e/blib/lib/Excel/Writer/XLSX/Workbook.pm line 950 during global > destruction. > (in cleanup) Can't use an undefined value as an ARRAY > reference at /home/cpansand/.cpan/build/2016052106/Excel-Writer-XLSX- > 0.90-zHqA2e/blib/lib/Excel/Writer/XLSX/Workbook.pm line 1554 during > global destruction. > t/07-two_templates.t ...... > Dubious, test returned 255 (wstat 65280, 0xff00) > All 6 subtests passed > > Statistical analysis suggests that the problem happens only with > Excel::Writer::XLSX 0.90 (negative theta is bad): > > **************************************************************** > Regression 'mod:Excel::Writer::XLSX' > **************************************************************** > Name Theta StdErr T-stat > [0='const'] 1.0000 0.0000 23836686367097864.00 > [1='eq_0.85'] -0.0000 0.0000 -1.18 > [2='eq_0.86'] 0.0000 0.0000 0.00 > [3='eq_0.87'] -0.0000 0.0000 -1.15 > [4='eq_0.88'] 0.0000 0.0000 0.00 > [5='eq_0.89'] -0.0000 0.0000 -2.48 > [6='eq_0.90'] -1.0000 0.0000 -22727388702608236.00 > > R^2= 1.000, N= 57, K= 7 > ****************************************************************
Hi, The failing test in Excel-Template-XLSX is using an internal member in the Workbook class called $workbook->{_sheetnames}. This changed type and usage between Excel::Writer::XLSX 0.89 and 0.90. The test should use the public api $worksheet->get_name() instead. There may be other issues as well but that is the first one.
Version 1.0.7 uploaded to cpan. XLSX.pm and several test modules updated to use public API get_name(), instead of inspecting Excel::Writer::XLSX internals. build script modified to require Excel::Writer::XLSX version 0.90, since the API was not available prior to this release.