Skip Menu |

This queue is for tickets about the libnet CPAN distribution.

Report information
The Basics
Id: 114410
Status: resolved
Priority: 0/
Queue: libnet

People
Owner: Nobody in particular
Requestors: davem [...] iabyn.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: libnet tests noisy in blead
Date: Mon, 16 May 2016 16:42:25 +0100
To: bug-libnet [...] rt.cpan.org
From: Dave Mitchell <davem [...] iabyn.com>
In blead (5.25.0), the tests are giving: Use of uninitialized value in exit at t/nntp_ipv6.t line 36. Use of uninitialized value in exit at t/pop3_ipv6.t line 35. Use of uninitialized value in exit at t/smtp_ipv6.t line 35. This because they all do something like: use Test::More; ... exit(nntp_server()); sub nntp_server { .... note("NNTP dialog done"); } note() is not documented as returning any particular value, and it happens to have changed from returning 0 to returning undef since blead has upgraded cpan/Test-Simple/, so that: $ perl5240 -MTest::More -le'print $Test::More::VERSION' 1.001014 $ ./perl -MTest::More -le'print $Test::More::VERSION' 1.302015 I don't know whether the libnet tests should be relying on the return value of note(), and if not, I'm not sure what the return value of nntp_server() etc should be. -- It's not that I'm afraid to die, I just don't want to be there when it happens. -- Woody Allen
On Mon May 16 11:42:38 2016, davem@iabyn.com wrote: Show quoted text
> In blead (5.25.0), the tests are giving: > > Use of uninitialized value in exit at t/nntp_ipv6.t line 36. > Use of uninitialized value in exit at t/pop3_ipv6.t line 35. > Use of uninitialized value in exit at t/smtp_ipv6.t line 35. > > This because they all do something like: > > use Test::More; > > ... > > exit(nntp_server()); > > sub nntp_server { > .... > note("NNTP dialog done"); > } > > > note() is not documented as returning any particular value, > and it happens to have changed from returning 0 to returning > undef since blead has upgraded cpan/Test-Simple/, so that: > > $ perl5240 -MTest::More -le'print $Test::More::VERSION' > 1.001014 > $ ./perl -MTest::More -le'print $Test::More::VERSION' > 1.302015 > > I don't know whether the libnet tests should be relying on the return > value of note(), and if not, I'm not sure what the return value > of nntp_server() etc should be. > >
Thanks for the report. This is now fixed in Git with this merge of a patch from James Keenan: https://github.com/steve-m-hay/perl-libnet/commit/90b6e08518beb8f2a837abc8d47f3cfdc4966fa4 I will make a new release and update blead with it soon.