Bug #114382 for MailTools: Mail::Internet v2.17 breaks Email::Abstract

Sat May 14 15:43:39 2016 rjbs [...] cpan.org - Ticket created

Subject:

Mail::Internet v2.17 breaks Email::Abstract

I'm not sure just what's up, but now all the tests end up getting messages with empty bodies. I haven't changed a thing. v2.16 worked. Obvious to you? http://www.cpantesters.org/cpan/report/9f478190-19d3-11e6-9bf9-817a9220e041 -- rjbs

Sun May 15 05:58:58 2016 Mark [...] Overmeer.net - Correspondence added

Subject:	Re: [rt.cpan.org #114382] Mail::Internet v2.17 breaks Email::Abstract
Date:	Sun, 15 May 2016 11:58:40 +0200
To:	Ricardo Signes via RT <bug-MailTools [...] rt.cpan.org>
From:	Mark Overmeer <mark [...] overmeer.net>

* Ricardo Signes via RT (bug-MailTools@rt.cpan.org) [160514 19:43]: Show quoted text

> Sat May 14 15:43:39 2016: Request 114382 was acted upon. > Transaction: Ticket created by RJBS > Queue: MailTools > Subject: Mail::Internet v2.17 breaks Email::Abstract > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=114382 > > > I'm not sure just what's up, but now all the tests end up getting > messages with empty bodies. I haven't changed a thing. v2.16 worked. > > Obvious to you? > http://www.cpantesters.org/cpan/report/9f478190-19d3-11e6-9bf9-817a9220e041

CPAN-testers does not work, at the moment. And I cannot reproduce the error with your latest releases. Someone asked be to handled incorrectly folded headers better. I tried to modernize the parsing of the header a bit, but first broke MIME::Tools regression tests (not applications) and now apparently Email::Abstract. But not on my system. The changes were in Mail::Header::extract() and ::read() Blank lines before the headers? P.S: thanks for the many years of carying the incredible responsibility of Perl Core! -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net

Sun May 15 05:58:58 2016 The RT System itself - Status changed from 'new' to 'open'

Wed May 18 03:53:20 2016 abraxxa [...] cpan.org - Correspondence added

It breaks on my notebook running Xubuntu 16.04 64bit with perlbrewed 5.24.0 -Duselargefiles -Duserelocatableinc -Duse64bitall Ping me on IRC if I can help debugging the issue.

Wed May 18 06:03:56 2016 Mark [...] Overmeer.net - Correspondence added

Subject:	Re: [rt.cpan.org #114382] Mail::Internet v2.17 breaks Email::Abstract
Date:	Wed, 18 May 2016 12:03:42 +0200
To:	Alexander Hartmaier via RT <bug-MailTools [...] rt.cpan.org>
From:	Mark Overmeer <mark [...] overmeer.net>

* Alexander Hartmaier via RT (bug-MailTools@rt.cpan.org) [160518 07:53]: Show quoted text

> Queue: MailTools > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=114382 > > > It breaks on my notebook running Xubuntu 16.04 64bit with perlbrewed > 5.24.0 -Duselargefiles -Duserelocatableinc -Duse64bitall > Ping me on IRC if I can help debugging the issue.

Ok, the cause is clear now: it has to do with \r?\n In 2.14, I changed the accidentally succesful code into /^\s$/ to indicate the end of a header. That broke a regression-test in MIMETools which did not get repaired fast enough, to my feeling. In 2.16, I changed it into /^$/ which is more sensitive on the open mode of the file... in this case, there is a \r in the way. I'll release a fix tonight. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net

Thu May 19 07:39:39 2016 abraxxa [...] cpan.org - Correspondence added

I can confirm that 2.18 fixes the issue, thanks Mark!

Thu May 19 07:39:42 2016 abraxxa [...] cpan.org - Fixed in 2.18 added

Thu Jun 23 21:38:00 2016 rjbs [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #114382] Mail::Internet v2.17 breaks Email::Abstract
Date:	Thu, 23 Jun 2016 21:37:46 -0400
To:	Mark Overmeer via RT <bug-MailTools [...] rt.cpan.org>
From:	Ricardo Signes <rjbs [...] cpan.org>

* Mark Overmeer via RT <bug-MailTools@rt.cpan.org> [2016-05-15T05:58:59] Show quoted text

> P.S: thanks for the many years of carying the incredible responsibility > of Perl Core!

I am pleased that I didn't screw things up too badly! Thanks for all your work, too, and for sorting out this bug. (Sorry it took me a month and a half to reply!) -- rjbs

Download signature.asc
application/pgp-signature 473b

Message body not shown because it is not plain text.

Wed Nov 08 07:08:51 2017 MARKOV [...] cpan.org - Correspondence added

Fixed last May

Wed Nov 08 07:08:52 2017 MARKOV [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Nov 08 07:10:08 2017 MARKOV [...] cpan.org - Correspondence added

Fixed last May