Bug #114296 for Number-Bytes-Human: Patch for bug #97324

Thu Jul 17 18:14:08 2014 martin [...] hinterlands.org - Ticket #97324: Ticket created

Subject:	N::B::H 0.09 handles fractional units incorrectly.
Date:	Thu, 17 Jul 2014 23:13:56 +0100
To:	bug-Number-Bytes-Human [...] rt.cpan.org
From:	"Martin A. Brooks" <martin [...] hinterlands.org>

Hello With N::B::H 0.09 as installed from Ubuntu's package repo: $ perl -e 'use Number::Bytes::Human qw(parse_bytes); print parse_bytes("5 TB")."\n";' 5000000000000 $ perl -e 'use Number::Bytes::Human qw(parse_bytes); print parse_bytes("5.5 TB")."\n";' 5005000000000 $ perl -e 'use Number::Bytes::Human qw(parse_bytes); print parse_bytes("5.500 TB")."\n";' 5500000000000 This is perl 5.18.2, Ubuntu stock. Mart.

Tue Nov 03 15:46:13 2015 PLICEASE [...] cpan.org - Ticket #97324: Cc PLICEASE added

Tue May 10 05:40:39 2016 jes [...] netcraft.com - Ticket created

CC:	ferreira [...] cpan.org, dagobert [...] cpan.org
Subject:	Patch for bug #97324
Date:	Tue, 10 May 2016 10:40:22 +0100
To:	bug-Number-Bytes-Human [...] rt.cpan.org
From:	James Stanley <jes [...] netcraft.com>

Hello, Number::Bytes::Human bug #97324 ( https://rt.cpan.org/Public/Bug/Display.html?id=97324 ) makes parse_bytes behave incorrectly. For example: $ perl -MNumber::Bytes::Human=parse_bytes -e 'print parse_bytes("1G"), "\n"' 1073741824 $ perl -MNumber::Bytes::Human=parse_bytes -e 'print parse_bytes("1.5G"), "\n"' 1078984704 It thinks 1.5G means 1.005G. I've attached a patch to fix this. It also includes a fix for an existing test case and an additional test case. Let me know if you want anything changed. Regards, James Stanley Netcraft Ltd

Message body is not shown because sender requested not to inline it.

Wed May 11 04:53:59 2016 dagobert [...] cpan.org - Correspondence added

Hi James, Am Di 10. Mai 2016, 05:40:39, jes@netcraft.com schrieb: Show quoted text

> Number::Bytes::Human bug #97324 ( > https://rt.cpan.org/Public/Bug/Display.html?id=97324 ) makes parse_bytes > behave incorrectly. > > I've attached a patch to fix this.

I applied the patch and made a new 0.10 release. Additionally, I synced my GitHub repo so a convenient pull request is possible next time: https://github.com/dago/Number-Bytes-Human Thanks for the patch! -- Dago

Wed May 11 04:53:59 2016 The RT System itself - Status changed from 'new' to 'open'

Wed May 11 04:54:00 2016 dagobert [...] cpan.org - Status changed from 'open' to 'patched'

Tue May 17 09:01:09 2016 dagobert [...] cpan.org - Correspondence added

I applied the patch and made a new release 0.10

Tue May 17 09:01:11 2016 dagobert [...] cpan.org - Status changed from 'patched' to 'resolved'

Tue May 17 09:01:12 2016 dagobert [...] cpan.org - Fixed in 0.10 added

Tue May 17 09:02:29 2016 dagobert [...] cpan.org - Ticket #97324: Merged into ticket #114296

Tue May 17 09:02:29 2016 dagobert [...] cpan.org - Merged into ticket #114296

Fri Nov 18 04:01:48 2016 dagobert [...] cpan.org - Reference by ticket #118814 added

Fri Nov 18 04:03:18 2016 dagobert [...] cpan.org - Broken in 0.01 added

Fri Nov 18 04:03:18 2016 dagobert [...] cpan.org - Broken in 0.02 added

Fri Nov 18 04:03:19 2016 dagobert [...] cpan.org - Broken in 0.03 added

Fri Nov 18 04:03:19 2016 dagobert [...] cpan.org - Broken in 0.04 added

Fri Nov 18 04:03:19 2016 dagobert [...] cpan.org - Broken in 0.05 added

Fri Nov 18 04:03:19 2016 dagobert [...] cpan.org - Broken in 0.06 added

Fri Nov 18 04:03:19 2016 dagobert [...] cpan.org - Broken in 0.07 added

Fri Nov 18 04:03:19 2016 dagobert [...] cpan.org - Broken in 0.09 added