Bug #114247 for Module-CPANTS-Analyse: Module::CPANTS::Kwalitee::License doesn't look for LICENSE.txt

Sun May 08 23:35:58 2016 IKEGAMI [...] cpan.org - Ticket created

Subject:

Module::CPANTS::Kwalitee::License doesn't look for LICENSE.txt

CPAN has accepted LICENSE.txt as the license file for as long as I've known about it, but Module::CPANTS::Kwalitee::License does not look for it under that name.

Mon May 09 01:56:58 2016 ether [...] cpan.org - Correspondence added

On 2016-05-08 20:35:58, ikegami wrote: Show quoted text

> CPAN has accepted LICENSE.txt as the license file for as long as I've > known about it, but Module::CPANTS::Kwalitee::License does not look > for it under that name.

Do you know what bit of code looks for that file? It would be helpful to use as a reference to make sure all the variants are covered, as well as documented elsewhere (e.g. any toolchain standards documents still to be written).

Mon May 09 01:56:59 2016 The RT System itself - Status changed from 'new' to 'open'

Mon May 09 04:04:11 2016 ishigaki [...] cpan.org - Correspondence added

On Mon May 09 12:35:58 2016, ikegami wrote: Show quoted text

> CPAN has accepted LICENSE.txt as the license file for as long as I've > known about it, but Module::CPANTS::Kwalitee::License does not look > for it under that name.

Thanks. Fixed in the master: https://github.com/cpants/Module-CPANTS-Analyse/commit/6018f9778c42576041fa46bea35d3a9e19cb3467

Mon May 09 04:04:12 2016 ishigaki [...] cpan.org - Status changed from 'open' to 'patched'

Mon May 09 08:50:23 2016 ikegami [...] adaelis.com - Correspondence added

CC:	IKEGAMI [...] cpan.org
Subject:	Re: [rt.cpan.org #114247] Module::CPANTS::Kwalitee::License doesn't look for LICENSE.txt
Date:	Mon, 9 May 2016 08:50:10 -0400
To:	bug-Module-CPANTS-Analyse [...] rt.cpan.org
From:	Eric Brine <ikegami [...] adaelis.com>

Thanks, but you may want to revert that. I just learned that metacpan is much more strict about which meta files it lists as compared to search.cpan.org. Apparently, it's been hiding distros' README.txt and LICENSE.txt all this time, whereas these were picked up by search.cpan.org. Specifically, I think metacpan only lists the following: AUTHORS Build.PL Changelog ChangeLog CHANGELOG Changes CHANGES CONTRIBUTING CONTRIBUTING.md CONTRIBUTING.pod Copying COPYRIGHT cpanfile CREDITS dist.ini FAQ INSTALL INSTALL.md INSTALL.pod LICENSE Makefile.PL MANIFEST META.json META.yml NEWS README README.md README.pod THANKS Todo ToDo TODO I'm going to put more research into what's actually being used by modules, then propose a fix for metacpan and one for Module::CPANTS::Kwalitee::License. - Eric On Mon, May 9, 2016 at 4:04 AM, Kenichi Ishigaki via RT < bug-Module-CPANTS-Analyse@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=114247 > > > On Mon May 09 12:35:58 2016, ikegami wrote:

> > CPAN has accepted LICENSE.txt as the license file for as long as I've > > known about it, but Module::CPANTS::Kwalitee::License does not look > > for it under that name.

> > Thanks. Fixed in the master: > https://github.com/cpants/Module-CPANTS-Analyse/commit/6018f9778c42576041fa46bea35d3a9e19cb3467 > >

Mon May 09 13:10:11 2016 ether [...] cpan.org - Correspondence added

On 2016-05-09 05:50:23, ikegami@adaelis.com wrote: Show quoted text

> Thanks, but you may want to revert that. > > I just learned that metacpan is much more strict about which meta > files it > lists as compared to search.cpan.org. Apparently, it's been hiding > distros' > README.txt and LICENSE.txt all this time, whereas these were picked up > by > search.cpan.org. > > Specifically, I think metacpan only lists the following: > > ... > CONTRIBUTING.pod > INSTALL.pod > README.pod

metacpan doesn't display pod files in the root now, because those files tend to get installed into the user's PERL5LIB.

Mon May 09 15:20:20 2016 ikegami [...] adaelis.com - Correspondence added

CC:	IKEGAMI [...] cpan.org
Subject:	Re: [rt.cpan.org #114247] Module::CPANTS::Kwalitee::License doesn't look for LICENSE.txt
Date:	Mon, 9 May 2016 15:20:06 -0400
To:	bug-Module-CPANTS-Analyse [...] rt.cpan.org
From:	Eric Brine <ikegami [...] adaelis.com>

Indeed (Example: https://metacpan.org/release/Geo-GeoNames) That list I got from metacpan's source must be for something else. On Mon, May 9, 2016 at 1:10 PM, Karen Etheridge via RT < bug-Module-CPANTS-Analyse@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=114247 > > > On 2016-05-09 05:50:23, ikegami@adaelis.com wrote:

> > Thanks, but you may want to revert that. > > > > I just learned that metacpan is much more strict about which meta > > files it > > lists as compared to search.cpan.org. Apparently, it's been hiding > > distros' > > README.txt and LICENSE.txt all this time, whereas these were picked up > > by > > search.cpan.org. > > > > Specifically, I think metacpan only lists the following: > > > > ... > > CONTRIBUTING.pod > > INSTALL.pod > > README.pod

> > metacpan doesn't display pod files in the root now, because those files > tend to get installed into the user's PERL5LIB. >