Bug #114246 for Archive-Rar: "List" tests fail ( t/40add.t and t/20list.t ) since rar 5.0

Sun May 08 16:31:57 2016 KENTNL [...] cpan.org - Ticket created

Subject:

"List" tests fail ( t/40add.t and t/20list.t )

-------------------
t/20list.t         (Wstat: 65280 Tests: 5 Failed: 1)
Failed test: 5
Non-zero exit status: 255
Parse errors: Bad plan. You planned 53 tests but ran 5.
t/40add.t          (Wstat: 768 Tests: 15 Failed: 3)
Failed tests: 13-15
TODO passed:   7
Non-zero exit status: 3

...

not ok 5 - list structure is an array ref

# Failed test 'list structure is an array ref'
# at t/20list.t line 54.
Can't use an undefined value as an ARRAY reference at t/20list.t line 55.
# Looks like you planned 53 tests but ran 5.
# Looks like you failed 1 test of 5 run.
# Looks like your test exited with 255 just after 5.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 49/53 subtests

...

"rar" "vt" "-y" "/tmp/VjnSdqR81l/add_test.rar"
ok 12 - List(-archive) succeeded
not ok 13 - List structure is defined and array ref and length 1
not ok 14

#   Failed test 'List structure is defined and array ref and length 1'
#   at t/40add.t line 61.

#   Failed test at t/40add.t line 67.
not ok 15

#   Failed test at t/40add.t line 67.
# Looks like you failed 3 tests of 15.
Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/15 subtests

Further inspection suggests the regex you're poking for in the List() call, /^----------/

Never matches.

rar vt -y t/data/test.rar

RAR 5.21   Copyright (c) 1993-2015 Alexander Roshal   15 Feb 2015
Trial version             Type RAR -? for help

Archive: t/data/test.rar
Details: RAR 4

        Name: README
        Type: File
        Size: 890
Packed size: 548
       Ratio: 61%
       mtime: 2008-01-03 12:03,000
Attributes: -rw-r--r--
       CRC32: 6E7ABCFE
     Host OS: Unix
Compression: RAR 3.0(v29) -m3 -md=128K

        Name: COPYRIGHT
        Type: File
        Size: 183
Packed size: 161
       Ratio: 87%
       mtime: 2008-01-03 12:03,000
Attributes: -rw-r--r--
       CRC32: 5CDC2E66
     Host OS: Unix
Compression: RAR 3.0(v29) -m3 -md=128K

Sun May 08 16:56:56 2016 KENTNL [...] cpan.org - Correspondence added

RT-Send-CC:

SREZIC [...] cpan.org

I'm having a hard time working out exactly how to fix this, because the cpan testers panel have quite a raft of passes and "unknowns", but very few "failures", but I seem to get failures repeatedly.

I get failures with both this version of rar:

rar -? | head

RAR 5.21 Copyright (c) 1993-2015 Alexander Roshal 15 Feb 2015
Trial version Type RAR -? for help

And this one:

rar -? | head

RAR 5.30 Copyright (c) 1993-2015 Alexander Roshal 18 Nov 2015
Trial version Type RAR -? for help

But which version SREZIC and friends are using and what their versions of rar emit for the list commands is not obvious from the test output.

I've attached 2 copies of what

> rar vt -y t/data/test.rar

Does in the source tree with my different rar versions for analysis.

I tried tweaking the "Begin properties" marker skimmer, which gets me a little further, but then it computes all the attributes wrong, and I have no idea how its doing it.

Subject:

5.21.txt

RAR 5.21 Copyright (c) 1993-2015 Alexander Roshal 15 Feb 2015 Trial version Type RAR -? for help Archive: t/data/test.rar Details: RAR 4 Name: README Type: File Size: 890 Packed size: 548 Ratio: 61% mtime: 2008-01-03 12:03,000 Attributes: -rw-r--r-- CRC32: 6E7ABCFE Host OS: Unix Compression: RAR 3.0(v29) -m3 -md=128K Name: COPYRIGHT Type: File Size: 183 Packed size: 161 Ratio: 87% mtime: 2008-01-03 12:03,000 Attributes: -rw-r--r-- CRC32: 5CDC2E66 Host OS: Unix Compression: RAR 3.0(v29) -m3 -md=128K

Subject:

5.30.txt

RAR 5.30 Copyright (c) 1993-2015 Alexander Roshal 18 Nov 2015 Trial version Type RAR -? for help Archive: t/data/test.rar Details: RAR 4 Name: README Type: File Size: 890 Packed size: 548 Ratio: 61% mtime: 2008-01-03 12:03:00,000 Attributes: -rw-r--r-- CRC32: 6E7ABCFE Host OS: Unix Compression: RAR 3.0(v29) -m3 -md=128K Name: COPYRIGHT Type: File Size: 183 Packed size: 161 Ratio: 87% mtime: 2008-01-03 12:03:00,000 Attributes: -rw-r--r-- CRC32: 5CDC2E66 Host OS: Unix Compression: RAR 3.0(v29) -m3 -md=128K

Sun May 08 17:14:28 2016 KENTNL [...] cpan.org - Correspondence added

Ugh. I see, the output format changed radically with Rar 5.

Here it is at Rar 4.20.0

Broken as heck :(

Subject:

4.20.txt

RAR 4.20 Copyright (c) 1993-2012 Alexander Roshal 9 Jun 2012 Trial version Type RAR -? for help Archive t/data/test.rar Pathname/Comment Size Packed Ratio Date Time Attr CRC Meth Ver Host OS Solid Old ------------------------------------------------------------------------------- README 890 548 61% 03-01-08 12:03 -rw-r--r-- 6E7ABCFE m3b 2.9 Unix No No COPYRIGHT 183 161 87% 03-01-08 12:03 -rw-r--r-- 5CDC2E66 m3b 2.9 Unix No No ------------------------------------------------------------------------------- 2 1073 709 66%

Sun May 08 17:14:30 2016 KENTNL [...] cpan.org - Subject changed from '"List" tests fail ( t/40add.t and t/20list.t )' to '"List" tests fail ( t/40add.t and t/20list.t ) since rar 5.0'

Sun May 08 17:39:47 2016 KENTNL [...] cpan.org - Reference by https://bugs.gentoo.org/show_bug.cgi?id=483888 added

Mon May 09 01:29:37 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-05-08 16:56:56, KENTNL wrote: Show quoted text

> I'm having a hard time working out exactly how to fix this, because > the cpan > testers panel have quite a raft of passes and "unknowns", but very few > "failures", but I seem to get failures repeatedly. > > I get failures with both this version of rar: > > rar -? | head > > RAR 5.21 Copyright (c) 1993-2015 Alexander Roshal 15 Feb 2015 > Trial version Type RAR -? for help > > And this one: > > rar -? | head > > > RAR 5.30 Copyright (c) 1993-2015 Alexander Roshal 18 Nov 2015 > Trial version Type RAR -? for help > > But which version SREZIC and friends are using and what their versions > of rar > emit for the list commands is not obvious from the test output.

> I've attached 2 copies of what >

> > rar vt -y t/data/test.rar

> > Does in the source tree with my different rar versions for analysis. > > I tried tweaking the "Begin properties" marker skimmer, which gets me > a little > further, but then it computes all the attributes wrong, and I have no > idea how > its doing it.

Mon May 09 01:29:38 2016 The RT System itself - Status changed from 'new' to 'open'

Mon May 09 07:21:01 2016 KENTNL [...] cpan.org - Correspondence added

RT-Send-CC:

SREZIC [...] cpan.org

On 2016-05-09 17:29:37, SREZIC wrote:
> Archive::Rar fails only on my freebsd 9.2 smoker, which has the
> following rar installed:
>
> $ rar -\? | head -2
>
> RAR 5.21 Copyright (c) 1993-2015 Alexander Roshal 15 Feb 2015

Thanks. Can you confirm the smokers that give PASS results have RAR V<5.0?

And if your output of

> rar vt -y t/data/test.rar

Differs from the samples attached, could you attach it ( to help the poor sucker who writes a patch )?

Thanks.

Sun May 15 11:03:53 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-05-09 07:21:01, KENTNL wrote: Show quoted text

> On 2016-05-09 17:29:37, SREZIC wrote:

> > Thanks. Can you confirm the smokers that give PASS results have RAR V<5.0?

Yes. My Debian smokers have only RAR 4.00 beta 3 resp. 4.20. Show quoted text

> > And if your output of >

> > rar vt -y t/data/test.rar

> > Differs from the samples attached, could you attach it ( to help the poor > sucker who writes a patch )? > > Thanks.

Here it is: $ rar vt -y t/data/test.rar RAR 5.30 Copyright (c) 1993-2015 Alexander Roshal 18 Nov 2015 Trial version Type RAR -? for help Archive: t/data/test.rar Details: RAR 4 Name: README Type: File Size: 890 Packed size: 548 Ratio: 61% mtime: 2008-01-03 12:03:00,000 Attributes: -rw-r--r-- CRC32: 6E7ABCFE Host OS: Unix Compression: RAR 3.0(v29) -m3 -md=128K Name: COPYRIGHT Type: File Size: 183 Packed size: 161 Ratio: 87% mtime: 2008-01-03 12:03:00,000 Attributes: -rw-r--r-- CRC32: 5CDC2E66 Host OS: Unix Compression: RAR 3.0(v29) -m3 -md=128K

Sun May 15 11:05:36 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-05-15 11:03:53, SREZIC wrote: Show quoted text

> On 2016-05-09 07:21:01, KENTNL wrote:

> > On 2016-05-09 17:29:37, SREZIC wrote:

> > > Archive::Rar fails only on my freebsd 9.2 smoker, which has the > > > following rar installed: > > > > > > $ rar -\? | head -2 > > > > > > RAR 5.21 Copyright (c) 1993-2015 Alexander Roshal 15 Feb 2015

> > > > Thanks. Can you confirm the smokers that give PASS results have RAR V<5.0?

> > Yes. My Debian smokers have only RAR 4.00 beta 3 resp. 4.20.

> > > > And if your output of > >

> > > rar vt -y t/data/test.rar

> > > > Differs from the samples attached, could you attach it ( to help the poor > > sucker who writes a patch )? > > > > Thanks.

> > Here it is: > > $ rar vt -y t/data/test.rar

[...] (which looks like it is the same as your 5.30 sample)