Skip Menu |

This queue is for tickets about the PathTools CPAN distribution.

Report information
The Basics
Id: 114236
Status: open
Priority: 0/
Queue: PathTools
People
Owner: Nobody in particular
Requestors: 'spro^^*%*^6ut# [...] &$%*c
dolmen [...] cpan.org
MASIUCHI [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 3.62
Fixed in: 3.73

History Show all quoted text
  Sun May 08 06:13:59 2016 MASIUCHI [...] cpan.org - Ticket created
Subject: Cannot install with File::Path@2.06_04 or before.
An error occurs in t/abs2rel.t. Show quoted text
> t/abs2rel..............."make_path" is not exported by the File::Path module > Can't continue after import errors at t/abs2rel.t line 9 > BEGIN failed--compilation aborted at t/abs2rel.t line 9. > t/abs2rel...............dubious > Test returned status 255 (wstat 65280, 0xff00)
My environement: * CentOS 5 * Perl 5.8.8 * File::Path 1.08 File::Path@2.06.04 or before does not have make_path() method. https://metacpan.org/changes/distribution/File-Path I can install this module with the following fix. Show quoted text
> diff --git a/Makefile.PL b/Makefile.PL > index bc40baf..4434f95 100644 > --- a/Makefile.PL > +++ b/Makefile.PL > @@ -19,6 +19,7 @@ WriteMakefile > 'Test' => '0', > # done_testing() is used in dist/Cwd/t/Spec.t > 'Test::More' => 0.88, > + 'File::Path' => '2.06_05', > }, > ($] > 5.011) ? () : ( INSTALLDIRS => 'perl' ), # CPAN sourced versions should now install to site > 'EXE_FILES' => [],
  Tue Jun 14 16:06:50 2016 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Ticket #115332: Ticket created
Subject: [PATCH] Undeclared dependency on File::Path 2.08
See attachment. For make_path you need 2.08.
Subject: open_lz7uFdqH.txt
diff -Nurp PathTools-3.62-CCnCTN-orig/Makefile.PL PathTools-3.62-CCnCTN/Makefile.PL --- PathTools-3.62-CCnCTN-orig/Makefile.PL 2016-01-11 05:33:12.000000000 -0800 +++ PathTools-3.62-CCnCTN/Makefile.PL 2016-06-14 13:03:01.000000000 -0700 @@ -15,6 +15,7 @@ WriteMakefile 'PREREQ_PM' => { 'Carp' => '0', 'File::Basename' => '0', + 'File::Path' => '2.08', # make_path 'Scalar::Util' => '0', 'Test' => '0', # done_testing() is used in dist/Cwd/t/Spec.t diff -Nurp PathTools-3.62-CCnCTN-orig/t/abs2rel.t PathTools-3.62-CCnCTN/t/abs2rel.t --- PathTools-3.62-CCnCTN-orig/t/abs2rel.t 2016-01-11 05:33:12.000000000 -0800 +++ PathTools-3.62-CCnCTN/t/abs2rel.t 2016-06-14 13:03:10.000000000 -0700 @@ -6,7 +6,7 @@ use Test::More; use Cwd qw(cwd getcwd abs_path); use File::Spec(); use File::Temp qw(tempdir); -use File::Path qw(make_path); +use File::Path 2.08 qw(make_path); my $startdir = cwd(); my @files = ( 'anyfile', './anyfile', '../first_sub_dir/anyfile', '../second_sub_dir/second_file' );
  Wed Jul 20 11:44:53 2016 dolmen [...] cpan.org - Requestor DOLMEN added
  Wed Jul 20 11:50:15 2016 dolmen [...] cpan.org - Correspondence added
Le 2016-05-08 12:13:59, MASIUCHI a écrit :
Show quoted text
> An error occurs in t/abs2rel.t.
>
> > t/abs2rel..............."make_path" is not exported by the File::Path
> > module

To the maintainers:

t/abs2rel.t uses function 'make_path' from module File::Path.

But this function has been introduced only with File::Path 2.06_05.
https://metacpan.org/changes/distribution/File-Path#L110

I approve the proposed patch.
I would even submit a pull request if I knew where is the repo, but this is not advertised in the META. :(


-- 
Olivier Mengué - http://perlresume.org/DOLMEN
  Wed Jul 20 11:53:16 2016 dolmen [...] cpan.org - Ticket #115332: Requestor DOLMEN added
  Wed Jul 20 11:54:46 2016 dolmen [...] cpan.org - Ticket #115332: Merged into ticket #114236
  Wed Jul 20 11:54:46 2016 dolmen [...] cpan.org - Merged into ticket #114236
  Thu Jul 21 01:36:00 2016 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Wed Jul 20 11:50:15 2016, DOLMEN wrote: Show quoted text
> Le 2016-05-08 12:13:59, MASIUCHI a écrit :
> > An error occurs in t/abs2rel.t. > >
> > > t/abs2rel..............."make_path" is not exported by the > > > File::Path > > > module
> > To the maintainers: > > t/abs2rel.t uses function 'make_path' from module File::Path. > > But this function has been introduced only with File::Path 2.06_05. > https://metacpan.org/changes/distribution/File-Path#L110 > > I approve the proposed patch. > I would even submit a pull request if I knew where is the repo, but > this is not > advertised in the META. :( > > > -- > Olivier Mengué - http://perlresume.org/DOLMEN
Duh. I had forgotten that the perl core was upstream. I was going to apply it to core, but got a conflict, due to commit v5.23.6-110-g918c39d: commit 918c39d3bee4826bab1ab73c7eddf5c159479390 Author: Ricardo Signes <rjbs@cpan.org> Date: Thu Jan 14 08:17:44 2016 -0500 PathTools: use mkpath instead of make_path in tests make_path doesn't exist until File::Path 2.08, which didn't ship with core until v5.12. Adding a prerequisite on File::Path would put us one step closer to a horrible circular dependency between non-core PathTools and non-core File::Path. This avoids that by using the ancient and adequate mkpath. So it is already fixed and just awaiting a release.
  Thu Jul 21 01:36:01 2016 The RT System itself - Status changed from 'new' to 'open'
  Sat Feb 24 03:10:56 2018 dolmen [...] cpan.org - Correspondence added
RT-Send-CC: XSAWYERX [...] cpan.org
The fix has been released on CPAN with version 3.73 of PathTools.
https://metacpan.org/diff/file?target=XSAWYERX/PathTools-3.73/&amp;source=RJBS%2FPathTools-3.62#t/abs2rel.t

Unfortunately this has not been mentionned in the Changes file.
  Sat Feb 24 03:10:57 2018 dolmen [...] cpan.org - Fixed in 3.73 added
  Sat Feb 24 12:17:58 2018 XSAWYERX [...] cpan.org - Correspondence added
From: XSAWYERX [...] cpan.org
On Sat Feb 24 03:10:56 2018, DOLMEN wrote: Show quoted text
> The fix has been released on CPAN with version 3.73 of PathTools. > https://metacpan.org/diff/file?target=XSAWYERX/PathTools- > 3.73/&source=RJBS%2FPathTools-3.62#t/abs2rel.t > > Unfortunately this has not been mentionned in the Changes file.
My bad. We wanted to make new releases of PathTools so I ran it initially and composed the Changes file entries from the commits I found in blead. Would you like to reflect this change for a new version or to edit the Changes file for the previous version? I would be happy to apply any patch to this effect. We could then resolve the ticket.
  Sat Feb 24 13:15:47 2018 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Sat Feb 24 12:17:58 2018, xsawyerx wrote: Show quoted text
> On Sat Feb 24 03:10:56 2018, DOLMEN wrote:
> > The fix has been released on CPAN with version 3.73 of PathTools. > > https://metacpan.org/diff/file?target=XSAWYERX/PathTools- > > 3.73/&source=RJBS%2FPathTools-3.62#t/abs2rel.t > > > > Unfortunately this has not been mentionned in the Changes file.
> > My bad. > > We wanted to make new releases of PathTools so I ran it initially and > composed the Changes file entries from the commits I found in blead. > > Would you like to reflect this change for a new version or to edit the > Changes file for the previous version? I would be happy to apply any > patch to this effect. > > We could then resolve the ticket.
I’ve added it to the change log in blead commit 6be4176.