Skip Menu |

This queue is for tickets about the XML-LibXML-Simple CPAN distribution.

Report information
The Basics
Id: 114211
Status: resolved
Priority: 0/
Queue: XML-LibXML-Simple
People
Owner: Nobody in particular
Requestors: gregoa [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)
Attachments
signature.asc
spelling.patch

History Show all quoted text
  Fri May 06 12:28:50 2016 gregoa [...] cpan.org - Ticket created
From: gregoa [...] cpan.org
Subject: [PATCH] fix a spelling mistake in the POD
In Debian we are currently applying the following patch to XML-LibXML-Simple. We thought you might be interested in it too. Description: fix a spelling mistake in the POD Origin: vendor Author: gregor herrmann <gregoa@debian.org> Last-Update: 2016-05-06 The patch is tracked in our Git repository at https://anonscm.debian.org/cgit/pkg-perl/packages/libxml-libxml-simple-perl.git/plain/debian/patches/spelling.patch Thanks for considering, gregor herrmann, Debian Perl Group
  Fri May 06 12:28:52 2016 gregoa [...] cpan.org - Correspondence added
Here's the patch.

Message body is not shown because sender requested not to inline it.

  Sun May 08 05:06:33 2016 mark [...] nluug.nl - Correspondence added
Subject: Re: [rt.cpan.org #114211] [PATCH] fix a spelling mistake in the POD
Date: Sun, 8 May 2016 11:06:14 +0200
To: gregor herrmann via RT <bug-XML-LibXML-Simple [...] rt.cpan.org>
From: Mark Overmeer <mark [...] nluug.nl>
* gregor herrmann via RT (bug-XML-LibXML-Simple@rt.cpan.org) [160506 16:29]: Show quoted text
> Queue: XML-LibXML-Simple > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=114211 > > > Description: fix a spelling mistake in the POD > > --- a/lib/XML/LibXML/Simple.pod > +++ b/lib/XML/LibXML/Simple.pod > @@ -156,7 +156,7 @@ > > =item ContentKey => 'keyname' I<# seldom used> > > -When text content is parsed to a hash value, this option let's you specify a > +When text content is parsed to a hash value, this option lets you specify a > name for the hash key to override the default 'content'. So for example: > > XMLin('<opt one="1">Two</opt>', ContentKey => 'text')
It is a correct observation that the 's is wrong, but the replacement is incorrect as well: the s should be removed. Taken. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
  Sun May 08 05:06:33 2016 The RT System itself - Status changed from 'new' to 'open'
  Sun May 08 08:33:55 2016 gregoa [...] debian.org - Correspondence added
Subject: Re: [rt.cpan.org #114211] [PATCH] fix a spelling mistake in the POD
Date: Sun, 8 May 2016 14:33:35 +0200
To: Mark Overmeer via RT <bug-XML-LibXML-Simple [...] rt.cpan.org>
From: gregor herrmann <gregoa [...] debian.org>
On Sun, 08 May 2016 05:06:39 -0400, Mark Overmeer via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=114211 >
Show quoted text
> > -When text content is parsed to a hash value, this option let's you specify a > > +When text content is parsed to a hash value, this option lets you specify a > > name for the hash key to override the default 'content'. So for example:
Show quoted text
> It is a correct observation that the 's is wrong, but the replacement is > incorrect as well: the s should be removed. Taken.
Maybe I'm not awake enough but I would keep the -s. To me this looks like a necessary third person singular -s, as in "I walk, Mark walks", and equally "the option lets you". (The problem IMO was just the apostrophe: "let's" as a conrtaction of "let us", as in "let's fix all typos!".) Cheers, gregor -- .''`. Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Davy Graham: Buhaina Chant
Download signature.asc
application/pgp-signature 949b

Message body not shown because it is not plain text.

  Sun May 15 06:10:22 2016 Mark [...] Overmeer.net - Correspondence added
Subject: Re: [rt.cpan.org #114211] [PATCH] fix a spelling mistake in the POD
Date: Sun, 15 May 2016 12:10:09 +0200
To: gregor herrmann via RT <bug-XML-LibXML-Simple [...] rt.cpan.org>
From: Mark Overmeer <mark [...] overmeer.net>
* gregor herrmann via RT (bug-XML-LibXML-Simple@rt.cpan.org) [160508 12:34]: Show quoted text
> > It is a correct observation that the 's is wrong, but the replacement is > > incorrect as well: the s should be removed. Taken.
> > Maybe I'm not awake enough but I would keep the -s. To me this looks > like a necessary third person singular -s, as in "I walk, Mark > walks", and equally "the option lets you".
For unknown reason, this does not sound right... but you are correct using the language rules. I have added the 's'. Thanks for teaching me ;-) Show quoted text
> (The problem IMO was just the apostrophe: "let's" as a conrtaction of > "let us", as in "let's fix all typos!".)
For me, this is cut-n-paste text, taken from XML::Simple. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
  Sun May 15 11:28:00 2016 gregoa [...] debian.org - Correspondence added
Subject: Re: [rt.cpan.org #114211] [PATCH] fix a spelling mistake in the POD
Date: Sun, 15 May 2016 17:27:43 +0200
To: Mark Overmeer via RT <bug-XML-LibXML-Simple [...] rt.cpan.org>
From: gregor herrmann <gregoa [...] debian.org>
On Sun, 15 May 2016 06:10:28 -0400, Mark Overmeer via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=114211 > >
> > > It is a correct observation that the 's is wrong, but the replacement is > > > incorrect as well: the s should be removed. Taken.
> > > > Maybe I'm not awake enough but I would keep the -s. To me this looks > > like a necessary third person singular -s, as in "I walk, Mark > > walks", and equally "the option lets you".
> > For unknown reason, this does not sound right... but you are correct > using the language rules. I have added the 's'. Thanks for teaching me ;-)
Thanks for adding the 's'. And don't worry, I was recently confused about let/lets/let's as well :) Cheers, gregor -- .''`. Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Page&Plant: Sons Of Freedom
Download signature.asc
application/pgp-signature 949b

Message body not shown because it is not plain text.

  Wed Nov 08 04:36:10 2017 MARKOV [...] cpan.org - Correspondence added
Included in 0.98
  Wed Nov 08 04:36:11 2017 MARKOV [...] cpan.org - Status changed from 'open' to 'resolved'