Bug #114200 for JIRA-REST: Looks like Test::Kwalitee is missing from build requirements in Makefile.PL

Thu May 05 20:32:10 2016 grant.grueninger [...] gmail.com - Ticket created

Subject:	Looks like Test::Kwalitee is missing from build requirements in Makefile.PL
Date:	Thu, 05 May 2016 19:31:46 -0500
To:	bug-JIRA-REST [...] rt.cpan.org
From:	"Grant Grueninger" <grant.grueninger [...] gmail.com>

Hi Gustavo, Just installed JIRA::REST and the install failed on the first pass saying that "Test::Kwalitee" wasn't installed. Looks like it's used in t/release-kwalitee.t. And, looks like it's not in Makefile.PL: "TEST_REQUIRES" => { "Test::More" => 0, "lib" => 0 }, Thanks! Grant

Fri May 06 02:05:13 2016 ether [...] cpan.org - Correspondence added

On 2016-05-05 17:32:10, grant.grueninger@gmail.com wrote: Show quoted text

> Hi Gustavo, > > Just installed JIRA::REST and the install failed on the first pass > saying that "Test::Kwalitee" wasn't installed. Looks like it's used in > t/release-kwalitee.t. > > And, looks like it's not in Makefile.PL: > > "TEST_REQUIRES" => { > "Test::More" => 0, > "lib" => 0 > },

Please don't allow pod, critic or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, both of which cannot be predicted in advance. Either move them to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Fri May 06 02:05:13 2016 The RT System itself - Status changed from 'new' to 'open'

Fri Jan 06 19:12:25 2017 GNUSTAVO [...] cpan.org - Taken

Fri Jan 06 19:25:39 2017 GNUSTAVO [...] cpan.org - Correspondence added

On Thu May 05 20:32:10 2016, grant.grueninger@gmail.com wrote: Show quoted text

> Hi Gustavo, > > Just installed JIRA::REST and the install failed on the first pass > saying that "Test::Kwalitee" wasn't installed. Looks like it's used in > t/release-kwalitee.t. > > And, looks like it's not in Makefile.PL: > > "TEST_REQUIRES" => { > "Test::More" => 0, > "lib" => 0 > },

Yes but t/release-kwalitee.t run only during a release testing. Users that install this module should not have a problem because they won't use this test. I just performed a "make test" for the latest version making sure I don't have Test::Kwalitee installed and it seems ok. Look: Show quoted text

> $ make test > PERL_DL_NONLAZY=1 "/home/gustavo/.plenv/versions/5.22.0/bin/perl5.22.0" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > t/00-load.t .............. ok > t/01-atlassian.t ......... skipped: these tests are for release testing > t/author-pod-coverage.t .. skipped: these tests are for testing by the author > t/author-pod-syntax.t .... skipped: these tests are for testing by the author > t/release-kwalitee.t ..... skipped: these tests are for release candidate testing > All tests successful. > Files=5, Tests=1, 1 wallclock secs ( 0.04 usr 0.00 sys + 0.29 cusr 0.02 csys = 0.35 CPU) > Result: PASS

Do you see anything different?

Fri Jan 06 19:27:03 2017 GNUSTAVO [...] cpan.org - Correspondence added

On Fri May 06 02:05:13 2016, ETHER wrote: Show quoted text

> > Please don't allow pod, critic or kwalitee tests to run for normal > user installs, as they make the installation fail unnecessarily when > newer versions of the tester module introduces errors that you cannot > anticipate. Also spelling tests are dependent on what dictionaries are > installed locally, and critic tests use all plugins that are > installed, both of which cannot be predicted in advance. > > Either move them to xt/, or guard them with: > > plan skip_all => "These tests are for authors only!" unless > $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

They are already guarded. At least in the latest version. Look: Show quoted text

> $ make test > PERL_DL_NONLAZY=1 "/home/gustavo/.plenv/versions/5.22.0/bin/perl5.22.0" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > t/00-load.t .............. ok > t/01-atlassian.t ......... skipped: these tests are for release testing > t/author-pod-coverage.t .. skipped: these tests are for testing by the author > t/author-pod-syntax.t .... skipped: these tests are for testing by the author > t/release-kwalitee.t ..... skipped: these tests are for release candidate testing > All tests successful. > Files=5, Tests=1, 1 wallclock secs ( 0.04 usr 0.00 sys + 0.29 cusr 0.02 csys = 0.35 CPU) > Result: PASS

Do you see anything different?

Tue Jan 10 15:30:55 2017 grant.grueninger [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #114200] Looks like Test::Kwalitee is missing from build requirements in Makefile.PL
Date:	Tue, 10 Jan 2017 12:30:37 -0800
To:	bug-jira-rest [...] rt.cpan.org
From:	Grant Grueninger <grant.grueninger [...] gmail.com>

Ha, I have a "RELEASE_TESTING" environment variable set so that tests run on one of my projects. Evidently it triggered your release tests too when I ran the install. I've turned off my variable (better to just have it on when I'm running a release anyway). That *should* resolve this issue. Thanks! Grant -- Grant Grueninger On January 6, 2017 at 6:27:39 PM, Gustavo Leite de Mendonça Chaves via RT ( bug-jira-rest@rt.cpan.org) wrote: <URL: https://rt.cpan.org/Ticket/Display.html?id=114200 > On Fri May 06 02:05:13 2016, ETHER wrote: Show quoted text

> > Please don't allow pod, critic or kwalitee tests to run for normal > user installs, as they make the installation fail unnecessarily when > newer versions of the tester module introduces errors that you cannot > anticipate. Also spelling tests are dependent on what dictionaries are > installed locally, and critic tests use all plugins that are > installed, both of which cannot be predicted in advance. > > Either move them to xt/, or guard them with: > > plan skip_all => "These tests are for authors only!" unless > $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

They are already guarded. At least in the latest version. Look: Show quoted text

> $ make test > PERL_DL_NONLAZY=1 "/home/gustavo/.plenv/versions/5.22.0/bin/perl5.22.0"

"-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t Show quoted text

> t/00-load.t .............. ok > t/01-atlassian.t ......... skipped: these tests are for release testing > t/author-pod-coverage.t .. skipped: these tests are for testing by the

author Show quoted text

> t/author-pod-syntax.t .... skipped: these tests are for testing by the

author Show quoted text

> t/release-kwalitee.t ..... skipped: these tests are for release candidate

testing Show quoted text

> All tests successful. > Files=5, Tests=1, 1 wallclock secs ( 0.04 usr 0.00 sys + 0.29 cusr 0.02

csys = 0.35 CPU) Show quoted text

> Result: PASS

Do you see anything different?

Wed Jan 11 06:27:55 2017 GNUSTAVO [...] cpan.org - Correspondence added

On Tue Jan 10 15:30:55 2017, grant.grueninger@gmail.com wrote: Show quoted text

> Ha, I have a "RELEASE_TESTING" environment variable set so that tests run > on one of my projects. Evidently it triggered your release tests too when > I ran the install. I've turned off my variable (better to just have it on > when I'm running a release anyway). That *should* resolve this issue.

Haha. It happens! Thanks!

Wed Jan 11 06:28:28 2017 GNUSTAVO [...] cpan.org - Status changed from 'open' to 'resolved'