Skip Menu |

This queue is for tickets about the Crypt-U2F-Server CPAN distribution.

Report information
The Basics
Id: 114198
Status: resolved
Worked: 5 min
Priority: 0/
Queue: Crypt-U2F-Server
People
Owner: cavac [...] cavac.at
Requestors: ROBN [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.31
Fixed in: (no value)

History Show all quoted text
  Thu May 05 18:22:43 2016 ROBN [...] cpan.org - Ticket created
Subject: [PATCH] allow install on 5.8.8+
Makefile and Perl modules declare 5.18.1 as their minimum requirement, but the module builds and tests pass back to 5.8.8, so here's a patch that adjusts the version declarations. (actually, if you change the tests to use JSON instead of JSON::XS, the tests pass on 5.6.2 as well. I can send a trivial patch for that too, if you want, but seriously, 5.6!) Cheers, Rob N.
Subject: 0001-Minimum-requirement-is-5.8.8.patch
diff --git a/Makefile.PL b/Makefile.PL index 77f02b2..71610c2 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -1,4 +1,4 @@ -use 5.018001; +use 5.008008; use ExtUtils::MakeMaker; # See lib/ExtUtils/MakeMaker.pm for details of how to influence # the contents of the Makefile that is written. diff --git a/lib/Crypt/U2F/Server.pm b/lib/Crypt/U2F/Server.pm index 95c9a2c..f0863b8 100644 --- a/lib/Crypt/U2F/Server.pm +++ b/lib/Crypt/U2F/Server.pm @@ -1,6 +1,6 @@ package Crypt::U2F::Server; -use 5.018001; +use 5.008008; use strict; use warnings; use Carp; diff --git a/lib/Crypt/U2F/Server/Simple.pm b/lib/Crypt/U2F/Server/Simple.pm index 8566cce..0d3882b 100644 --- a/lib/Crypt/U2F/Server/Simple.pm +++ b/lib/Crypt/U2F/Server/Simple.pm @@ -1,6 +1,6 @@ package Crypt::U2F::Server::Simple; -use 5.018001; +use 5.008008; use strict; use warnings; use Carp;
  Sat May 07 08:39:34 2016 cavac [...] cavac.at - Correspondence added 5 min
On Thu May 05 18:22:43 2016, ROBN wrote: Show quoted text
> Makefile and Perl modules declare 5.18.1 as their minimum requirement, > but the module builds and tests pass back to 5.8.8, so here's a patch > that adjusts the version declarations.
Added the patch in Version 0.40, just uploaded to PAUSE. Show quoted text
> (actually, if you change the tests to use JSON instead of JSON::XS, > the tests pass on 5.6.2 as well. I can send a trivial patch for that > too, if you want, but seriously, 5.6!)
I'll take that patch as well (please open a new ticket for that one). Nothing personal, just to say it for a later told-you-so, here's my personal opinion: Running presumed-secure services on a 8+ year old version of Perl (which also assumes an operating system of the same age) is completely wacko and should be discouraged. Very loudly and - where allowed by law - with a swift kick up the seating arragnement.
  Sat May 07 08:39:35 2016 The RT System itself - Status changed from 'new' to 'open'
  Sat May 07 08:39:36 2016 cavac [...] cavac.at - Status changed from 'open' to 'patched'
  Sat May 07 08:39:36 2016 cavac [...] cavac.at - Taken
  Sat May 07 08:40:10 2016 cavac [...] cavac.at - Status changed from 'patched' to 'resolved'
  Sat May 07 08:46:58 2016 rob [...] eatenbyagrue.org - Correspondence added
Subject: Re: [rt.cpan.org #114198] [PATCH] allow install on 5.8.8+
Date: Sat, 07 May 2016 22:46:42 +1000
To: Rene Schickbauer via RT <bug-Crypt-U2F-Server [...] rt.cpan.org>, ROBN [...] cpan.org
From: Rob N ★ <rob [...] eatenbyagrue.org>
On Sat, May 7, 2016, at 10:39 PM, Rene Schickbauer via RT wrote: Show quoted text
> Added the patch in Version 0.40, just uploaded to PAUSE.
Thank you! Show quoted text
> I'll take that patch as well (please open a new ticket for that one).
Sure, I'll do one as soon as I can. Show quoted text
> Nothing personal, just to say it for a later told-you-so, here's my > personal opinion: Running presumed-secure services on a 8+ year old > version of Perl (which also assumes an operating system of the same age) > is completely wacko and should be discouraged. Very loudly and - where > allowed by law - with a swift kick up the seating arragnement.
Actually I'm on 5.14.2, on a heavily-customised and modernised Debian 7. I just happened to test back to 5.6 for a lark. Your point, however, is well made :)