Skip Menu |

This queue is for tickets about the Gtk3 CPAN distribution.

Report information
The Basics
Id: 114162
Status: resolved
Priority: 0/
Queue: Gtk3

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.026
Fixed in: (no value)



Subject: t/overrides.t fails with gtk3-3.21.1
After upgrading gtk3 from 3.20.3 to 3.21.1, the t/overrides.t fails like this: t/floating-refs.t .............. ok (overrides.t:2291): Gtk-WARNING **: Theme parsing error: <data>:1:30: Using Pango syntax for the font: style property is deprecated; please use CSS syntax <data>:1:17not a number at /builddir/build/BUILD/Gtk3-0.026/blib/lib/Gtk3.pm line 958. # Looks like you planned 212 tests but ran 23. # Looks like your test exited with 255 just after 23. t/overrides.t .................. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 189/212 subtests If I comment out load_from_data() calls in the t/overrides.t, the test does not terminate prematurely. It looks like newer Gtk does not understand the "GtkButton {font: Cantarelll 10}" CSS text.
From: ppisar [...] redhat.com
Dne St 04.Květen.2016 08:40:38, ppisar napsal(a): Show quoted text
> After upgrading gtk3 from 3.20.3 to 3.21.1, the t/overrides.t fails
Attached patch fixes the test.
Subject: Gtk3-0.026-Fix-Pango-font-syntax.patch
From e2bb149ce9a14a43f6cc58e5664b8cbaac53278b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Thu, 5 May 2016 11:22:39 +0200 Subject: [PATCH] Fix Pango font syntax MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since gtk3-3.21.1, t/overrides.t fails because of old Pango CSS syntax: (overrides.t:2291): Gtk-WARNING **: Theme parsing error: <data>:1:30: Using Pango syntax for the font: style property is deprecated; please use CSS syntax <data>:1:17not a number at /builddir/build/BUILD/Gtk3-0.026/blib/lib/Gtk3.pm line 958. CPAN RT#114162 Signed-off-by: Petr Písař <ppisar@redhat.com> --- t/overrides.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/overrides.t b/t/overrides.t index 0488692..fa42f88 100644 --- a/t/overrides.t +++ b/t/overrides.t @@ -101,7 +101,7 @@ SKIP: { unless Gtk3::CHECK_VERSION (3, 2, 0); note('Gtk3::CssProvider'); - my $css = "GtkButton {font: Cantarelll 10}"; + my $css = "GtkButton {font-family: Cantarelll; font-size: 10pt}"; my $expect = qr/Cantarelll/; my $p = Gtk3::CssProvider->new; -- 2.5.5
On Thu May 05 06:27:44 2016, ppisar wrote: Show quoted text
> Dne St 04.Květen.2016 08:40:38, ppisar napsal(a):
> > After upgrading gtk3 from 3.20.3 to 3.21.1, the t/overrides.t fails
> > Attached patch fixes the test.
A different but similar fix went in with <https://gitlab.gnome.org/GNOME/perl-gtk3/commit/97095cfb8155c653fc023c1d3e5411b1e4c67b47>. If this did not fix the problem for you, please reopen this issue.