Bug #113846 for Pod-Checker: 1.71 broke core t/porting/podcheck.t

Sun Apr 17 04:46:13 2016 RURBAN [...] cpan.org - Ticket created

Subject:

1.71 broke core t/porting/podcheck.t

core still has to use 1.60. one part is the removal of use Pod::ParseUtils, but this is easily addable to t/porting/podcheck.t the wrong part is the missing @INC for use parent 'Pod::Checker'; which cannot resolve $self->SUPER::parse_from_filehandle in parse_from_file anymore. -- Reini Urban

Sun Apr 17 05:17:18 2016 RURBAN [...] cpan.org - Correspondence added

On Sun Apr 17 04:46:13 2016, RURBAN wrote: Show quoted text

> core still has to use 1.60. > one part is the removal of use Pod::ParseUtils, but this is easily > addable to t/porting/podcheck.t > > the wrong part is the missing @INC for > use parent 'Pod::Checker'; > which cannot resolve $self->SUPER::parse_from_filehandle in > parse_from_file anymore.

Oops, missing push @ISA, qw(Pod::Parser), not @INC. Mixed it up. -- Reini Urban

Sun Apr 17 19:57:22 2016 rjbs [...] cpan.org - Correspondence added

This change was made as part of making it possible to remove Pod::Parser from core. It was not a mistake, but intentional. The next step is for the Pod::Checker subclass in perl5.git to be made compatible with the innards-changes in Pod::Checker. This is being done and should land early in v5.25. -- rjbs

Sun Apr 17 19:57:23 2016 The RT System itself - Status changed from 'new' to 'open'

Mon May 23 15:52:01 2016 Marek.Rouchal [...] gmx.net - Taken

Mon May 23 15:54:40 2016 Marek.Rouchal [...] gmx.net - Correspondence added 10 min

RT-Send-CC:

rjbs [...] cpan.org, khw [...] cpan.org

I applied a bunch of patches and other updates on 1.71, going to go into 1.72 soon. That should help to restore the downstream compatibility. Please use this ticket to track further issues in this regard. Marek

Mon May 23 17:02:54 2016 khw [...] cpan.org - Correspondence added

CC:	rjbs [...] cpan.org
Subject:	Re: [rt.cpan.org #113846] 1.71 broke core t/porting/podcheck.t
Date:	Mon, 23 May 2016 15:02:43 -0600
To:	bug-Pod-Checker [...] rt.cpan.org
From:	Karl Williamson <khw [...] cpan.org>

On 05/23/2016 01:54 PM, Marek Rouchal via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=113846 > > > I applied a bunch of patches and other updates on 1.71, going to go into 1.72 soon. > That should help to restore the downstream compatibility. Please use this ticket to track further issues in this regard. > > Marek >

I perhaps should have mentioned that rjbs reviewed three of the patches and caught a few things which I fixed before I sent them on to you, those being X<0> is not an empty X<> Don't warn if an =item has only verbatim text Reinstate hyperlink method One thing he caught that I didn't change, but you probably should, is that there is an extraneous use Data::Dumper. (I didn't change it so as to remind me that I should file a parser bug report, because it is missing a trailing semi-colon, and so is illegal, and now it has reminded me to do so, but not until after I sent them to you :) )

Tue May 24 00:02:11 2016 public [...] khwilliamson.com - Correspondence added

CC:	rjbs [...] cpan.org
Subject:	Re: [rt.cpan.org #113846] 1.71 broke core t/porting/podcheck.t
Date:	Mon, 23 May 2016 22:01:47 -0600
To:	bug-Pod-Checker [...] rt.cpan.org
From:	Karl Williamson <public [...] khwilliamson.com>

On 05/23/2016 03:02 PM, Karl Williamson wrote: Show quoted text

> On 05/23/2016 01:54 PM, Marek Rouchal via RT wrote:

>> <URL: https://rt.cpan.org/Ticket/Display.html?id=113846 > >> >> I applied a bunch of patches and other updates on 1.71, going to go >> into 1.72 soon. >> That should help to restore the downstream compatibility. Please use >> this ticket to track further issues in this regard. >> >> Marek >>

> > I perhaps should have mentioned that rjbs reviewed three of the patches > and caught a few things which I fixed before I sent them on to you, > those being > X<0> is not an empty X<> > Don't warn if an =item has only verbatim text > Reinstate hyperlink method > > One thing he caught that I didn't change, but you probably should, is > that there is an extraneous use Data::Dumper. (I didn't change it so as > to remind me that I should file a parser bug report, because it is > missing a trailing semi-colon, and so is illegal, and now it has > reminded me to do so, but not until after I sent them to you :) ) >

It's not considered a bug unfortunately, but the next statement, an our $VERSION = ...; gets absorbed into the DataDumper line, so that $VERSION is not actually declared, and you get an error if you try to use its value.

Fri May 27 13:54:10 2016 khw [...] cpan.org - Correspondence added

From:

khw [...] cpan.org

With commit 4f358de1e9bf7105dab7157d4cbbf73d0ec61f74 in blead, podcheck.t now works with Pod::Checker 1.72. This ticket has now been fixed and can be closed.

Tue May 31 07:48:05 2016 Marek.Rouchal [...] gmx.net - Correspondence added 15 min

RT-Send-CC:

rjbs [...] cpan.org, khw [...] cpan.org

Fixed the spurious "use Data::Dumper" (without semicolon) in this context, released as 1.73.

Tue May 31 07:48:15 2016 Marek.Rouchal [...] gmx.net - Status changed from 'open' to 'resolved'

Tue May 31 07:48:16 2016 Marek.Rouchal [...] gmx.net - Fixed in 1.73 added