Bug #113704 for Moose: Single test fails on < 5.10 when Class::C3::XS is not available

Tue Apr 12 09:08:12 2016 ribasushi [...] leporine.io - Ticket created

Subject:

Single test fails on < 5.10 when Class::C3::XS is not available - suggesting a hard-skip

The following fails reliably on any 5.8.x: PERL5OPT="-MDevel::Hide=Class::C3::XS" prove -b t/cmop/methods.t Given Moose is dynamic_requires => 0, it is a no-go to hard-require C::C3::XS on older perls. I suggest just skipping the test in this scenario (it seems to not affect any Moose consuming code I tested on this configuration). This was uncovered during https://github.com/dbsrgits/dbix-class/commit/179566f3, with the chain of events being: - https://github.com/dbsrgits/dbix-class/blob/179566f3/maint/travis-ci_scripts/30_before_script.bash#L59 - Install MRO::Compat, pulling in Class::C3 with no ::XS, as it is optional - Run tests - https://github.com/dbsrgits/dbix-class/blob/179566f3/maint/travis-ci_scripts/50_after_success.bash#L15 - Install Moose as part of the post-test curiculum

Tue Apr 12 18:09:52 2016 ether [...] cpan.org - Correspondence added

I created https://rt.cpan.org/Ticket/Display.html?id=113722. This will go out in Moose-2.1703-TRIAL, to be released before the end of April. If you need this right away let me know and I'll fork off a stable release.

Tue Apr 12 18:09:53 2016 The RT System itself - Status changed from 'new' to 'open'

Tue Apr 12 18:10:25 2016 ether [...] cpan.org - Correspondence added

On 2016-04-12 15:09:52, ETHER wrote: Show quoted text

> I created https://rt.cpan.org/Ticket/Display.html?id=113722. > > This will go out in Moose-2.1703-TRIAL, to be released before the end > of April. If you need this right away let me know and I'll fork off a > stable release.

Correction, 2.17xx will *go stable* before the end of April. The actual trial release will probably be later today.

Tue Apr 12 19:44:24 2016 ether [...] cpan.org - Correspondence added

released as Moose-2.1703-TRIAL.

Tue Apr 12 19:44:25 2016 ether [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Apr 13 05:31:59 2016 haarg [...] haarg.org - Correspondence added

This was a real issue, so skipping the test was the wrong solution. I've filed a PR with a fix at https://github.com/moose/Moose/pull/122, including a test case that failed on modern perls.

Wed Apr 13 05:32:07 2016 haarg [...] haarg.org - Status changed from 'resolved' to 'open'

Wed Apr 13 13:58:43 2016 ether [...] cpan.org - Correspondence added

This has been merged and released as 2.1704-TRIAL. thanks!

Wed Apr 13 13:58:45 2016 ether [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Apr 14 13:55:13 2016 ether [...] cpan.org - Fixed in 2.1704-TRIAL added

Bug #113704 for Moose: Single test fails on < 5.10 when Class::C3::XS is not available - suggesting a hard-skip