Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-Reporter CPAN distribution.

Report information
The Basics
Id: 11370
Status: resolved
Worked: 5 min
Priority: 0/
Queue: Test-Reporter

People
Owner: FOX [...] cpan.org
Requestors: claco [...] chrislaco.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.27
Fixed in: (no value)



Subject: _send_smtp does no mx lookups; @_mx is out of date
Last night I installed CPANPLUS 0.051 and upgraded Test::Reporter to 1.27 to fix it's win32 MAil::Send issues. Test reports were being sent out, but never delivered to the cpan-testers list. After further investigation, I think I've found the problem. _send_smtp simply uses the server entries in @_mx to send the @perl.org email to. The first entry is out of date: mx1.x.perlorg(64.81.84.115), also known as one.develooper.com is no longer an MX for perl.org. A quick fix would be to update @_mx to current mx records for perl.org. A more correct way would probably be to have _sned_smtp actually use _get_mx('perl.org') instead. The root of the problem I think is: for my $server (@{$self->{_mx}}) { $smtp = Net::SMTP->new($server, Hello => $helo, Timeout => $self->{_timeout}, Debug => $debug); if (defined $smtp) { $mx = $server; last; } $fail++; }
From: claco [...] chrislaco.com
[CLACO - Thu Feb 3 16:05:46 2005]: Show quoted text
> Last night I installed CPANPLUS 0.051 and upgraded Test::Reporter to > 1.27 to fix it's win32 MAil::Send issues. > > Test reports were being sent out, but never delivered to the cpan- > testers list. After further investigation, I think I've found the > problem. > > _send_smtp simply uses the server entries in @_mx to send the > @perl.org email to. The first entry is out of date: > mx1.x.perlorg(64.81.84.115), also known as one.develooper.com is no > longer an MX for perl.org. > > A quick fix would be to update @_mx to current mx records for > perl.org. > > A more correct way would probably be to have _sned_smtp actually use > _get_mx('perl.org') instead. > > The root of the problem I think is: > > for my $server (@{$self->{_mx}}) { > $smtp = Net::SMTP->new($server, Hello => $helo, > Timeout => $self->{_timeout}, Debug => $debug); > > if (defined $smtp) { > $mx = $server; > last; > } > > $fail++; > } >
Ahhh, I see what's happening a little clearer. $self->_get_mx if _have_net_dns is failing during new since Net::DNS is not installed. Then T::R falls back on the raw MX. So _send_smtp would do the right thing if I install Net::DNS. In that case, we should just update the @_mx entries.
I've updated the MX list per your suggestion; thanks! Will release it soon. - R. [CLACO - Thu Feb 3 16:05:46 2005]: Show quoted text
> Last night I installed CPANPLUS 0.051 and upgraded Test::Reporter to > 1.27 to fix it's win32 MAil::Send issues. > > Test reports were being sent out, but never delivered to the cpan- > testers list. After further investigation, I think I've found the > problem. > > _send_smtp simply uses the server entries in @_mx to send the > @perl.org email to. The first entry is out of date: > mx1.x.perlorg(64.81.84.115), also known as one.develooper.com is no > longer an MX for perl.org. > > A quick fix would be to update @_mx to current mx records for > perl.org. > > A more correct way would probably be to have _sned_smtp actually use > _get_mx('perl.org') instead. > > The root of the problem I think is: > > for my $server (@{$self->{_mx}}) { > $smtp = Net::SMTP->new($server, Hello => $helo, > Timeout => $self->{_timeout}, Debug => $debug); > > if (defined $smtp) { > $mx = $server; > last; > } > > $fail++; > } >
Thanks for the report. The MX for perl.org will be updated in 1.28