Skip Menu |

This queue is for tickets about the Catalyst-Runtime CPAN distribution.

Report information
The Basics
Id: 113603
Status: resolved
Priority: 0/
Queue: Catalyst-Runtime

People
Owner: Nobody in particular
Requestors: wolfsage [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 5.90105



Catalyst::Response warns a little too aggressively? In Catalyst::Response we have: before [qw(status headers content_encoding content_length content_type header)] => sub { my $self = shift; $self->_context->log->warn( "Useless setting a header value after finalize_headers and the response callback has been called." . " Not what you want." ) if ( $self->_context && $self->finalized_headers && !$self->_has_response_cb && @_ ); }; But that warns even if you're just examining something like: my $sent = $res->header->("Some-Header"); Shouldn't that only warn if actually modifying some data? Thanks, -- Matthew Horsfall (alh)
This should be fixed as of 5.90105, released earlier today
On Wed Jun 08 16:30:29 2016, JJNAPIORK wrote: Show quoted text
> This should be fixed as of 5.90105, released earlier today
+1 It appears to me that fixed it. Thanks John! :)