Bug #113294 for Scalar-List-Utils: uniq() implementation breaks LMU test

Wed Mar 23 12:55:46 2016 leonerd-cpan [...] leonerd.org.uk - Ticket created

Subject:

uniq() implementation breaks LMU test

(copied from https://github.com/Scalar-List-Utils/Scalar-List-Utils/pull/28) @leonerd The implementation of uniq() as present in the latest devel 1.44_001 fails a test in this PR: # Failed test 'none of the numbers in the array were stringified by uniq' # at t/uniq.t line 44. # Failed test 'uniq uniquifies mixed numbers and strings correctly in a tied array' # at t/uniq.t line 58. # Structures begin differing at: # $got->[1] = Does not exist # $expected->[1] = '2'

Wed Mar 23 12:56:12 2016 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Hmmm.. Hard to say what's the best thing to do with those failures. The first of them (about not stringifying) tests the very fragile property of the SvPOK flag on elements of the input list. That flag is an internal-representation detail and I don't feel is the sort of thing worth worrying about. For example, simply interpolating elements into an array to print it would side-effect that flag on (think print STDERR "Debug: values are <@values>\n"; ) The tied array test looks potentially interesting though. Perhaps some missing magic calls in my implementation. I'll take a look. -- Paul Evans

Wed Mar 23 13:55:58 2016 leonerd-cpan [...] leonerd.org.uk - Correspondence added

On Wed Mar 23 12:56:12 2016, PEVANS wrote: Show quoted text

> The tied array test looks potentially interesting though. Perhaps some > missing magic calls in my implementation. I'll take a look.

Indeed so. And now fixed https://github.com/Scalar-List-Utils/Scalar-List-Utils/commit/6e915c0c2964c97eee10aa490d9c4c7f79975a51 and a similar trick also fixes the 1.44 documented "issue" of multiple GET magics for uniqnum() https://github.com/Scalar-List-Utils/Scalar-List-Utils/commit/fad9db1ff098a6cf44c055c8b4b23a96ca8c509a I'll call this 1.44_002 and if that pleases the court that can become 1.45 -- Paul Evans

Wed Mar 23 13:56:00 2016 leonerd-cpan [...] leonerd.org.uk - Status changed from 'new' to 'patched'

Sat Mar 26 08:12:48 2016 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Released in 1.45 -- Paul Evans

Sat Mar 26 08:12:49 2016 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'

Sat Mar 26 08:12:50 2016 leonerd-cpan [...] leonerd.org.uk - Fixed in 1.45 added