Bug #113275 for Log-Dispatch-File-Stamped: efficiency improvement -- cache the localtime() result to filename

Tue Mar 22 14:55:06 2016 ether [...] cpan.org - Ticket created

Subject:

efficiency improvement -- cache the localtime() result to filename

We make a system call to strftime on every log line, and only cache the resulting timestamp -> filename. We can do the caching step one step earlier -- if the localtime() result is the same, we don't need to call strftime. This needs to be done in addition to the existing caching, as the localtime() could be different but the resulting timestamp still be the same, e.g. if the timestamp only contains the date and not the time.

Tue Mar 22 14:56:07 2016 ether [...] cpan.org - Correspondence added

Tue Mar 22 15:20:47 2016 FRACTAL [...] cpan.org - Correspondence added

Thanks. Actually the issue is not the system call. In all cases a time or gettimeofday system call needs to be made, but this is not expensive (in fact, on linux it's not even a system call since both of these can be fulfilled by code in the VDSO). The actual inefficiency is converting the unix epoch timestamp into a date/time and formatting it. If it's the same second as before, then why bother doing this conversion and formatting? This is pretty common in servers, for example see the ngx_time_update function in nginx: https://trac.nginx.org/nginx/browser/nginx/src/core/ngx_times.c#L100

Tue Mar 22 15:20:47 2016 The RT System itself - Status changed from 'new' to 'open'

Sat Feb 18 01:26:17 2017 ether [...] cpan.org - Correspondence added

This is now implemented in version 0.17.

Sat Feb 18 01:26:23 2017 ether [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Feb 22 23:08:25 2017 ether [...] cpan.org - Fixed in 0.17 added