Skip Menu |

This queue is for tickets about the IPC-Run CPAN distribution.

Report information
The Basics
Id: 113235
Status: resolved
Priority: 0/
Queue: IPC-Run
People
Owner: Nobody in particular
Requestors: DROLSKY [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.95

History Show all quoted text
  Mon Mar 21 16:09:45 2016 DROLSKY [...] cpan.org - Ticket created
Subject: Code is a mix of tabs & spaces
This makes it really hard to contribute patches. It'd be nice to run this through perltidy or at the very least fix the indentation.
  Tue Mar 22 16:46:51 2016 SREZIC [...] cpan.org - Correspondence added
On 2016-03-21 16:09:45, DROLSKY wrote: Show quoted text
> This makes it really hard to contribute patches. It'd be nice to run > this through perltidy or at the very least fix the indentation.
I see only two or three places where the code style is broken (which is: three spaces for indentation), but most of the code looks consistent to me. Especially it's not an error to mix tabs & spaces as long as a physical tab expands to eight spaces. Unfortunately some modern editors have wrong defaults nowadays...
  Tue Mar 22 16:46:52 2016 The RT System itself - Status changed from 'new' to 'open'
  Tue Apr 12 19:34:20 2016 TODDR [...] cpan.org - Correspondence added
On Mon Mar 21 16:09:45 2016, DROLSKY wrote: Show quoted text
> This makes it really hard to contribute patches. It'd be nice to run > this through perltidy or at the very least fix the indentation.
This annoys me too. Done with https://github.com/toddr/IPC-Run/commit/3c6d9d7a8e11ce51b670f6e7f73f087b9a180123
  Tue Apr 12 19:34:26 2016 TODDR [...] cpan.org - Status changed from 'open' to 'patched'
  Fri May 12 09:27:35 2017 TODDR [...] cpan.org - Status changed from 'patched' to 'resolved'
  Fri May 12 09:27:41 2017 TODDR [...] cpan.org - Fixed in 0.95 added