Bug #11272 for Mail-Box: Possibly missing exit() in Mail::Transport::Sendmail

Fri Jan 28 06:52:07 2005 SREZIC [...] cpan.org - Ticket created

Subject:

Possibly missing exit() in Mail::Transport::Sendmail

In Mail::Transport::Sendmail::trySend, if the exec() fails, the last statement in the the block is "return 0". This means that *two* processes are running from this point on. The "return 0" should be probably replaced by "exit 1". Regards, Slaven

Fri Feb 04 17:28:38 2005 MARKOV [...] cpan.org - Correspondence added

Excelent catch! How did you find-out? To be honest with you, I stole that piece of code from MailTools. It is even silly code, looking at it: if(open(MAILER, '|-')==0) { { exec $program, '-i', '-f', $from, @to; } is long for unless(open MAILER, '|-', $program, '-i', '-f', $from, @to) or am I missing things that way?

Fri Feb 04 17:28:39 2005 MARKOV [...] cpan.org - Status changed from 'new' to 'open'

Fri Feb 04 17:28:39 2005 MARKOV [...] cpan.org - Given to MARKOV

Mon Feb 14 11:19:18 2005 SREZIC [...] cpan.org - Correspondence added

From:

srezic [...] cpan.org

[MARKOV - Fri Feb 4 17:28:38 2005]: Show quoted text

> Excelent catch! How did you find-out? > > To be honest with you, I stole that piece of code from MailTools. It is > even silly code, looking at it: > > if(open(MAILER, '|-')==0) > { { exec $program, '-i', '-f', $from, @to; } > > is long for > > unless(open MAILER, '|-', $program, '-i', '-f', $from, @to) > > or am I missing things that way?

With the latter version you lose compatibility with pre-5.8.0 versions. Regards, Slaven

Tue Mar 15 09:24:47 2005 MARKOV [...] cpan.org - Status changed from 'open' to 'resolved'