Bug #112640 for WebService-Strava: Dwolla.pm introduced bug with LWP-Authen-Oauth2

Wed Mar 02 16:08:09 2016 pavel.leon [...] gmail.com - Ticket created

Subject:	Dwolla.pm introduced bug with LWP-Authen-Oauth2
Date:	Wed, 2 Mar 2016 18:07:59 -0300
To:	bug-WebService-Strava [...] rt.cpan.org
From:	Pablo León <pavel.leon [...] gmail.com>

Hi Leon! Just hacking around with WebService-Strava found, what I think is a bug LWP-Authen-Oauth2 introduced by support of Dwolla The ServiceProvider init() now req

Wed Mar 02 16:11:20 2016 pavel.leon [...] gmail.com - Ticket #112641: Ticket created

Subject:	Re: Dwolla.pm introduced bug with LWP-Authen-Oauth2
Date:	Wed, 2 Mar 2016 18:11:07 -0300
To:	bug-WebService-Strava [...] rt.cpan.org
From:	Pablo León <pavel.leon [...] gmail.com>

Hi Leon! (sorry for the incomplete mail) Just hacking around with WebService-Strava found, what I think is a bug LWP-Authen-Oauth2 introduced by support of Dwolla The ServiceProvider init() now requires ''use_test_urls" parameter, which is used for WS-Dwolla to select which url the authentication will go against, but not used by WS-Strava. I open the bug here instead of LWP-Authen-Oauth2, because I guess it will come anyway to you to decide how to manage it. Regards - Pablo León On Wed, Mar 2, 2016 at 6:07 PM, Pablo León <pavel.leon@gmail.com> wrote: Show quoted text

> > Hi Leon! > > Just hacking around with WebService-Strava found, what I think is a > bug LWP-Authen-Oauth2 > introduced by support of Dwolla > > The ServiceProvider init() now req > >

Wed Mar 02 16:15:07 2016 ether [...] cpan.org - Ticket #112641: Merged into ticket #112640

Wed Mar 02 16:15:07 2016 ether [...] cpan.org - Merged into ticket #112640

Wed Mar 02 19:43:05 2016 techman [...] cpan.org - Taken

Wed Mar 02 19:47:12 2016 techman [...] cpan.org - Correspondence added

Hi Pablo, Thanks for raising this! I'm a maintainer for both this and LWP-Authen-Oauth2, so I'm planning to take a good look on the weekend. I'm guessing the 'use_test_urls' option should be optional and that could be set inside the Strava.pm package that comes with the LWP lib. Leon

Wed Mar 02 19:47:13 2016 The RT System itself - Status changed from 'new' to 'open'

Fri Mar 04 21:34:04 2016 techman [...] cpan.org - Correspondence added

Hi Pablo, If you need a quick solution you can monkey patch LWP/Authen/OAuth2/ServiceProvider.pm in the copy_options sub from $self->copy_option($opts, 'use_test_urls'); to $self->copy_option($opts, 'use_test_urls') if defined $opts->{use_test_urls}; I submitted a PR for one of the other maintainers to review, so I'm sure it'll be updated in no time :) Leon

Sat Mar 05 16:38:49 2016 pavel.leon [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #112640] Dwolla.pm introduced bug with LWP-Authen-Oauth2
Date:	Sat, 05 Mar 2016 21:38:29 +0000
To:	bug-WebService-Strava [...] rt.cpan.org
From:	Pablo León <pavel.leon [...] gmail.com>

Thanks - pablo On Fri, Mar 4, 2016, 23:34 Leon Wright via RT < bug-WebService-Strava@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=112640 > > > Hi Pablo, > > If you need a quick solution you can monkey patch > LWP/Authen/OAuth2/ServiceProvider.pm in the copy_options sub > > from > > $self->copy_option($opts, 'use_test_urls'); > > to > > $self->copy_option($opts, 'use_test_urls') if defined > $opts->{use_test_urls}; > > I submitted a PR for one of the other maintainers to review, so I'm sure > it'll be updated in no time :) > > Leon >

Sun Mar 13 22:37:12 2016 techman [...] cpan.org - Correspondence added

Pablo, The upstream library has been fixed. This will sort out this issue for you. https://metacpan.org/release/LWP-Authen-OAuth2 Regards, Leon

Sun Mar 13 22:37:12 2016 techman [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Mar 14 07:07:19 2016 pavel.leon [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #112640] Dwolla.pm introduced bug with LWP-Authen-Oauth2
Date:	Mon, 14 Mar 2016 11:06:51 +0000
To:	bug-WebService-Strava [...] rt.cpan.org
From:	Pablo León <pavel.leon [...] gmail.com>

Thanks! - Pablo On Sun, Mar 13, 2016, 23:37 Leon Wright via RT < bug-WebService-Strava@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=112640 > > > Pablo, > > The upstream library has been fixed. This will sort out this issue for you. > > https://metacpan.org/release/LWP-Authen-OAuth2 > > Regards, > > Leon >