Bug #112467 for JSON-RPC: double quotes on numeric value in JSON format

Fri Feb 26 19:23:37 2016 denisix [...] gmail.com - Ticket created

Subject:	double quotes on numeric value in JSON format
Date:	Sat, 27 Feb 2016 02:23:20 +0200
To:	bug-JSON-RPC [...] rt.cpan.org
From:	Den <denisix [...] gmail.com>

Hi, I have found that JSON::RPC::Client doesnt work with bitcoin node, after 4 hours of debugging I've found that the issue on JSON format: $content = [{"params":["acc1","acc2","0.0001"],"version":1.1,"method":"move"}] but the correct one should be: $content = [{"params":["acc1","acc2",0.0001],"version":1.1,"method":"move"}] to remove double quotes i've prepared patch for file "Client.pm": Client.pm.patch: 146a147,149 Show quoted text

> # remove double quotes from numeric values > $content =~ s/\"([\d\.\+\-e]+)\"/$1+0/ge; >

Please fix this. Thank you. -- Regards, Den

Sun Feb 28 12:34:24 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-02-26 19:23:37, denisix@gmail.com wrote: Show quoted text

> Hi, > > I have found that JSON::RPC::Client doesnt work with bitcoin node, after > 4 hours of debugging I've found that the issue on JSON format: > > $content = > [{"params":["acc1","acc2","0.0001"],"version":1.1,"method":"move"}] > > but the correct one should be: > $content = > [{"params":["acc1","acc2",0.0001],"version":1.1,"method":"move"}] > > to remove double quotes i've prepared patch for file "Client.pm": > > Client.pm.patch: > 146a147,149

> > # remove double quotes from numeric values > > $content =~ s/\"([\d\.\+\-e]+)\"/$1+0/ge; > >

>

JSON::RPC::Client does not seem to exist anymore in current distribution DMAKI/JSON-RPC-1.06.tar.gz Also, doing stringy changes in the already serialized result might not be that robust. It's better to make sure that numeric values are really numeric _before_ the serialization (e.g. by doing something like this: $data->{numeric}+=0; encode_json $data; )

Sun Feb 28 12:34:24 2016 The RT System itself - Status changed from 'new' to 'open'

Mon Feb 29 03:58:29 2016 denisix [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #112467] double quotes on numeric value in JSON format
Date:	Mon, 29 Feb 2016 08:58:21 +0000
To:	bug-JSON-RPC [...] rt.cpan.org
From:	Den <denisix [...] gmail.com>

Hi, Even if I provide a really numeric value, e.g. 0+$var encode_json double quotes the float value, and thats the issue. -- С уважением Денис On February 28, 2016 7:34:30 PM GMT+02:00, Slaven_Rezic via RT <bug-JSON-RPC@rt.cpan.org> wrote: Show quoted text

><URL: https://rt.cpan.org/Ticket/Display.html?id=112467 > > >On 2016-02-26 19:23:37, denisix@gmail.com wrote:

>> Hi, >> >> I have found that JSON::RPC::Client doesnt work with bitcoin node,

>after

>> 4 hours of debugging I've found that the issue on JSON format: >> >> $content = >> [{"params":["acc1","acc2","0.0001"],"version":1.1,"method":"move"}] >> >> but the correct one should be: >> $content = >> [{"params":["acc1","acc2",0.0001],"version":1.1,"method":"move"}] >> >> to remove double quotes i've prepared patch for file "Client.pm": >> >> Client.pm.patch: >> 146a147,149

>> > # remove double quotes from numeric values >> > $content =~ s/\"([\d\.\+\-e]+)\"/$1+0/ge; >> >

>>

> >JSON::RPC::Client does not seem to exist anymore in current >distribution DMAKI/JSON-RPC-1.06.tar.gz > >Also, doing stringy changes in the already serialized result might not >be that robust. It's better to make sure that numeric values are really >numeric _before_ the serialization (e.g. by doing something like this: > > $data->{numeric}+=0; > encode_json $data; > >)

Mon Feb 29 05:43:15 2016 dmaki [...] cpan.org - Correspondence added

JSON::RPC::Client is no longer bundled in this distribution, and therefore this ticket is no longer applicable. As to your immediate problems, you should probably consider using JSON::Types https://metacpan.org/pod/JSON::Types

Mon Feb 29 05:43:22 2016 dmaki [...] cpan.org - Status changed from 'open' to 'rejected'

Mon Feb 29 15:18:30 2016 SREZIC [...] cpan.org - Correspondence added

On 2016-02-29 03:58:29, denisix@gmail.com wrote: Show quoted text

> Hi, > > Even if I provide a really numeric value, e.g. > > 0+$var > > encode_json double quotes the float value, and thats the issue.

Which json module? Which version? I cannot reproduce this: perl -MCpanel::JSON::XS -E '$num = "3.14159"; $num+=0; say encode_json [$num]' [3.14159] perl -MJSON::XS -E '$num = "3.14159"; $num+=0; say encode_json [$num]' [3.14159] perl -MJSON -E '$num = "3.14159"; $num+=0; say encode_json [$num]' [3.14159]