Skip Menu |

This queue is for tickets about the Scope-Upper CPAN distribution.

Report information
The Basics
Id: 112246
Status: resolved
Priority: 0/
Queue: Scope-Upper
People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
SREZIC [...] cpan.org
Cc: gregoa [...] cpan.org
AdminCc:
Bug Information
Severity: Important
Broken in: 0.28
Fixed in: 0.29

History Show all quoted text
  Sun Feb 21 17:37:04 2016 SREZIC [...] cpan.org - Ticket created
Subject: Compilation failure with perl 5.23.8 (argarray, CXt_LOOP_FOR)
Similar issues: * https://rt.cpan.org/Ticket/Display.html?id=112226 (CXt_LOOP_FOR) * https://rt.cpan.org/Ticket/Display.html?id=112227 (argarray) ... cc -c -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_FORTIFY_SOURCE=2 -O2 -pipe -DVERSION=\"0.28\" -DXS_VERSION=\"0.28\" -DPI C -fPIC "-I/usr/perl5.23.8p/lib/5.23.8/amd64-freebsd/CORE" -DSU_RELEASE=1 Upper.c Upper.xs:1331:11: error: use of undeclared identifier 'CXt_LOOP_FOR' case CXt_LOOP_FOR: ^ ... Upper.xs:1543:31: error: no member named 'argarray' in 'struct block_sub' argarray = cx->blk_sub.argarray; ~~~~~~~~~~~ ^ ...
  Sun Feb 21 17:37:28 2016 SREZIC [...] cpan.org - Reference to ticket #112226 added
  Sun Feb 21 17:37:28 2016 SREZIC [...] cpan.org - Reference to ticket #112227 added
  Mon Feb 22 08:47:50 2016 vpit [...] cpan.org - Correspondence added
This has already been reported to p5p : http://www.nntp.perl.org/group/perl.perl5.porters/2016/01/msg233631.html The compilation failures are not the actual issue there, as they are easy to fix. The real catch is that the extensive changes to the context stack system have deeply broken the implementation of Scope::Upper. Dave had a quick look at how to fix it, but I'm not really bought on his solution - at least, not enough that it would be reasonable for me to spend time on investigating this thoroughly while I have already my hands full with other topics. As such, this module will likely stay broken until someone steps in to fix it.
  Mon Feb 22 08:47:51 2016 The RT System itself - Status changed from 'new' to 'open'
  Thu Apr 07 12:13:38 2016 KENTNL [...] cpan.org - Correspondence added
Just attaching Dave_M's patch from P5P discussion to this ticket for visibility.
Subject: scope_upper.diff

Message body is not shown because it is too large.

  Thu Apr 07 12:14:44 2016 KENTNL [...] cpan.org - Requestor KENTNL added
  Sun May 22 10:44:43 2016 gregoa [...] cpan.org - Cc GREGOA added
  Mon May 30 04:55:22 2016 ppisar [...] redhat.com - Correspondence added
From: ppisar [...] redhat.com
Dne Ne 21.úno.2016 17:37:04, SREZIC napsal(a): Show quoted text
> Similar issues: > * https://rt.cpan.org/Ticket/Display.html?id=112226 (CXt_LOOP_FOR) > * https://rt.cpan.org/Ticket/Display.html?id=112227 (argarray) > > ... > cc -c -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing > -pipe -fstack-protector -I/usr/local/include -D_FORTIFY_SOURCE=2 -O2 > -pipe -DVERSION=\"0.28\" -DXS_VERSION=\"0.28\" -DPI > C -fPIC "-I/usr/perl5.23.8p/lib/5.23.8/amd64-freebsd/CORE" > -DSU_RELEASE=1 Upper.c > Upper.xs:1331:11: error: use of undeclared identifier 'CXt_LOOP_FOR' > case CXt_LOOP_FOR: > ^ > ... > Upper.xs:1543:31: error: no member named 'argarray' in 'struct > block_sub' > argarray = cx->blk_sub.argarray; > ~~~~~~~~~~~ ^ > ...
David Mitchell provided set of 8 patches built on top of current git tree that fixes the code and the tests. See <http://permalink.gmane.org/gmane.comp.lang.perl.perl5.porters/159083>.
  Sun Jun 05 08:17:45 2016 KENTNL [...] cpan.org - Correspondence added

I didn't realise I only posted this link earlier to the P5P thread of the same nature.

 

Here is a locally patched Scope-Upper patched to 0.28_01 by applying davem's patches for those who are in desperate need  or just want to test.

 

http://kentfredric.github.io/cpan-fixes/perl-5.24.0/Scope-Upper/Scope-Upper-0.28_01.tar.gz

 

I hope something like this can end up shipped, and so far, its passing tests, as are things that depend on it.

 

http://fast-matrix.cpantesters.org/?dist=Scope-Upper%200.28_01

http://fast-matrix.cpantesters.org/?dist=TryCatch;os=linux;perl=5.25.1;reports=1

  Thu Jun 09 09:38:15 2016 vpit [...] cpan.org - Correspondence added
Version 0.29 was released a few days ago with Dave's fixes.
  Thu Jun 09 09:38:15 2016 vpit [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Jun 09 09:38:20 2016 vpit [...] cpan.org - Fixed in 0.29 added
  Thu Jun 09 09:38:37 2016 vpit [...] cpan.org - Severity Important added